[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Blocks||26268 Referenced Bugs:

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Jonathan Druart changed: What|Removed |Added Blocks||26012 Referenced Bugs:

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 koha-US bug tracker changed: What|Removed |Added CC|bugzi...@koha-us.org| -- You are

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Keywords|RM_priority | -- You are receiving

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Bug 19919 depends on bug 22563, which changed state. Bug 22563 Summary: Convert lost handling to use 'status' instead of multiple accounttypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 What

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #47 from Magnus Enger --- As far as I can tell, this does not remove values that are already in items.paidfor. Should we at least add a note somewhere (release notes?) to say that libraries need to run something like

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to master|RESOLVED

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Fridolin SOMERS changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Blocks|14825 |11573 Referenced Bugs:

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #45 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Version(s)||19.11.00 released

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Status|Passed QA |BLOCKED -- You are

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #44

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Keywords||RM_priority -- You are

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #43 from Kyle M Hall --- Created attachment 90230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90230=edit Bug 19919: Unit Tests This patch adds unit tests for the addition of a patron accessor to

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Kyle M Hall changed: What|Removed |Added Attachment #90228|0 |1 is obsolete|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Kyle M Hall changed: What|Removed |Added Attachment #89816|0 |1 is obsolete|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Kyle M Hall changed: What|Removed |Added Status|BLOCKED |Needs Signoff -- You are

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #40

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Attachment #89814|0 |1 is obsolete|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Attachment #89815|0 |1 is obsolete|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Attachment #89794|0 |1 is obsolete|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #37 from Martin Renvoize --- Created attachment 89815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89815=edit Bug 19919: Unit Tests Signed-off-by: Martin Renvoize -- You are receiving this mail

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Liz Rea changed: What|Removed |Added Attachment #89472|0 |1 is obsolete|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #34 from

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #33 from Liz Rea --- GO GO UNIT TEST MASTAH. :D We think the concept is good afaict. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #31 from Martin Renvoize --- So... are we close to a signoff.. I'm not sure how to read the last comments? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #32 from Martin Renvoize --- If I get a signoff that the concept is right, I'll throw together the outstanding unit test quickly for the QA step. -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #30 from Katrin Fischer --- (In reply to Liz Rea from comment #29) > The only problem i see here is that when we delete the patron, this paid for > record will go away? or will it not I can't remember if we delete the >

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #29 from Liz Rea --- The only problem i see here is that when we delete the patron, this paid for record will go away? or will it not I can't remember if we delete the accountlines when we delete a patron. Anyway it

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #28 from Martin Renvoize --- (In reply to George Williams (NEKLS) from comment #27) > (In reply to Chris Cormack from comment #20) > > They still use it, so if it could be fixed rather than removed would be > > great. >

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #27 from George Williams (NEKLS) --- (In reply to Chris Cormack from comment #20) > They still use it, so if it could be fixed rather than removed would be > great. > Always a shame when we break things the Original Koha

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com --

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Attachment #89459|0 |1 is obsolete|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Attachment #89356|0 |1 is obsolete|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Depends on||22563 Referenced Bugs:

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff ---

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #24 from Martin Renvoize --- Created attachment 89459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89459=edit Bug 19919: Stop using paidfor altogether -- You are receiving this mail because: You

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #22 from Katrin Fischer --- My concerns here are the issues of translatability and privacy. We store a patron name in items... which we expose for export practically everywhere. I think it would be really nice to keep

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #23 from Katrin Fischer --- Would moving it out of items be ok? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #21 from Martin Renvoize --- (In reply to Chris Cormack from comment #20) > They still use it, so if it could be fixed rather than removed would be > great. > Always a shame when we break things the Original Koha library

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #20

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Katrin Fischer changed: What|Removed |Added CC||ch...@bigballofwax.co.nz

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #17 from Martin Renvoize --- I've uploaded a refreshed patch freshly based against master. I've not written a test for it yet - I wasn't sure whether this was actually what people wanted here (and to split out the

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Attachment #89320|0 |1 is obsolete|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #15 from Jonathan Druart --- Martin, the patch does not apply: error: sha1 information is lacking or useless (C4/Circulation.pm). -- You are receiving this mail because: You are the assignee for the bug. You are

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff ---

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #13 from Martin Renvoize --- Created attachment 89320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89320=edit Bug 19919: Do not record payments for a writeoff -- You are receiving this mail

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize changed: What|Removed |Added Blocks||14825

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #12 from Katrin Fischer --- *** Bug 18868 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Katrin Fischer changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 robbi...@middlesex.mass.edu changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #10 from Christopher Brannon --- (In reply to George Williams (NEKLS) from comment #9) > I'm in favor of removing this altogether if it's not needed. > > If it is needed, then I'd like to see the patron information

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #9 from George Williams (NEKLS) --- I'm in favor of removing this altogether if it's not needed. If it is needed, then I'd like to see the patron information stored as the patron's borrowernumber of barcode number

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #8 from Jonathan Druart --- (In reply to Magnus Enger from comment #5) > Can anyone describe a use case for storing this info in items.paidfor? I found that: 2001-05-17 15:36 rangi * database.mysql: Changed the

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Christopher Brannon changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #6 from Katrin Fischer --- (In reply to Magnus Enger from comment #5) > Storing this info on the item level is also problematic in light of GDPR. > > Can anyone describe a use case for storing

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Magnus Enger changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Edie Discher changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 George Williams (NEKLS) changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Barton Chittenden changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Jessie Zairo changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Jessie Zairo changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Lisette changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Christopher Davis changed: What|Removed |Added CC|