https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Joy Nelson changed:
What|Removed |Added
CC||j...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #59 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Marcel de Rooy changed:
What|Removed |Added
Attachment #99433|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Marcel de Rooy changed:
What|Removed |Added
Attachment #99431|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Marcel de Rooy changed:
What|Removed |Added
Attachment #99432|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #55
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Bouzid Fergani changed:
What|Removed |Added
Attachment #94995|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Bouzid Fergani changed:
What|Removed |Added
Attachment #94996|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Bouzid Fergani changed:
What|Removed |Added
Attachment #94997|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #51 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #50)
> That's correct, I didn't copy the file. From where to where do you have to
> copy it? A test plan would be helpful.
Koha scripts are in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #50 from Katrin Fischer ---
That's correct, I didn't copy the file. From where to where do you have to copy
it? A test plan would be helpful.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #47 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #43)
> (In reply to Jonathan Druart from comment #42)
> > Still waiting for another QA feedback, back to NQA.
>
> I am still hoping for tests :)
Hi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #46 from Jonathan Druart
---
Created attachment 94997
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94997=edit
Bug 20116: Cache language list
Signed-off-by: Liz Rea
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #45 from Jonathan Druart
---
Created attachment 94996
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94996=edit
Bug 20116: Flush the caches
When languages are added or removed when need to flush the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
Attachment #88200|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #43
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #41 from Jonathan Druart
---
(In reply to M. Tompsett from comment #39)
> In addition to the whole $KOHA_HOME path existing in live problem, perhaps
> the flushing could be split to a separate patch, so that bug 20884
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #40 from Jonathan Druart
---
(In reply to M. Tompsett from comment #38)
> Comment on attachment 88201 [details] [review]
> Bug 20116: Flush the caches
>
> Review of attachment 88201 [details] [review]:
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
M. Tompsett changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
M. Tompsett changed:
What|Removed |Added
CC||mtomp...@hotmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #38 from M. Tompsett ---
Comment on attachment 88201
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88201
Bug 20116: Flush the caches
Review of attachment 88201:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #36 from Jonathan Druart
---
(In reply to Guillaume from comment #35)
> in file /etc/koha/koha-sites.conf
> in find MEMCACHED_SERVERS="127.0.0.1:11211"
>
> and in configuration MEMCACHED is on this server:
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #35 from Guillaume ---
in file /etc/koha/koha-sites.conf
in find MEMCACHED_SERVERS="127.0.0.1:11211"
and in configuration MEMCACHED is on this server:
systemctl status memcached.service
â memcached.service -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #34 from Jonathan Druart
---
(In reply to Guillaume from comment #33)
Hello Guillaume,
Edit $KOHA_CONF and search for "__MEMCACHED_SERVERS__", replace it with
"127.0.0.1:11211" or adjust depending on your needs. If it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Guillaume changed:
What|Removed |Added
CC||guilla...@terreau.eu
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #32 from Jonathan Druart
---
I do not see the point of those tests. The patches are just caching a value,
there is nothing to prove.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #31 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #30)
> Hi Marcel,
> I have still no idea how to write useful tests for this change, can you give
> me more details please?
Mock the directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #30 from Jonathan Druart
---
Hi Marcel,
I have still no idea how to write useful tests for this change, can you give me
more details please?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #29 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #19)
> (In reply to Tomás Cohen Arazi from comment #18)
> > Jonathan, it looks great. Will you provide a couple tests for this?
>
> I do not think it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #28
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #27 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #26)
> (In reply to Marcel de Rooy from comment #25)
> > +my @enabled_languages =
> > + ( $interface && $interface eq 'intranet' )
> > +
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #26 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #25)
> +my @enabled_languages =
> + ( $interface && $interface eq 'intranet' )
> + ? split ",", C4::Context->preference('language')
> +
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #23 from Liz Rea ---
Created attachment 88201
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88201=edit
Bug 20116: Flush the caches
When languages are added or removed when need to flush the caches to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #24 from Liz Rea ---
Created attachment 88202
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88202=edit
Bug 20116: Cache language list
Signed-off-by: Liz Rea
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Liz Rea changed:
What|Removed |Added
Attachment #75382|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Liz Rea changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #21 from Liz Rea ---
Had a talk with Tomas, he thinks this is fine so I"ll attach a signed off one
for QA to have a look at.
Liz
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Liz Rea changed:
What|Removed |Added
CC||wizzy...@gmail.com
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Bug 20116 depends on bug 20115, which changed state.
Bug 20115 Summary: Languages appear in a different order in the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #19 from Jonathan Druart
---
(In reply to Tomás Cohen Arazi from comment #18)
> Jonathan, it looks great. Will you provide a couple tests for this?
I do not think it can be done easily, any ideas?
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #18 from Tomás Cohen Arazi ---
Jonathan, it looks great. Will you provide a couple tests for this?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #17 from Jonathan Druart
---
(Of course first hit is worse)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #16 from Jonathan Druart
---
Before the patches, C4::Languages::getTranslatedLanguages('intranet', 'prog')
took between 0.002 and 0.003s
Now it's 0.0015s (and I guess the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
Attachment #75383|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #14 from Jonathan Druart
---
Created attachment 75384
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75384=edit
Bug 20116: Flush the caches
When languages are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
Attachment #73619|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #13 from Jonathan Druart
---
Created attachment 75383
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75383=edit
Bug 20116: Cache language list
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #11 from Jonathan Druart
---
(In reply to Josef Moravec from comment #8)
> Comment on attachment 71097 [details] [review]
> Bug 20116: Prepare the ground
>
> Review of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #10 from Jonathan Druart
---
Created attachment 73620
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73620=edit
Bug 20116: Cache language list
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
Attachment #71097|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #8 from Josef Moravec ---
Comment on attachment 71097
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71097
Bug 20116: Prepare the ground
Review of attachment 71097:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #7 from Jonathan Druart
---
(In reply to M. Tompsett from comment #5)
> Comment on attachment 71098 [details] [review]
> Bug 20116: Cache language list
>
> Review of attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
Attachment #71098|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #5 from M. Tompsett ---
Comment on attachment 71098
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71098
Bug 20116: Cache language list
Review of attachment 71098:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #4 from Jonathan Druart
---
TODO: We should add a warning to koha-translate to restart memcached (or
better, clear only what is needed)
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #3 from Jonathan Druart
---
Do these patches make sense?
It seems that some call to getTranslatedLanguages are wrong:
1.
members/memberentry.pl:my $translated_languages =
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #2 from Jonathan Druart
---
Created attachment 71098
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71098=edit
Bug 20116: Cache language list
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #1 from Jonathan Druart
---
Created attachment 71097
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71097=edit
Bug 20116: Prepare the ground
Just refactoring
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED
73 matches
Mail list logo