https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
David Cook changed:
What|Removed |Added
Status|NEW |Needs Signoff
Patch complexi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #1 from David Cook ---
Created attachment 71408
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71408&action=edit
Bug 20173 - Clean up koha-tmpl directory
This patch removes some HTML and ico files that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #2 from David Cook ---
Note:
These files don't even make it through the build process of Koha, as far as I
can tell.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
M. Tompsett changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
Assignee|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #5 from M. Tompsett ---
(In reply to Katrin Fischer from comment #4)
> Why do you think the favicon is not used?
Because the templates only use the ones in the image subdirectories, not the
koha-tmpl directory directly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #6 from Katrin Fischer ---
Owen confirmed on IRC that the favicon.ico can go.
Do we have an idea if the rest of the files is needed or why they were added in
the first place?
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
David Cook changed:
What|Removed |Added
Status|Failed QA |In Discussion
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #7 from David Cook ---
(In reply to M. Tompsett from comment #3)
> I confirmed the favicon.ico, but then your patch to remove things didn't
> include it.
>
Yes it does. Look at "Splinter Review" then "Overview". It will
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #8 from M. Tompsett ---
(In reply to David Cook from comment #7)
> (In reply to M. Tompsett from comment #3)
> > I confirmed the favicon.ico, but then your patch to remove things didn't
> > include it.
> >
>
> Yes it do
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #9 from David Cook ---
(In reply to M. Tompsett from comment #8)
> I stand corrected. Okay. But could someone clarify the proper course of
> action with index.html?
>
>
> > ... this index.html ... [is] ... referring to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
M. Tompsett changed:
What|Removed |Added
Status|In Discussion |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
M. Tompsett changed:
What|Removed |Added
Attachment #71408|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
Julian Maurice changed:
What|Removed |Added
CC||julian.maur...@biblibre.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
David Cook changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
David Cook changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #12 from David Cook ---
(In reply to Julian Maurice from comment #11)
> There is still a reference to this favicon.ico in
> koha-tmpl/intranet-tmpl/prog/en/includes/installer-doc-head-close.inc:
>
>
I don't really thin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #13 from David Cook ---
(In reply to Julian Maurice from comment #11)
> There is still a reference to this favicon.ico in
> koha-tmpl/intranet-tmpl/prog/en/includes/installer-doc-head-close.inc:
>
>
So I'm actually fin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #14 from David Cook ---
Created a fake favicon.ico and the browser is still showing the real Koha
one... but I see the following in the network tab:
favicon.ico 200 x-icon Other 269 B 3 ms652379
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #15 from David Cook ---
If I try to visit the favicon, I see the following:
favicon.ico 200 documentOther 269 B 9 ms655653
favicon.ico 200 x-icon Other (from disk cache) 1 ms
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #16 from David Cook ---
Whoa, this is cool/scary:
I created ./koha-tmpl/favicon2.ico and I'm visiting the URL: "/favicon2.ico" on Tab 2 of my browser. On Tab 1, I'm visiting
"/cgi-bin/koha/installer/install.pl?step=1&op=
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #17 from David Cook ---
OK I don't quite know how it's doing it, but it is caching super heavily. I
just used the following "convert -size 200x200 xc:none -fill red -draw "circle
20,20 10,10 circle 100,100 50,50" favicon.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #18 from David Cook ---
Guess it doesn't really matter how it's doing it. I'll just update the file to
be consistent with the other intranet pages.
Interesting how browsers try to outsmart the servers though...
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
David Cook changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #19 from David Cook ---
Created attachment 71917
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71917&action=edit
Fix favicon.ico path in installer
This patch corrects the favicon.ico path for the inst
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #20 from Fridolin SOMERS ---
Created attachment 72249
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72249&action=edit
Bug 20173: Clean up koha-tmpl directory
This patch removes some HTML and ico files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #21 from Fridolin SOMERS ---
Created attachment 72250
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72250&action=edit
Bug 20173: Fix favicon.ico path in installer
This patch corrects the favicon.ico p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
Fridolin SOMERS changed:
What|Removed |Added
Attachment #71695|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolin.som...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
Fridolin SOMERS changed:
What|Removed |Added
Attachment #71917|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
--- Comment #23 from Katrin Fischer ---
Favicons still display, can find no references to the files.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
Katrin Fischer changed:
What|Removed |Added
Attachment #72249|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
Katrin Fischer changed:
What|Removed |Added
Attachment #72250|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20173
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Comm
35 matches
Mail list logo