https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #390 from Kyle M Hall ---
Created attachment 143536
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143536=edit
Bug 20256: (QA follow-up) Change meaning should change code
Signed-off-by: Bob Bennhoff -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #389 from Kyle M Hall ---
Created attachment 143535
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143535=edit
Bug 20256: (QA follow-up) Remove double negative from code
Signed-off-by: Bob Bennhoff -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #388 from Kyle M Hall ---
Created attachment 143534
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143534=edit
Bug 20256: Add unit tests
Signed-off-by: Bob Bennhoff - CLiC
Signed-off-by: Martin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #387 from Kyle M Hall ---
Created attachment 143533
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143533=edit
Bug 20256: Use new methods
Signed-off-by: Bob Bennhoff - CLiC
Signed-off-by: Martin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #386 from Kyle M Hall ---
Created attachment 143532
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143532=edit
Bug 20256: Update groups editor
Signed-off-by: Bob Bennhoff - CLiC
Signed-off-by: Martin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #385 from Kyle M Hall ---
Created attachment 143531
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143531=edit
Bug 20256: Add new methods for checking item editing permissions
Signed-off-by: Bob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #384 from Kyle M Hall ---
Created attachment 143530
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143530=edit
Bug 20256: Refactor subs for rights to view patrons to make them generic for
general use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #383 from Kyle M Hall ---
Created attachment 143529
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143529=edit
Bug 20256: Add new permission to editor
Signed-off-by: Bob Bennhoff - CLiC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Kyle M Hall changed:
What|Removed |Added
Attachment #139135|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Kyle M Hall changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords|rel_22_11_candidate |rel_23_05_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #380 from Kyle M Hall ---
Created attachment 139163
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139163=edit
Bug 20256: (QA follow-up) Hide link to delete item if unable to delete the item
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #379 from Kyle M Hall ---
Created attachment 139162
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139162=edit
Bug 20256: (QA follow-up) Fix explosion for items batch edit
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #378 from Kyle M Hall ---
Created attachment 139161
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139161=edit
Bug 20256: (QA follow-up) Allow removal of course reserves for items that
cannot be edited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #377 from Kyle M Hall ---
Created attachment 139160
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139160=edit
Bug 20256: (QA follow-up) hide Edit chooice in Actions on items editor if item
cannot be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #376 from Kyle M Hall ---
Created attachment 139159
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139159=edit
Bug 20256: (QA follow-up) Fix typo in permission descriptions
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #375 from Kyle M Hall ---
Created attachment 139158
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139158=edit
Bug 20256: (QA follow-up) Update group feature description
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #374 from Kyle M Hall ---
Created attachment 139157
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139157=edit
Bug 20256: (QA follow-up) Update permission descriptions
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #373 from Kyle M Hall ---
Created attachment 139156
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139156=edit
Bug 20256: (QA follow-up) Remove duplicated sub
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #372 from Kyle M Hall ---
Created attachment 139155
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139155=edit
Bug 20256: (QA follow-up) Fix typo in comment on kohastructure.sql
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #371 from Kyle M Hall ---
Created attachment 139154
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139154=edit
Bug 20256: (follow-up) Fix spelling
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #370 from Kyle M Hall ---
Created attachment 139153
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139153=edit
Bug 20256: Update DB Schema [DO NOT PUSH]
Signed-off-by: Martin Renvoize
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #369 from Kyle M Hall ---
Created attachment 139152
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139152=edit
Bug 20256: (QA follow-up) Implement for item search
Signed-off-by: Martin Renvoize
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #368 from Kyle M Hall ---
Created attachment 139151
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139151=edit
Bug 20256: (QA follow-up) Implement for course reserves
Signed-off-by: Martin Renvoize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #367 from Kyle M Hall ---
Created attachment 139150
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139150=edit
Bug 20256: Mark ft_limit_item_editing as boolean in schema file
Signed-off-by: Bob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #366 from Kyle M Hall ---
Created attachment 139149
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139149=edit
Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions
for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #365 from Kyle M Hall ---
Created attachment 139148
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139148=edit
Bug 20256: (QA follow-up) Give existing users with edit_items permission
edit_any_item as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #364 from Kyle M Hall ---
Created attachment 139147
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139147=edit
Bug 20256: (QA follow-up) Handle non-existing userenv
Signed-off-by: Bob Bennhoff - CLiC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #363 from Kyle M Hall ---
Created attachment 139146
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139146=edit
Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit
this item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #362 from Kyle M Hall ---
Created attachment 139145
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139145=edit
Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #361 from Kyle M Hall ---
Created attachment 139144
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139144=edit
Bug 20256: (QA follow-up) test borrowernumber in userenv too
Bug 22600 added userenv for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #360 from Kyle M Hall ---
Created attachment 139143
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139143=edit
Bug 20256: (QA follow-up) Change meaning should change code
Signed-off-by: Bob Bennhoff -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #359 from Kyle M Hall ---
Created attachment 139142
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139142=edit
Bug 20256: (QA follow-up) Remove double negative from code
Signed-off-by: Bob Bennhoff -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #358 from Kyle M Hall ---
Created attachment 139141
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139141=edit
Bug 20256: Add unit tests
Signed-off-by: Bob Bennhoff - CLiC
Signed-off-by: Martin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #357 from Kyle M Hall ---
Created attachment 139140
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139140=edit
Bug 20256: Use new methods
Signed-off-by: Bob Bennhoff - CLiC
Signed-off-by: Martin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #356 from Kyle M Hall ---
Created attachment 139139
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139139=edit
Bug 20256: Update groups editor
Signed-off-by: Bob Bennhoff - CLiC
Signed-off-by: Martin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #355 from Kyle M Hall ---
Created attachment 139138
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139138=edit
Bug 20256: Add new methods for checking item editing permissions
Signed-off-by: Bob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #354 from Kyle M Hall ---
Created attachment 139137
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139137=edit
Bug 20256: Refactor subs for rights to view patrons to make them generic for
general use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #353 from Kyle M Hall ---
Created attachment 139136
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139136=edit
Bug 20256: Add new permission to editor
Signed-off-by: Bob Bennhoff - CLiC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Kyle M Hall changed:
What|Removed |Added
Attachment #131676|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
CC||neng...@gmail.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Victor Grousset/tuxayo changed:
What|Removed |Added
Patch complexity|--- |Large patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #350 from Kyle M Hall ---
> "Test case 4:
> * edit_items = yes
> * edit_any_items = yes
> * Independentbranches = YES
> * No library groups defined
>
> All items can be edited. Same as with Indybranches off."
>
> Can
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #349 from Katrin Fischer ---
(In reply to Kyle M Hall from comment #348)
> > Summary:
> > ==> The new edit_any_items overwrites the Indybranches pref. In consequence
> > it appears it no longer has any effect. Correct?
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #348
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #347 from Kyle M Hall ---
Created attachment 134377
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134377=edit
Bug 20256: (QA follow-up) Fix explosion for items batch edit
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #346 from Kyle M Hall ---
Created attachment 134376
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134376=edit
Bug 20256: (QA follow-up) Allow removal of course reserves for items that
cannot be edited
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #345 from Kyle M Hall ---
Created attachment 134375
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134375=edit
Bug 20256: (QA follow-up) hide Edit chooice in Actions on items editor if item
cannot be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #344 from Katrin Fischer ---
=Testing restrictions=
Test case 1:
* edit_items = yes
* edit_any_items = no
* Independentbranches = NO
* No library groups defined
Only items from home branch can be edited.
Test case 2:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #343 from Katrin Fischer ---
Ok, I misread the database update, there actually is an update!
+$dbh->do(q{
+INSERT INTO user_permissions ( borrowernumber, module_bit, code )
+SELECT borrowernumber,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #341 from Katrin Fischer ---
Created attachment 132917
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132917=edit
Bug 20256: (QA follow-up) Fix typo in permission descriptions
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #340 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #336)
> Patches still apply with a tiny rebase :)
>
> I've added the rebased patch set with 2 tiny follow-ups, but have some
> issues I am struggling
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #339 from Kyle M Hall ---
Created attachment 132486
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132486=edit
Bug 20256: (QA follow-up) Update group feature description
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #338 from Kyle M Hall ---
Created attachment 132484
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132484=edit
Bug 20256: (QA follow-up) Update permission descriptions
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #337 from Kyle M Hall ---
Created attachment 132483
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132483=edit
Bug 20256: (QA follow-up) Remove duplicated sub
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #335 from Katrin Fischer ---
Created attachment 131697
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131697=edit
Bug 20256: (QA follow-up) Fix typo in comment on kohastructure.sql
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #334 from Katrin Fischer ---
Created attachment 131696
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131696=edit
Bug 20256: (QA follow-up) Fix number of tests in Patrons.t
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128753|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128752|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128751|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128750|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128749|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128748|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128747|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128746|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128745|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128744|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128743|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128742|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128741|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128740|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128739|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128738|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128737|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128736|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128735|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Katrin Fischer changed:
What|Removed |Added
Attachment #128734|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
Kyle M Hall changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #313 from Kyle M Hall ---
Created attachment 128753
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128753=edit
Bug 20256: (follow-up) Fix spelling
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #312 from Kyle M Hall ---
Created attachment 128752
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128752=edit
Bug 20256: Update DB Schema [DO NOT PUSH]
Signed-off-by: Martin Renvoize
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #311 from Kyle M Hall ---
Created attachment 128751
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128751=edit
Bug 20256: (QA follow-up) Implement for item search
Signed-off-by: Martin Renvoize
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #310 from Kyle M Hall ---
Created attachment 128750
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128750=edit
Bug 20256: (QA follow-up) Implement for course reserves
Signed-off-by: Martin Renvoize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #309 from Kyle M Hall ---
Created attachment 128749
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128749=edit
Bug 20256: Mark ft_limit_item_editing as boolean in schema file
Signed-off-by: Bob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #308 from Kyle M Hall ---
Created attachment 128748
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128748=edit
Bug 20256: (QA follow-up) Filter out branchcodes the user has no permissions
for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #307 from Kyle M Hall ---
Created attachment 128747
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128747=edit
Bug 20256: (QA follow-up) Give existing users with edit_items permission
edit_any_item as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #306 from Kyle M Hall ---
Created attachment 128746
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128746=edit
Bug 20256: (QA follow-up) Handle non-existing userenv
Signed-off-by: Bob Bennhoff - CLiC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #305 from Kyle M Hall ---
Created attachment 128745
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128745=edit
Bug 20256: (QA follow-up) Redirect to record details page if user cannot edit
this item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #304 from Kyle M Hall ---
Created attachment 128744
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128744=edit
Bug 20256: (QA follow-up) Fix missed change from item.cannot_be_edited to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #303 from Kyle M Hall ---
Created attachment 128743
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128743=edit
Bug 20256: (QA follow-up) test borrowernumber in userenv too
Bug 22600 added userenv for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #302 from Kyle M Hall ---
Created attachment 128742
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128742=edit
Bug 20256: (QA follow-up) Change meaning should change code
Signed-off-by: Bob Bennhoff -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #301 from Kyle M Hall ---
Created attachment 128741
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128741=edit
Bug 20256: (QA follow-up) Remove double negative from code
Signed-off-by: Bob Bennhoff -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #300 from Kyle M Hall ---
Created attachment 128740
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128740=edit
Bug 20256: Add unit tests
Signed-off-by: Bob Bennhoff - CLiC
Signed-off-by: Martin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #299 from Kyle M Hall ---
Created attachment 128739
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128739=edit
Bug 20256: Use new methods
Signed-off-by: Bob Bennhoff - CLiC
Signed-off-by: Martin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256
--- Comment #298 from Kyle M Hall ---
Created attachment 128738
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128738=edit
Bug 20256: Update groups editor
Signed-off-by: Bob Bennhoff - CLiC
Signed-off-by: Martin
101 - 200 of 526 matches
Mail list logo