https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
David Nind changed:
What|Removed |Added
Text to go in the|This enhancement adds a new |This enhancement adds a new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Kyle M Hall changed:
What|Removed |Added
Resolution|--- |FIXED
Status|Push
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #42 from Fridolin Somers ---
Pushed to master for 22.05, thanks to everybody involved 🦄
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Fridolin Somers changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #41 from Fridolin Somers ---
Commit messages corrected :
no space before ':'
Follow-up => follow-up
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Fridolin Somers changed:
What|Removed |Added
Patch complexity|--- |Small patch
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #40 from Thibaud Guillot ---
Created attachment 132414
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132414&action=edit
Bug 20398: (QA Follow-up) Fix position of 'if' statement
--
You are receiving t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #39 from Fridolin Somers ---
In results.js :
Shouldn't block :
if( PREF_StaffHighlightedWords == 1 ){
highlightOn();
} else {
highlightOff();
}
Be inside :
if( search_result.query_desc )
?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #38 from Thibaud Guillot ---
Hi Katrin,
Thanks to you, I will remember that :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #37 from Katrin Fischer ---
Hi Thibaud,
1) Commit message
Please make sure to run the QA test tools on your patches - they can highlight
things like mistakes with the commit message and give other helpful hints. In
this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #36 from Katrin Fischer ---
Created attachment 130532
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130532&action=edit
Bug 20398: (QA follow-up) Fix alphabetical order in sysprefs.sql
Signed-off-by: K
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Katrin Fischer changed:
What|Removed |Added
Attachment #130450|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
David Nind changed:
What|Removed |Added
Text to go in the||This enhancement adds a new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Kyle M Hall changed:
What|Removed |Added
Attachment #130446|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #33 from Thibaud Guillot ---
(In reply to e.betemps from comment #31)
> (but the name of the syspref is 'StaffHighlightedWords')
yes.. I saw that I forgot to change the name in my test plan with latest
changes... this is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Thibaud Guillot changed:
What|Removed |Added
Attachment #130429|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #31 from e.betemps ---
(but the name of the syspref is 'StaffHighlightedWords')
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
e.betemps changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #30 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Kyle M Hall changed:
What|Removed |Added
Attachment #130426|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #28 from Thibaud Guillot ---
(In reply to David Nind from comment #25)
> Patch no longer applies 8-(... things move too fast sometimes!
>
> Apply? [(y)es, (n)o, (i)nteractive] y
> Applying: Bug 20398 : Added a syspref to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Thibaud Guillot changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Thibaud Guillot changed:
What|Removed |Added
Attachment #130420|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
e.betemps changed:
What|Removed |Added
CC||e.bete...@gmail.com
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #26 from David Nind ---
(In reply to Thibaud Guillot from comment #24)
>
> Yes David you are absolutely right, yesterday when I rebased the patch I
> forgot to change some variable names on the script that manages the
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #24 from Thibaud Guillot ---
(In reply to David Nind from comment #22)
> (In reply to Thibaud Guillot from comment #21)
>
> > Also for the description, my english is not as good as i would like ^^ so I
> > change this to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Thibaud Guillot changed:
What|Removed |Added
Attachment #130396|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #22 from David Nind ---
(In reply to Thibaud Guillot from comment #21)
> Also for the description, my english is not as good as i would like ^^ so I
> change this too.
Hi Thibaud.
Thanks for incorporating my suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #21 from Thibaud Guillot ---
(In reply to David Nind from comment #19)
> I have tested this and it works as expected. I would suggest these changes:
>
> 1. System preference name: change from HighlightedWords to
> Staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Thibaud Guillot changed:
What|Removed |Added
Attachment #128359|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #20 from Thibaud Guillot ---
Created attachment 130396
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130396&action=edit
Added a syspref to highlight or not highlight search terms in results on the
staf
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #18 from Thibaud Guillot ---
Because it can concerned other syspref and this can be interesting to develop
more I created https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29701
--
You are receiving this mail be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #17 from Thibaud Guillot ---
For now maybe someone can test my patch and tell if it's appropriate or not ?
"Highlighting" and "Unhighlighting" options are still possible on the go when
syspref isn't set to "Highlight" (by
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #16 from Katrin Fischer ---
What I am trying to say: this is a feature that is not wanted by some and we
have a lot of feature on/off switches. I don't see the difference with this
one?
Having it in localstorage would b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #15 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #13)
> Why do we need the syspref if each user can decide if they want the feature?
> We could (later) remove OpacHighlightedWords and use local storag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #14 from Thibaud Guillot ---
I agree, it's like "killing an ant with a tank" to remove the highlight by
adding a syspref, run updatedatabase.pl, add a conditioner... etc.
I wanted to keep the same behavior as OPAC for so
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #13 from Jonathan Druart ---
Why do we need the syspref if each user can decide if they want the feature?
We could (later) remove OpacHighlightedWords and use local storage for OPAC as
well.
The reason I see would be to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #12 from Owen Leonard ---
I think that the existence of OpacHighlightedWords makes it logical to add a
preference for the staff interface. I agree that the "stopwords" option is
important to have.
I think it might also b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #11 from Jonathan Druart ---
In my opinion sysprefs should not drive UI's preferences. We are using local
storage for several features already so that should not be a problem.
See bug 5697 for instance, that have been pu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #10 from Thibaud Guillot ---
I reproduced the same behavior than OPAC side and from the discussion it
coincided with the integration of a system preference. If we put this parameter
in the localstorage could problems aris
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Thibaud Guillot changed:
What|Removed |Added
Blocks|20396 |
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Thibaud Guillot changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #8 from Thibaud Guillot ---
Created attachment 128359
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128359&action=edit
Added a syspref to highlight or not highlight search terms in results on the
staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Thibaud Guillot changed:
What|Removed |Added
CC||thibaud.guil...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Owen Leonard changed:
What|Removed |Added
CC||pasi.kalli...@koha-suomi.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #6 from Elaine Bradtke ---
(In reply to Katrin Fischer from comment #5)
We deactivated it in the OPAC. Shortly after we activated it.
> You can already deactivate it on the OPAC: HighlightOwnItemsOnOPAC
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
--- Comment #5 from Katrin Fischer ---
(In reply to Elaine Bradtke from comment #4)
> +1 we've actually had comments / complaints from users who don't like it.
> Would love to switch it off or remove it completely.
> (In reply to An
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Elaine Bradtke changed:
What|Removed |Added
CC||e...@efdss.org
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Andreas Hedström Mace changed:
What|Removed |Added
CC||andreas.hedstrom.mac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolin.som...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20398
Gaetan Boisson changed:
What|Removed |Added
Summary|Remove search result|Add a system preference to
55 matches
Mail list logo
