[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00,21.05.04

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Kyle M Hall changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.04

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #36 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #35

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #34 from Nick Clemens --- Created attachment 124330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124330=edit Bug 20529: Remove other occurrences of decodeURIComponent from browser.js Signed-off-by:

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens changed: What|Removed |Added Attachment #122736|0 |1 is obsolete|

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart changed: What|Removed |Added CC||ha...@orex.es ---

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff ---

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #30 from Victor Grousset/tuxayo --- > Can someone stress the feature with this patch? What do you mean? Is the patch name too vague? The first 3 steps of the test plan show the issue. -- You are receiving this mail

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Signed Off -- You are

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #28 from Jonathan Druart --- Can someone stress the feature with this patch? IIRC weird bugs usually happens "on the edge" of the pagination. Like search with your favourite weird terms and click the last records from

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #27 from Jonathan Druart --- Created attachment 122751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122751=edit Bug 20529: Remove other occurrences of decodeURIComponent from browser.js -- You are

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #26 from Jonathan Druart --- (In reply to Fridolin Somers from comment #24) > I totally reproduce bug and patch fixes it. > > We already see : > decodeURIComponent(current_search.limit) > It is logical to use : >

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens changed: What|Removed |Added Attachment #122626|0 |1 is obsolete|

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #24 from Fridolin Somers --- I totally reproduce bug and patch fixes it. We already see : decodeURIComponent(current_search.limit) It is logical to use : decodeURIComponent(current_search.query) -- You are

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Fridolin Somers changed: What|Removed |Added Attachment #120816|0 |1 is obsolete|

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Fridolin Somers changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Marjorie Barry-Vila changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo changed: What|Removed |Added Status|Patch doesn't apply |Failed QA ---

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #74610|0 |1 is

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Patch doesn't apply --

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #20 from Katrin Fischer --- The patch needs a major rebase, since we since moved some things around like changing the way we do the translations on this script. But the problem remains. I tested with: a "test" The link

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #19 from Fridolin Somers --- What does this bug need ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #18 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #15) > I'd say we could go without test plan, if the changes make sense and work in > that case it must work for the "special" cases. Ok,

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Fridolin SOMERS changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo changed: What|Removed |Added Status|In Discussion |Needs Signoff --

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #15 from Jonathan Druart --- I'd say we could go without test plan, if the changes make sense and work in that case it must work for the "special" cases. -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #14 from Victor Grousset/tuxayo --- Unfortunately I'm out of time to expand much more [1] the scope of this issue. 1. Is the fix simple enough to be applied without having a test plan? 2. Is it okay to keep the scope as

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #13 from Jonathan Druart --- Reading the code I'd say these 2 switches prevent wrong calls to browseRecords (like you call it with movement != 1 and -1) -- You are receiving

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #10 from Victor Grousset/tuxayo --- Because I wasn't able to trigger the code of the other occurrences ^^"

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens changed: What|Removed |Added Patch complexity|---

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens changed: What|Removed |Added Attachment #74554|0 |1

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #7 from Victor Grousset/tuxayo --- Thanks Séverine for testing with ES! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Séverine Queune changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #5 from sandbo...@biblibre.com --- Created attachment 74554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74554=edit Bug 20529: Fix "Return to results" link broken by a double

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 sandbo...@biblibre.com changed: What|Removed |Added Attachment #74553|0

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #4 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 sandbo...@biblibre.com changed: What|Removed |Added Attachment #74251|0

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 sandbo...@biblibre.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #3 from sandbo...@biblibre.com --- Created attachment 74553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74553=edit Bug 20529: Fix "Return to results" link broken by a double

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 --- Comment #1 from Victor Grousset/tuxayo --- Created attachment 74251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74251=edit Bug 20529: Fix "Return to results" link broken by a

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo changed: What|Removed |Added Severity|enhancement

[Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Victor Grousset/tuxayo changed: What|Removed |Added