[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Fridolin SOMERS changed: What|Removed |Added Blocks||15261 Referenced Bugs:

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Fridolin SOMERS changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable -- You

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart changed: What|Removed |Added Attachment #75367|0

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #31 from Marcel de Rooy --- With previous comments in mind, balance goes to Passed QA for this patch set. Added a simple db rev (we should imo). @RM: If you want to refine, please do. -- You

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #29 from Marcel de Rooy --- Created attachment 75366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75366=edit Bug 20724: (QA follow-up) Remove two obsolete comment lines No

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #30 from Marcel de Rooy --- Created attachment 75367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75367=edit Bug 20724: (QA follow-up) Add a simple db revision We should

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy changed: What|Removed |Added Attachment #75307|0

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy changed: What|Removed |Added Attachment #75325|0

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy changed: What|Removed |Added Attachment #75308|0

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #25 from Marcel de Rooy --- This might affect C4/ILSDI/Services.pm => One of the calls includes an itemnumber. Note that the code did not contain a reference to ReservesNeedsReturns.

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #24 from Marcel de Rooy --- for ( my $i = 0 ; $i < $holds_to_place_count ; $i++ ) { AddReserve( $branch, $borrower->{'borrowernumber'}, $biblionumber,

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #22 from Katrin Fischer --- I am not sure how big of a problem it is, but it probably depends on how long a library allows for items to be picked up. -- You are receiving this mail because:

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #21 from Victor Grousset/tuxayo --- Posting the error here so someone searching for it will find this bug. Date::Calc::Date_to_Days(): not a valid date at

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #20 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #18) > If it's just a little database update I'd put it here I think. +1 (In reply to Katrin Fischer from

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #19 from Katrin Fischer --- Hm, might be a little more complicated if you want the absolute correct date (with/without holidays). So we'd need to do what the code should have done? -- You are

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #18 from Katrin Fischer --- If it's just a little database update I'd put it here I think. I can sign off this afternoon if noone else is faster. -- You are receiving this mail because: You

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #17 from Victor Grousset/tuxayo --- Same bug or followup? So the patch will be quickly released to at least avoid generating corrupted data. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #15 from Victor Grousset/tuxayo --- == Going further: existing data == This bug creates corrupted data that will still break the page. (waiting reserves with a NULL expirationdate) What do

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #75309|0

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #75221|0

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #75223|0

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #75222|0

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #9 from Jonathan Druart --- Created attachment 75223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75223=edit Bug 20724: Add tests for ReservesNeedReturns --

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart changed: What|Removed |Added Keywords|

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart changed: What|Removed |Added

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #8 from Jonathan Druart --- Created attachment 75222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75222=edit Bug 20724: Move the ReservesNeedReturns logic to

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart changed: What|Removed |Added Attachment #75211|0

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #6 from Kyle M Hall --- Created attachment 75219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75219=edit Bug 20724 [Alternate]: Try to fix ReservesNeedReturns wrong

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #4 from Jonathan Druart --- Created attachment 75211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75211=edit Bug 20724: Try to fix ReservesNeedReturns wrong

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #2) > I do not think it's link to ReservesNeedReturns, it happens when no > expiration date is selected.

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 --- Comment #2 from Jonathan Druart --- I do not think it's link to ReservesNeedReturns, it happens when no expiration date is selected. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724 Victor Grousset/tuxayo changed: What|Removed |Added