[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What|Removed |Added Version(s)||19.05.00 released

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master ---

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens changed: What|Removed |Added Text to go in the|WARNING: This patch |WARNING: This patch

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What|Removed |Added Attachment #87675|0 |1 is obsolete|

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What|Removed |Added Keywords||Manual,

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What|Removed |Added Text to go in the||WARNING: This patch

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What|Removed |Added Attachment #87674|0 |1 is obsolete|

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #21 from Martin Renvoize --- Created attachment 88701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88701=edit Bug 20837: (QA follow-up) adding missing filter to make QA tool happy Signed-off-by: Liz

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What|Removed |Added Attachment #87673|0 |1 is obsolete|

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #18 from Martin Renvoize --- ooh.. also you forgot your signoff lines.. must have been a late night for you aye... so glad it's not just me who does that -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #17 from Martin Renvoize --- Haha.. thanks for the follow-up Liz.. but you fell into the whole I nearly always also fall into 'follow-up' vs 'Follow-up'... QA script complained.. I've fixed it ;) -- You are receiving

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #16 from Liz Rea --- Created attachment 87675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87675=edit Bug 20837: (QA Follow-up) adding missing filter to make QA tool happy -- You are receiving this

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #15 from Liz Rea --- Created attachment 87674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87674=edit Bug 20837: Use ReservesControlBranch to determine holdability of items To test: 1 - Set a

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Liz Rea changed: What|Removed |Added Attachment #87409|0 |1 is obsolete|

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #13 from Liz Rea --- I have questions about how this could affect current users and might cause some nasty surprises for existing users, but the behaviour is correct now based on the tooltips so new libraries might find

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens changed: What|Removed |Added Attachment #87021|0 |1 is obsolete|

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #12 from Nick Clemens --- Created attachment 87410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87410=edit Bug 20837: Use ReservesControlBranch to determine holdability of items To test: 1 - Set a

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #10 from

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #9 from Nick Clemens --- Created attachment 87025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87025=edit Bug 20837: (follow-up) Rename variables -- You are receiving this mail because: You are

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #8 from Nick Clemens --- Created attachment 87024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87024=edit Bug 20837: Alter IsAvailableForItemForItemLevelRequest to use ReservesControlBranch Also use

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens changed: What|Removed |Added Attachment #75685|0 |1 is obsolete|

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #7 from Nick Clemens --- Created attachment 87023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87023=edit Bug 20837: Unit tests -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens changed: What|Removed |Added Attachment #75684|0 |1 is obsolete|

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens changed: What|Removed |Added CC||jza...@bywatersolutions.com

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #3 from Jonathan Druart --- It makes sense to me yes. Note that there is another occurrence of C4::Circulation::_GetCircControlBranch in IsAvailableForItemLevelRequest We should also rename the variable name

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #2 from Nick Clemens --- Created attachment 75685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75685=edit Bug 20837: Use ReservesControlBranch to determine holdability of items To test: 1 - Set a

[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #1 from Nick Clemens --- Created attachment 75684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75684=edit Bug 20837: Unit tests To test: prove -v t/db_dependent/Holds.t -- You are receiving this