[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Fridolin SOMERS changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Bug 20941 depends on bug 18591, which changed state. Bug 18591 Summary: Allow an arbitrary number of comments on ILLs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 What|Removed

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec changed: What|Removed |Added QA Contact||josef.mora...@gmail.com --

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #42 from Josef Moravec --- Created attachment 81691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81691=edit Bug 20941: (QA follow-up) Fix return value of get_type, make templates more consistant

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #43 from Josef Moravec --- Created attachment 81692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81692=edit Bug 20941: (follow-up) Wrap N/A strings in All N/A strings in ILL templates wrapped in

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #44 from Josef Moravec --- Created attachment 81693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81693=edit Bug 20941: (follow-up) Update N/A handling Modify the conditional display of N/A in

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #45 from Josef Moravec --- Created attachment 81694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81694=edit Bug 20941: (follow-up) Switch 'media' -> 'types' Clearing up the inconsistency mentioned

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #41 from Josef Moravec --- Created attachment 81690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81690=edit Bug 20941: (follow-up) Carry out comment #4 advice - Switch getType -> get_type - get_type

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #40 from Josef Moravec --- Created attachment 81689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81689=edit Bug 20941: Add unit tests Signed-off-by: Josef Moravec -- You are receiving this mail

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec changed: What|Removed |Added Attachment #80127|0 |1 is obsolete|

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Paul Thornton changed: What|Removed |Added CC||paul.thorn...@educampus.ie

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood changed: What|Removed |Added Blocks|18589 | Referenced Bugs:

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood changed: What|Removed |Added Blocks||20548 Referenced Bugs:

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de| -- You are receiving

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #37 from Andrew Isherwood --- Responses to comment #35: >This seems to be a spelling mismatch. The type for new requests saves with the >first letter being lower case (article) while the the pull downs look for

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #36 from Andrew Isherwood --- Created attachment 80212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80212=edit Bug 20941: (follow-up) Switch 'media' -> 'types' Clearing up the inconsistency

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #35

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #34 from Katrin Fischer --- Created attachment 80132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80132=edit Bug 20941: (follow-up) Update N/A handling Modify the conditional display of N/A in

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #33 from Katrin Fischer --- Created attachment 80131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80131=edit Bug 20941: (follow-up) Wrap N/A strings in All N/A strings in ILL templates wrapped in

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #31 from Katrin Fischer --- Created attachment 80129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80129=edit Bug 20941: (follow-up) Carry out comment #4 advice - Switch getType -> get_type -

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #30 from Katrin Fischer --- Created attachment 80128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80128=edit Bug 20941: Add unit tests Signed-off-by: Josef Moravec -- You are receiving this mail

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #32 from Katrin Fischer --- Created attachment 80130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80130=edit Bug 20941: (QA follow-up) Fix return value of get_type, make templates more consistant

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer changed: What|Removed |Added Attachment #80112|0 |1 is obsolete|

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer changed: What|Removed |Added Status|BLOCKED |Signed Off QA

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood changed: What|Removed |Added Attachment #7|0 |1 is obsolete|

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer changed: What|Removed |Added Depends on||18591 Referenced Bugs:

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood changed: What|Removed |Added Attachment #79921|0 |1 is obsolete|

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood changed: What|Removed |Added Attachment #79945|0 |1 is obsolete|

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood changed: What|Removed |Added Attachment #79920|0 |1 is obsolete|

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood changed: What|Removed |Added Attachment #79919|0 |1 is obsolete|

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood changed: What|Removed |Added Attachment #79918|0 |1 is obsolete|

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #22 from Andrew Isherwood --- Created attachment 7 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7=edit Bug 20941: (follow-up) Update N/A handling Modify the conditional display of N/A in

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #21 from Andrew Isherwood --- Thanks very much for that Katrin. I'll create a follow up for these today. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #20 from Josef Moravec --- (In reply to Katrin Fischer from comment #17) > It would be good to test that this construct actually gets picked up. I am > not sure if our script look for HTML inside the TT constructs... I

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #19 from Katrin Fischer --- [% request.cost | html %] of course (update your QA script!) -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #18 from Katrin Fischer --- ... also... should the html filter not escape that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #16 from Andrew Isherwood --- Hi Josef, I've now wrapped all N/A in tags, so this should be correct and consistent now. Many thanks. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #15 from Andrew Isherwood --- Created attachment 79945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79945=edit Bug 20941: (follow-up) Wrap N/A strings in All N/A strings in ILL templates wrapped in

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec changed: What|Removed |Added Status|Passed QA |BLOCKED --- Comment #14

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #13 from Andrew Isherwood --- Thanks for that Josef, much better! The inclusion of the span was based on advice I've been given in the past that wrapping strings with a span aids with translation, though I'm not clear

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec changed: What|Removed |Added Attachment #79577|0 |1 is obsolete|

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #11 from Josef Moravec --- Created attachment 79921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79921=edit Bug 20941: (QA follow-up) Fix return value of get_type, make templates more consistant

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #9 from Josef Moravec --- Created attachment 79919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79919=edit Bug 20941: Add unit tests Signed-off-by: Josef Moravec -- You are receiving this mail

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #10 from Josef Moravec --- Created attachment 79920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79920=edit Bug 20941: (follow-up) Carry out comment #4 advice - Switch getType -> get_type - get_type

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #12

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #7 from Andrew Isherwood --- s/ph$/f/ (sorry!) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #6 from Andrew Isherwood --- Thanks for the review Joseph, all great points, much appreciated. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #5 from Andrew Isherwood --- Created attachment 79865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79865=edit Bug 20941: (follow-up) Carry out comment #4 advice - Switch getType -> get_type -

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA QA

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #4 from Josef Moravec --- Comment on attachment 79577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79577 Bug 20941: Add Illrequest->getType method Review of attachment 79577: -->

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #3 from Andrew Isherwood --- Created attachment 79825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79825=edit Bug 20941: Add unit tests -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #76052|0 |1 is

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 PTFS Europe Sandboxes changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood changed: What|Removed |Added Blocks||18589 Referenced Bugs:

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Bug 20941 depends on bug 7317, which changed state. Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 What|Removed

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood changed: What|Removed |Added Depends on||7317 Referenced Bugs:

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #1 from Andrew Isherwood --- Created attachment 76052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76052=edit Bug 20941: Add Illrequest->getType method This patch adds a method to the Illrequest

[Koha-bugs] [Bug 20941] Displaying requests does not display request material type

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood changed: What|Removed |Added Status|NEW |ASSIGNED