https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Martin Renvoize changed:
What|Removed |Added
Blocks||21835
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Martin Renvoize changed:
What|Removed |Added
Resolution|--- |FIXED
Status|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #77 from Martin Renvoize ---
Odd.. I didn't get that warning at all when I tested the patch.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #76 from Nick Clemens ---
Last two patches pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #75 from Jonathan Druart
---
Created attachment 81998
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81998&action=edit
Bug 20996: Remove warning 'Un-mocked method'
t/db_dependent/api/v1/illrequests.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Jonathan Druart changed:
What|Removed |Added
Attachment #81996|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #73 from Jonathan Druart
---
I get a warning with the last patch:
t/db_dependent/api/v1/illrequests.t .. Un-mocked method 'status_graph()' called
at /home/vagrant/kohaclone/Koha/Illrequest.pm line 439.
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Martin Renvoize changed:
What|Removed |Added
Attachment #81994|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #71 from Martin Renvoize ---
Added a follow-up for the RM that should fix the last remaining failing test.
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #70 from Martin Renvoize ---
Created attachment 81994
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81994&action=edit
Bug 20996: (RM follow-up) Fix the api tests
--
You are receiving this mail becaus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #69 from Nick Clemens ---
Awesome work all!
Pushed to master for 18.11(In reply to Tomás Cohen Arazi from comment #68)
> Created attachment 81967 [details] [review]
> Bug 20996: (follow-up) Fix test
>
> - Fixes the t/db
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #81928|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #67 from Josef Moravec ---
(In reply to Jonathan Druart from comment #63)
> t/db_dependent/Illrequest/Config.t is failing.
>
> New code added to Koha/Illrequest/Config.pm but no tests?
I added a follow-up patch with tes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #66 from Josef Moravec ---
Created attachment 81928
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81928&action=edit
Bug 20996: (follow-up) Fix test
- Fixes the t/db_dependent/Illrequest/Config.t
- Add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Martin Renvoize changed:
What|Removed |Added
Attachment #81908|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Martin Renvoize changed:
What|Removed |Added
Attachment #81909|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #65 from Martin Renvoize ---
Created attachment 81909
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81909&action=edit
Bug 20966: (follow-up) Add template variable filter; Fix table export
This patch m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #64 from Martin Renvoize ---
Created attachment 81908
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81908&action=edit
Bug 20966: Add column configuration to table of orders in a basket
This patch adds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Martin Renvoize changed:
What|Removed |Added
Depends on|7317|
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Josef Moravec changed:
What|Removed |Added
QA Contact||josef.mora...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #58 from Josef Moravec ---
Created attachment 81758
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81758&action=edit
Bug 20996: (follow-up) Add to conf tpl
Since we now require the block, we should a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #60 from Josef Moravec ---
Created attachment 81760
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81760&action=edit
Bug 20996: (follow-up) Fix merge problems
Merge conflicts resolved
Signed-off-by: J
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Josef Moravec changed:
What|Removed |Added
Attachment #81747|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #57 from Josef Moravec ---
Created attachment 81757
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81757&action=edit
Bug 20996: Further enhance performance
We were immediately unblessing all request ob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #56 from Josef Moravec ---
Created attachment 81756
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81756&action=edit
Bug 20996: Fix unit tests
- Remove unit tests relating to TO_JSON
- Add tests for ne
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #61 from Josef Moravec ---
Created attachment 81761
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81761&action=edit
Bug 20996: (QA follow-up) Fix pod
Signed-off-by: Josef Moravec
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #59 from Josef Moravec ---
Created attachment 81759
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81759&action=edit
Bug 20996: (follow-up) Fix column name expectation
This bug changes how request meta
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #54 from Andrew Isherwood ---
Rebased, fixed merge problems (including the "comments" embed in the API
response) and added Josef's POD fix.
Ready for QA again
--
You are receiving this mail because:
You are watching al
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #79592|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #52 from Andrew Isherwood ---
Created attachment 81752
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81752&action=edit
Bug 20996: (follow-up) Fix merge problems
Merge conflicts resolved
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #53 from Andrew Isherwood ---
Created attachment 81753
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81753&action=edit
Bug 20996: (QA follow-up) Fix pod
--
You are receiving this mail because:
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #79590|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #79591|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #79589|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #79588|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #79592|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #79588|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #79590|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #79589|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #79591|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #81720|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #81716|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #81719|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #81717|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #81718|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Attachment #81715|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #40 from Josef Moravec ---
Andrew is going to add comments to embed as it was done in bug 18591
--
You are receiving this mail because:
You are watching all bug changes.
___
K
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #39 from Josef Moravec ---
Rebased on master and add small follow-up
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #38 from Josef Moravec ---
Created attachment 81720
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81720&action=edit
Bug 20996: (QA follow-up) Fix pod
--
You are receiving this mail because:
You are w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #35 from Josef Moravec ---
Created attachment 81717
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81717&action=edit
Bug 20996: Further enhance performance
We were immediately unblessing all request ob
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #37 from Josef Moravec ---
Created attachment 81719
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81719&action=edit
Bug 20996: (follow-up) Fix column name expectation
This bug changes how request meta
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #34 from Josef Moravec ---
Created attachment 81716
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81716&action=edit
Bug 20996: Fix unit tests
- Remove unit tests relating to TO_JSON
- Add tests for ne
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #36 from Josef Moravec ---
Created attachment 81718
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81718&action=edit
Bug 20996: (follow-up) Add to conf tpl
Since we now require the block, we should a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Josef Moravec changed:
What|Removed |Added
Attachment #79588|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Bug 20996 depends on bug 20548, which changed state.
Bug 20548 Summary: Remove copyright clearance workflow from staff created ILL
requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Blocks|18589 |
Referenced Bugs:
http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Depends on||20548
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Text to go in the||This patch makes the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Blocks||21079
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
Attachment #79586|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
Attachment #79587|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
Attachment #79585|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
Attachment #79584|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
Attachment #79583|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
Attachment #79379|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
Attachment #76688|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
Attachment #76705|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
Attachment #79576|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
Attachment #76687|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #22 from Andrew Isherwood ---
Created attachment 79576
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79576&action=edit
Bug 20996: (follow-up) Fix column name expectation
This bug changes how request m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #21 from Andrew Isherwood ---
OK, I know what it is. In the FreeForm backend's metadata method (and, I
presume, your backend's metadata method), there is this line:
https://github.com/PTFS-Europe/koha-ill-freeform/blob/m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #20 from Andrew Isherwood ---
No, it's not backend dependent. I looked into it yesterday, prior to these
patches "title" and "author" metadata were returned by the API as
"metadata_Title" & "metadata_Author", which is wha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #19 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Blocks||18589
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #17 from Andrew Isherwood ---
Oooh, good investigating, I completely failed to find any difference in
responses. I clearly didn't have sufficiently well populated requests! What
you've found sounds promising, I'll do some
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #16 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #15 from Andrew Isherwood ---
Hi Magnus. I can't account for the weight increase, I've not been able to
replicate it. You've not also got bug 21079 applied have you? That runs a
database update that creates additional ill
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #14 from Andrew Isherwood ---
Created attachment 79379
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79379&action=edit
Bug 20996: (follow-up) Add to conf tpl
Since we now require the block, we shoul
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #13 from Andrew Isherwood ---
It's not related to this bug, it's due to an item not having an author, I've
seen it before. I'll create a bug if I've not already created one. Thanks for
mentioning it!
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #12 from Magnus Enger ---
Also, with the patch applied, when I try to view
/cgi-bin/koha/ill/ill-requests.pl I get two JS popup warnings:
DataTables warning: table id=ill-requests - Requested unknown parameter
'metadata
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #11 from Andrew Isherwood ---
Interesting, I'd not noticed the weight increase. I'll investigate!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #10 from Magnus Enger ---
Some observations from a DB with 359 illrequests and 34,485
illrequestattributes. Measurements of the standard API call to
/api/v1/illrequests?embed=metadata,patron,capabilities,library:
Without
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #9 from Andrew Isherwood ---
Excellent point, thanks Magnus. I'll create a patch to add these
--
You are receiving this mail because:
You are watching all bug changes.
___
Koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Magnus Enger changed:
What|Removed |Added
CC||mag...@libriotech.no
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Andrew Isherwood changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #6 from Andrew Isherwood ---
Created attachment 77100
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77100&action=edit
Script for creating large numbers of ILL requests, for performance testing
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Bug 20996 depends on bug 7317, which changed state.
Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #5 from Andrew Isherwood ---
Created attachment 76705
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76705&action=edit
Bug 20996: Further enhance performance
We were immediately unblessing all request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #3 from Andrew Isherwood ---
Created attachment 76687
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76687&action=edit
Bug 20996: Remove prefix use of borrower category
This patch removes the potential
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #4 from Andrew Isherwood ---
Created attachment 76688
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76688&action=edit
Bug 20996: Fix unit tests
- Remove unit tests relating to TO_JSON
- Add tests for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
--- Comment #2 from Andrew Isherwood ---
Hi Benjamin
I'm not aware of anywhere where we query that table on type or value, it's only
ever the illrequest_id we query via the join. So I'm not sure of the value of
adding these indexes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20996
Benjamin Rokseth changed:
What|Removed |Added
CC||benjamin.rokseth@deichman
1 - 100 of 102 matches
Mail list logo