https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #12 from David Cook ---
(In reply to Joonas Kylmälä from comment #2)
> In koha-suomi fork we use start-stop-daemon to send the HUP signal, that's
> probably the preferable way since koha-plack uses start-stop-daemon alrea
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #13 from David Cook ---
(In reply to Jonathan Druart from comment #11)
> This bug report is assigned, can we expect a patch soon?
It should be a simple patch. I feel like I'd probably be more useful in test/QA
for this o
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Katrin Fischer changed:
What|Removed |Added
Summary|add plack reload|Add Plack reload
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Jonathan Druart changed:
What|Removed |Added
Assignee|tomasco...@gmail.com|koha-b...@lists.koha-commu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
David Cook changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #14 from David Cook ---
Created attachment 139011
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139011&action=edit
Bug 21366: Add koha-plack --reload to gracefully restart Plack/Starman
This patch add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
David Cook changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #15 from David Cook ---
Ok patch prepared. Looking at Fridolin and Joonas for sign off and QA!
--
You are receiving this mail because:
You are watching all bug changes.
___
Ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Jonathan Druart changed:
What|Removed |Added
Attachment #139011|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #17 from Jonathan Druart ---
Note that the help is missing the new option.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #18 from David Cook ---
(In reply to Jonathan Druart from comment #17)
> Note that the help is missing the new option.
Believe it or not, that thought crossed my mind as I was falling asleep last
night haha. I'll look at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #19 from David Cook ---
Created attachment 139035
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139035&action=edit
Bug 21366: Add --reload option to koha-plack help/manual
--
You are receiving this m
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #20 from David Cook ---
(Side note, I've opened bug 31348 to handle graceful stopping of Starman/Plack
as well.)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Victor Grousset/tuxayo changed:
What|Removed |Added
Patch complexity|--- |Small patch
--
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #139035|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #24 from Victor Grousset/tuxayo ---
(In reply to Marcel de Rooy from comment #23)
> If you enable --preload-app option, however, the code will be only loaded in
> the startup process and will not pick up the code changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #25 from David Cook ---
(In reply to Marcel de Rooy from comment #23)
> If you enable --preload-app option, however, the code will be only loaded in
> the startup process and will not pick up the code changes you made. If
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #26 from Marcel de Rooy ---
(In reply to Victor Grousset/tuxayo from comment #24)
> (In reply to Marcel de Rooy from comment #23)
> What do you mean? The patch doesn't use --preload-app.
I did not say that. Please read th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #28 from David Cook ---
(In reply to Marcel de Rooy from comment #27)
> > I chose the about.pl test somewhat arbitrarily because koha-testing-docker
> > is such a small database. In production, where you really see this b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #29 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #27)
> > seconds. Using koha-plack --reload will wait for that long search request to
> > complete, and then it will restart that worker.
koha-plack do
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Marcel de Rooy changed:
What|Removed |Added
Attachment #139015|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Marcel de Rooy changed:
What|Removed |Added
Attachment #139565|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #32 from Tomás Cohen Arazi ---
Pushed to master for 22.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #33 from Victor Grousset/tuxayo ---
(In reply to Marcel de Rooy from comment #26)
> (In reply to Victor Grousset/tuxayo from comment #24)
> > (In reply to Marcel de Rooy from comment #23)
> > What do you mean? The patch d
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #4 from David Cook ---
(In reply to Joonas Kylmälä from comment #2)
> In koha-suomi fork we use start-stop-daemon to send the HUP signal, that's
> probably the preferable way since koha-plack uses start-stop-daemon alread
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #5 from David Cook ---
(In reply to Fridolin Somers from comment #1)
> To trigger this reload, juste run :
>
> /bin/kill -HUP $MASTER_PID
>
> MASTER_PID beeing the pid of the starman master process, can be fetched in
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #6 from David Cook ---
I don't know if we could use it with Koha package installs, as I think the
koha-common service is stopped and started, although I'm not 100% sure of that
mechanism at this point...
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #7 from David Cook ---
Question:
- Do we want "koha-plack --reload" or do we want "koha-plack --graceful" or
both?
I think Apache treats reload/graceful/force-reload as the same.
--
You are receiving this mail because
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
David Cook changed:
What|Removed |Added
Depends on||30684
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Michal Denar changed:
What|Removed |Added
CC||blac...@gmail.com
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Andreas Jonsson changed:
What|Removed |Added
CC||andreas.jons...@kreablo.se
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #9 from David Cook ---
(In reply to Andreas Jonsson from comment #8)
> Would it be too risky to send a HUP-signal to the plack process
> automatically when a plugin is reuploaded?
>
> I think that this would be very nice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
David Cook changed:
What|Removed |Added
Depends on|30684 |
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #10 from David Cook ---
(In reply to Andreas Jonsson from comment #8)
> Would it be too risky to send a HUP-signal to the plack process
> automatically when a plugin is reuploaded?
>
> I think that this would be very nic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Katrin Fischer changed:
What|Removed |Added
Keywords||release-notes-needed
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Fridolin SOMERS changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
--- Comment #1 from Fridolin SOMERS ---
To trigger this reload, juste run :
/bin/kill -HUP $MASTER_PID
MASTER_PID beeing the pid of the starman master process, can be fetched in pid
file.
Source :
https://metacpan.org/pod/distribu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
Joonas Kylmälä changed:
What|Removed |Added
CC||joonas.kylm...@helsinki.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- C
49 matches
Mail list logo
