https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Katrin Fischer changed:
What|Removed |Added
Blocks||25596
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
Target Milestone|19.05 |---
Kyle M Hall changed:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
Resolution|--- |FIXED
Status|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Bug 21727 depends on bug 21980, which changed state.
Bug 21980 Summary: Add some new Exceptions for Koha::Account methods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #32 from Nick Clemens ---
(In reply to Tomás Cohen Arazi from comment #31)
> Created attachment 83818 [details] [review]
> Bug 21727: (QA follow-up) Fix POD encoding
Follow-up pushed to master for 19.05
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #31 from Tomás Cohen Arazi ---
Created attachment 83818
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83818&action=edit
Bug 21727: (QA follow-up) Fix POD encoding
--
You are receiving this mail becau
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
Target Milestone|--- |19.05
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #29 from Josef Moravec ---
Great catch
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #28 from Josef Moravec ---
Created attachment 83122
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83122&action=edit
Bug 21727: Add handling for cases requireing patron refunds
As it is possible to par
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Josef Moravec changed:
What|Removed |Added
Attachment #83117|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #26 from Tomás Cohen Arazi ---
Created attachment 83118
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83118&action=edit
Bug 21727: Unit tests for the refund case
This patch introduces tests for the be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #83101|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #24 from Martin Renvoize ---
Marking as Failed QA.. Tomas has identified a case where the adjust may lead to
a situation where the library owes the patron a refund and we agree we should
never allow the 'amountoutstanding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Failed QA
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #23 from Martin Renvoize ---
Created attachment 83101
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83101&action=edit
Bug 21727: Add handling for cases requireing patron refunds
As it is possible to p
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #22 from Josef Moravec ---
Created attachment 83098
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83098&action=edit
Bug 21727: Add clarifications to the POD of adjust
Sponsored-by: PTFS Europe
Signed-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Josef Moravec changed:
What|Removed |Added
Attachment #83088|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #21 from Josef Moravec ---
Created attachment 83097
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83097&action=edit
Bug 21727: (QA follow-up) Test lastincrement changes
'adjust' changes the 'lastincre
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #20 from Josef Moravec ---
Created attachment 83096
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83096&action=edit
Bug 21727: Add ->adjust to Koha::Account::Line
This patch introduces a high-level me
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Josef Moravec changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
Attachment #83056|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
Attachment #83058|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
Attachment #83055|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
Attachment #83054|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #14 from Martin Renvoize ---
Created attachment 83058
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83058&action=edit
Bug 21727: Add clarifications to the POD of adjust
Signed-off-by: Martin Renvoize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #13 from Tomás Cohen Arazi ---
(In reply to Martin Renvoize from comment #12)
> Also to note.. the only use case that exists so far for this method is the
> adjustment of the non-definitive 'FU' type accountline which is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #12 from Martin Renvoize ---
Also to note.. the only use case that exists so far for this method is the
adjustment of the non-definitive 'FU' type accountline which is a 'still
incrementing' charge.
I think the majorit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #11 from Martin Renvoize ---
Awesome.. thanks for testing (and enhancing the test coverage) Tomas.
For Josef's benefit I've also updated the dependancies.. splitting out the
exception class additions into their own bug s
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Tomás Cohen Arazi changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-eur
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #82777|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #10 from Tomás Cohen Arazi ---
Created attachment 83056
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83056&action=edit
Bug 21727: (QA follow-up) Test lastincrement changes
'adjust' changes the 'lasti
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #8 from Tomás Cohen Arazi ---
Created attachment 83054
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83054&action=edit
Bug 21727: Add tests for Koha::Account::Line->adjust
Signed-off-by: Tomas Cohen A
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #82778|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #9 from Tomás Cohen Arazi ---
Created attachment 83055
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83055&action=edit
Bug 21727: Add ->adjust to Koha::Account::Line
This patch introduces a high-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
Depends on|21002 |21980
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #7 from Martin Renvoize ---
Thanks Tomas, that's it.. sorry I missed the dependency chain in the first
place.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Tomás Cohen Arazi changed:
What|Removed |Added
Depends on||21002
--- Comment #6 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #5 from Josef Moravec ---
When running test I got this:
Can't locate object method "throw" via package
"Koha::Exceptions::Account::UnrecognisedType" (perhaps you forgot to load
"Koha::Exceptions::Account::UnrecognisedTy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
Attachment #81879|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #3 from Martin Renvoize ---
Created attachment 82777
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82777&action=edit
Bug 21727: Add tests for Koha::Account::Line->adjust
--
You are receiving this mai
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Tomás Cohen Arazi changed:
What|Removed |Added
See Also||https://bugs.koha-commun
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #2 from Martin Renvoize ---
Proof Of Concept... tests to come
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
K
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
--- Comment #1 from Martin Renvoize ---
Created attachment 81879
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81879&action=edit
Bug 21727: Add ->adjust to Koha::Account::Line
--
You are receiving this mail beca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
Blocks|21748 |
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727
Martin Renvoize changed:
What|Removed |Added
Summary|Add |Add
|Ko
52 matches
Mail list logo