[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #51 from Fridolin Somers --- Oooo test suite broken ^^ I've created 2 new bug reports. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Fridolin Somers changed: What|Removed |Added Blocks||29976 Referenced Bugs:

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Fridolin Somers changed: What|Removed |Added Blocks||29975 Referenced Bugs:

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #50 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #49 from Fridolin Somers --- This change in behavior needs a nice release note :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs maili

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Small patch Key

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #47

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What|Removed |Added Attachment #128761|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What|Removed |Added Attachment #127880|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What|Removed |Added Attachment #127879|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What|Removed |Added Attachment #127878|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize changed: What|Removed |Added Attachment #127877|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #41 from Jonathan Druart --- Created attachment 128761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128761&action=edit Bug 21729: Add tests -- You are receiving this mail because: You are watching a

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are re

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #40 from Florian --- Here is the test plan I followed, from the 21932. To test flaws: 1) Place a first available hold for the next available item, and set the hold expires date to a short time, like tomorrow. 2) Make su

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #38 from Florian --- Apologies for the mess I caused, hopefully all should be good. Sidenote though : I was able to run the full test plan without the patches on master, and it worked as intented; so in essence I saw no

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian changed: What|Removed |Added Attachment #127800|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian changed: What|Removed |Added Attachment #127799|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian changed: What|Removed |Added Attachment #127798|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian changed: What|Removed |Added Attachment #127797|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What|Removed |Added Attachment #127868|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What|Removed |Added Attachment #127868|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What|Removed |Added Attachment #127868|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What|Removed |Added Attachment #127867|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #33 from Jonathan Druart --- Florian, to obsolete patches you need to click "Details", "edit details", tick "obsolete", then submit. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #32 from Florian --- Created attachment 127870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127870&action=edit Bug 29270: start_for is actually date_to The attribute has been renamed in the meanwhile

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #31 from Florian --- Created attachment 127869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127869&action=edit Bug 29477: Flatpickr - default to 23:59 for the time part It was defaulting to 12:00 whi

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #30 from Florian --- Created attachment 127868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127868&action=edit Bug 29270: Expiration date must be in future Signed-off-by: Jonathan Druart -- You ar

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #29 from Florian --- Created attachment 127867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127867&action=edit Bug 29469: (bug 17600 follow-up) Fix tag approval/rejection from staff Usage: POSIX::exi

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #126258|0 |1 is obsolete

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #126203|0 |1 is obsolete

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #126161|0 |1 is obsolete

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #126160|0 |1 is obsolete

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You a

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #24 from Andrew Fuerste-Henry --- To test: APPLY PATCH 1 - create a hold with an expiration date sooner than the period defined by your MaxPickupDelay 2 - check your item in, triggering the hold, confirm the expiration da

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #23 from Jonathan Druart --- (In reply to Florian from comment #22) > Would like to sign off, should I use the test plan in bug 21932 ? Yes, that should work. -- You are receiving this mail because: You are watching al

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian changed: What|Removed |Added CC||florian.bontemps@biblibre.c

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #21 from Jonathan Druart --- Created attachment 126258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126258&action=edit Bug 21729: Simplify non-existent expiration date No change in behaviour expected

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What|Removed |Added Attachment #126162|0 |1 is obsolete|

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #18 from Andrew Fuerste-Henry --- All that said, if I've created and captured a hold that started with an expiration date, reverting the hold's waiting status *is* successfully setting the expiration date back to what the

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Commen

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #16 from Andrew Fuerste-Henry --- The system preference DefaultHoldExpirationdate puts a date into expirationdate but not your new patron_expiration_date field: expirationdate: 2021-10-23 patron_expiration_date:

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #14 from Jonathan Druart --- Created attachment 126162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126162&action=edit Bug 21729: Keep expiration date set when placing a hold The expiration date pick

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #13 from Jonathan Druart --- Created attachment 126161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126161&action=edit Bug 21729: DBIC schema changes -- You are receiving this mail because: You are

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #12 from Jonathan Druart --- Created attachment 126160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126160&action=edit Bug 21729: DB changes -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- Y

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary.

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Klas Blomberg changed: What|Removed |Added CC||klas.blomb...@skovde.se ---

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --- C

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Brenda changed: What|Removed |Added CC||bow...@washoecounty.us -- You are

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #8 from Sally --- (In reply to Katrin Fischer from comment #4) > Bug 21032 among others has suggested that we have a separate database field > for the expiration date or the waiting date - I agree this is the right fix.

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #7 from Lisette Scheer --- On master the expiration date can be edited/cleared once the hold is reverted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #6 from Christopher Brannon --- (In reply to Katrin Fischer from comment #4) > Bug 21032 among others has suggested that we have a separate database field > for the expiration date or the waiting date - I agree this is th

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Peggy Thrasher changed: What|Removed |Added CC||p.thras...@dover.nh.gov --

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com --

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #4 from Katrin Fischer --- Bug 21032 among others has suggested that we have a separate database field for the expiration date or the waiting date - I agree this is the right fix. -- You are receiving this mail because:

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Katrin Fischer changed: What|Removed |Added CC||cbran...@cdalibrary.org --

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 koha-US bug tracker changed: What|Removed |Added CC||bugzi...@koha-us.org

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew changed: What|Removed |Added CC||and...@bywatersolutions.com --- Co

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Katrin Fischer changed: What|Removed |Added Summary|When reverting a hold the |When reverting a hold the

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset?

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset?

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receivi

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset?

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -

[Koha-bugs] [Bug 21729] When reverting a hold the expirationdate should be reset?

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Nick Clemens changed: What|Removed |Added Depends on||21608 Referenced Bugs: htt