[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #24 f

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #84729|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #84731|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #84733|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #31 from Martin Renvoize --- Created attachment 85326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85326&action=edit Bug 21756: (QA follow-up) Fixes for rebase Signed-off-by: Martin Renvoize -- Yo

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #30 from Martin Renvoize --- Created attachment 85325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85325&action=edit Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #84730|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #84732|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #32 from Martin Renvoize --- Created attachment 85327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85327&action=edit Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by:

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #3

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #34 from Tomás Cohen Arazi --- \o/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #35 from Josef Moravec --- Created attachment 85350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85350&action=edit Bug 21756: (QA follow-up) Fix Circulation.t -- You are receiving this mail because:

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #36 f

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #38 from Martin Renvoize --- I'm going to take another look at this again in the morning with fresh eyes. The final follow-up fix you've added Josef highlights a logical error to me... Feels like accounttype should not be

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #39 from Martin Renvoize --- Having looked again this morning, I'm OK with the accounttype being altered in the test there.. it mimics the behaviour of the FU -> F transition that happens in C4::Overdues. So.. I'm re-run

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #40 from Martin Renvoize --- Ack.. thought I'd double check I'd caught all counts of manualinvoice and it seems a few new ones have been introduced since I wrote this patchset.. bear with my whilst I do yet another follow

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85320|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85322|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85321|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85324|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85323|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85325|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85350|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85326|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #85327|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #51 from Martin Renvoize --- Created attachment 85430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85430&action=edit Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by:

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #50 from Martin Renvoize --- Created attachment 85429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85429&action=edit Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renv

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #5

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Depends on||21721 Referenced Bugs:

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Depends on|21002 | Referenced Bugs: https

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Tomás Cohen Arazi changed: What|Removed |Added Summary|Update |Remove

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #2 from Martin Renvoize --- Created attachment 83258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83258&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior t

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #4 from Martin Renvoize --- Created attachment 83260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83260&action=edit Bug 21747: Update members/manivoice to use add_debit -- You are receiving this mai

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #1 from Martin Renvoize --- Created attachment 83257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83257&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior t

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #5 from Martin Renvoize --- Created attachment 83261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83261&action=edit Bug 21747: Add deprecation warning to manualinvoice -- You are receiving this mail

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #3 from Martin Renvoize --- Created attachment 83259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83259&action=edit Bug 21756: Replace manualinvoice with add_debit in tests -- You are receiving this

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83259|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83257|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #7 from Martin Renvoize --- Created attachment 83263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83263&action=edit Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83261|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83260|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83264|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83262|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #14 from Martin Renvoize --- Created attachment 83270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83270&action=edit Bug 21756: Update members/manivoice to use add_debit -- You are receiving this ma

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83263|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #15 from Martin Renvoize --- Created attachment 83271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83271&action=edit Bug 21756: Add deprecation warning to manualinvoice -- You are receiving this mai

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83266|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83265|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #16 from Martin Renvoize --- Test Plan 1) Apply patches and run the test suit to check for regressions in tests 2) Use the manual invoice page to add a new invoice, this should work 3) As above, but use a non-existent it

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Target Milestone|--- |19.05 -- You are receivi

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Blocks||21683 Referenced Bugs:

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Blocks|14825 | Referenced Bugs: https

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Com

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Bug 21756 depends on bug 21002, which changed state. Bug 21002 Summary: Add Koha::Account::add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 What|Removed |Added -

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83267|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83270|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83269|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83268|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Attachment #83271|0 |1 is obsolete|

[Koha-bugs] [Bug 21756] Remove C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment