[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #32

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83156|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83150|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83154|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83152|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83153|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83151|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Attachment #83149|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are rec

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #24 from Marcel de Rooy --- This fails with me (with and without your patches): not ok 4 - Item on hold skipped, count makes sense # Failed test 'Item on hold skipped, count makes sense' # at t/db_depende

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #23 from Marcel de Rooy --- Created attachment 83156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83156&action=edit Bug 21798: (QA follow-up) Fix Biblios.t Global symbol "$bibnum" requires explicit p

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #22 from Jonathan Druart --- Created attachment 83154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83154&action=edit Bug 21798: replace gimme_a_biblio with build_sample_biblio -- You are receiving

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart changed: What|Removed |Added Attachment #82116|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #21 from Jonathan Druart --- Created attachment 83153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83153&action=edit Bug 21798: Replace 2 more occurrences -- You are receiving this mail because: Yo

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #18 from Jonathan Druart --- Created attachment 83150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83150&action=edit Bug 21798: Unify the creation of bibliographic record in tests Using the newly cr

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #19 from Jonathan Druart --- Created attachment 83151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83151&action=edit Bug 21798: Fix a wrong test Now biblioitem.itemtype has a value, GetItem should f

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #20 from Jonathan Druart --- Created attachment 83152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83152&action=edit Bug 21798: Fix another test We should correctly generate the data we need, here w

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart changed: What|Removed |Added Blocks||21971 Referenced Bugs:

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #16 from Marcel de Rooy --- Applying: Bug 21798: Unify the creation of bibliographic record in tests fatal: sha1 information is lacking or useless (t/db_dependent/Circulation.t). -- You are receiving this mail because:

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #15 from Jonathan Druart --- I can replace gimme_a_biblio with whatever you want in 5 secondes. However it will take much longer to rebase the patch given its size :) -- You are receiving this mail because: You are wat

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart changed: What|Removed |Added Attachment #82943|0 |1 is obsolete|

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #14 from Jonathan Druart --- Created attachment 83137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83137&action=edit Bug 21798: replace gimme_a_biblio with build_sample_biblio -- You are receiving

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #12 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #11) > create_biblio ? > build_biblio ? Or perhaps is build_sample_biblio even better on second thought. It conveys also that it is a sample. -- You

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #11 from Marcel de Rooy --- create_biblio ? build_biblio ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- Y

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #10 from Jonathan Druart --- Created attachment 82943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82943&action=edit Bug 21798: Replace 2 more occurrences -- You are receiving this mail because: Yo

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart changed: What|Removed |Added Assignee|tomasco...@gmail.com|jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #7 from Jonathan Druart --- Created attachment 82276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82276&action=edit Bug 21798: Unify the creation of bibliographic record in tests Using the newly cre

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #9 from Jonathan Druart --- Created attachment 82278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82278&action=edit Bug 21798: Fix another test We should correctly generate the data we need, here we

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #8 from Jonathan Druart --- Created attachment 82277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82277&action=edit Bug 21798: Fix a wrong test Now biblioitem.itemtype has a value, GetItem should fi

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #6 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #5) > I am quite ok to create such methods in TestBuilder.pm > > This new method will replace the multiple occurrences of: > * add_biblio > * create_he

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Jonathan Druart changed: What|Removed |Added Blocks||21816 Referenced Bugs:

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #5 from Jonathan Druart --- I am quite ok to create such methods in TestBuilder.pm This new method will replace the multiple occurrences of: * add_biblio * create_helper_biblio * get_biblio We also will need methods t

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@bugs.koh

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #3) > The word gimme is not conform our naming standards imo :) > And gimme_a_biblio should imo not be in TestBuilder. We can already get a > biblio f

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #3 from Marcel de Rooy --- The word gimme is not conform our naming standards imo :) And gimme_a_biblio should imo not be in TestBuilder. We can already get a biblio from TestBuilder. What you actually want is a simple MA

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #2 from Tomás Cohen Arazi --- Had to leave, will provide tests tomorrow -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Ko

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 82116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82116&action=edit Bug 21798: We need t::lib::TestBuilder::gimme_a_biblio Signed-off-by: Tomas Cohen

[Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::gimme_a_biblio

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Tomás Cohen Arazi changed: What|Removed |Added Summary|We need |We need