https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #46 from Katrin Fischer ---
I've set this to Failed QA since Marcel and Nick agree that a different
approach might be better here.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Jonathan Druart changed:
What|Removed |Added
Status|BLOCKED |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #44 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #42)
> > Keep one file == Do not make a copy of the original upload to yet another
> > location.
>
> It will complexity the code a bit more, but I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Marcel de Rooy changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #42 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #40)
> (In reply to Jonathan Druart from comment #39)
> > Are you suggesting I should rewrite the whole patch and rethink the
> > approach?
> More
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #41 from Hugo Agud ---
> More or less, yes. Note that we now have three parallel developments on this
> topic. Also one from Devinim and Julian.
please may you provide de bugnumber, please?
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #40 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #39)
> Are you suggesting I should rewrite the whole patch and rethink the
> approach?
More or less, yes. Note that we now have three parallel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #39 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #37)
> (In reply to Jonathan Druart from comment #33)
> > (In reply to Marcel de Rooy from comment #28)
> > > > tools/upload-file.pl:
> > > >
> > >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #38 from Hugo Agud ---
the less complexity the better...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #37 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #33)
> (In reply to Marcel de Rooy from comment #28)
> > > tools/upload-file.pl:
> > >
> > > # FIXME The copy must be done in Koha::Uploader, but
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #36 from Marcel de Rooy ---
(In reply to Fridolin SOMERS from comment #32)
> I see there is Bug 22835.
> Should we serve also those uploaded file via API ?
> In another bug report I mean.
Looking at that bug, I think it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #35 from Marcel de Rooy ---
(In reply to Hugo Agud from comment #31)
> The original goal of this patch is to allow discoveries to access directly
> the files located at koha repository for full text indexing, it is not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #34 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #29)
> +sub local_public_path {
> +my ($self) = @_;
> +my $upload_public_path = C4::Context->config('upload_public_path');
> +return
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #33 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #28)
> > tools/upload-file.pl:
> >
> > # FIXME The copy must be done in Koha::Uploader, but where?
> > # I (Joubu) did not find a place where the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #32 from Fridolin SOMERS ---
I see there is Bug 22835.
Should we serve also those uploaded file via API ?
In another bug report I mean.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Fridolin SOMERS changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #31 from Hugo Agud ---
(In reply to Marcel de Rooy from comment #30)
> In general I have my doubts on making these changes. It does not really fit
> in with the original design.
> Having a flag public to control OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #30 from Marcel de Rooy ---
In general I have my doubts on making these changes. It does not really fit in
with the original design.
Having a flag public to control OPAC access and a new public path could be a
bit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #29 from Marcel de Rooy ---
+sub local_public_path {
+my ($self) = @_;
+my $upload_public_path = C4::Context->config('upload_public_path');
+return unless $upload_public_path;
+$upload_public_path =~
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #28 from Marcel de Rooy ---
> tools/upload-file.pl:
>
> # FIXME The copy must be done in Koha::Uploader, but where?
> # I (Joubu) did not find a place where the file was completely written
Look at Uploader sub cgi when
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #27 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #23)
> This is actually blocked by bug 22644. I am keeping the NQA status as I
> would like to get feedback from the QA team on this patchset.
Bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Jonathan Druart changed:
What|Removed |Added
Attachment #89545|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #25 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #24)
> You've asked for feedback from the QA team... so I'll try:
>
> 1) QA tools:
>
>FAIL valid_template
> parse error -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |BLOCKED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Jonathan Druart changed:
What|Removed |Added
Depends on||22644
--- Comment #23
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
claire.hernan...@biblibre.com changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #21 from Jonathan Druart
---
Created attachment 89545
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89545=edit
Bug 22508: Add warnings to about page
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #20 from Jonathan Druart
---
Created attachment 89544
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89544=edit
Bug 22508: add POD
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #19 from Jonathan Druart
---
Created attachment 89543
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89543=edit
Bug 22508: Delete the public file on deleting the upload
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Jonathan Druart changed:
What|Removed |Added
Attachment #87272|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #17 from Jonathan Druart
---
Created attachment 89541
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89541=edit
Bug 22508: Add upload_public_url to config
Signed-off-by: Hugo Agud
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #18 from Jonathan Druart
---
Created attachment 89542
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89542=edit
Bug 22508: Add the ability to prefill 856$u with the direct URL of the file
When
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #12 from Jonathan Druart
---
Created attachment 87431
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87431=edit
Bug 22508: add POD
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #13 from Jonathan Druart
---
Created attachment 87432
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87432=edit
Bug 22508: Add warnings to about page
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #11 from Jonathan Druart
---
Created attachment 87430
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87430=edit
Bug 22508: Delete the public file on deleting the upload
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Hugo Agud changed:
What|Removed |Added
Attachment #86584|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Hugo Agud changed:
What|Removed |Added
Attachment #86585|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Hugo Agud changed:
What|Removed |Added
Attachment #86583|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #7 from Hugo Agud ---
It works fine, this is very useful for example if we share records via oai-pmh
to a discovery and it has the functionality of full text extraction, it needs
direct access to full text, now with this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #6 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #5)
> (In reply to Marcel de Rooy from comment #4)
> > (In reply to Jonathan Druart from comment #3)
> > > * In discussion - what about the upload of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #5 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > * In discussion - what about the upload of files from outside of the
> > cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #4 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #3)
> * In discussion - what about the upload of files from outside of the
> cataloguing plugin?
Never seen Tools: Upload ?
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|In Discussion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #2 from Jonathan Druart
---
Created attachment 86584
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86584=edit
Bug 22508: Add upload_public_url to config
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #3 from Jonathan Druart
---
Created attachment 86585
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86585=edit
Bug 22508: Add the ability to prefill 856$u with the direct URL of the file
When
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
--- Comment #1 from Jonathan Druart
---
Created attachment 86583
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86583=edit
Bug 22508: Add upload_public_path to config
--
You are receiving this mail because:
You
51 matches
Mail list logo
