[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #3 from Jonathan Druart --- Note that now there is the following error in the log: DBD::mysql::st execute failed: Mixing of GROUP columns (MIN(),MAX(),COUNT(),...) with no GROUP columns is illegal if there is no GROUP B

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Jonathan Druart changed: What|Removed |Added Summary|Cannot add new subscription |Cannot add new subscriptio

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #4 from Jonathan Druart --- Created attachment 89392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89392&action=edit Bug 22812: Add tests for checkrouting -- You are receiving this mail because: You

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #5 from Jonathan Druart --- Created attachment 89393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89393&action=edit Bug 22812: Fix GROUP BY in checkrouting On the way, let fix this error DBD::mysql:

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Liz Rea changed: What|Removed |Added Attachment #89391|0 |1 is obsolete|

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #8 from Liz Rea --- Created attachment 89456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89456&action=edit Bug 22812: Fix GROUP BY in checkrouting On the way, let fix this error DBD::mysql::st execu

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #7 from Liz Rea --- Created attachment 89455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89455&action=edit Bug 22812: Add tests for checkrouting Signed-off-by: Liz Rea -- You are receiving this m

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #10 from Marcel de Rooy --- SELECT count(routingid) routingids FROM subscription LEFT JOIN subscriptionroutinglist ON subscription.subscriptionid = subscriptionroutinglist.subscriptionid order by ranking asc; does not ra

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Marcel de Rooy changed: What|Removed |Added Attachment #89456|0 |1 is obsolete|

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Marcel de Rooy changed: What|Removed |Added Attachment #89454|0 |1 is obsolete|

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Marcel de Rooy changed: What|Removed |Added Attachment #89455|0 |1 is obsolete|

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #14 from Marcel de Rooy --- QA Comment: Bug apparently solved. Some minor questions, no blockers. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rece

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #15 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #9) > +$_ ||= undef # Set to undef for integer values, not empty string > + for ( > +$aqbooksellerid, $lastvalue1, $innerloop1, $last

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #16 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #10) > SELECT count(routingid) routingids FROM subscription LEFT JOIN > subscriptionroutinglist ON subscription.subscriptionid = > subscriptionrouting

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Jonathan Druart changed: What|Removed |Added Status|Passed QA |ASSIGNED -- You are rece

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #17 from Jonathan Druart --- Created attachment 89561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89561&action=edit Bug 22812: Use Koha::Subscription in NewSubscription Starting to write tests I re

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #18 from Jonathan Druart --- Maybe I went a bit too far with this last patch, but it's definitely the way to go. Sending back to NSO as I rewrote the original approach. -- You are receiving this mail because: You are w

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Michal Denar changed: What|Removed |Added Attachment #89535|0 |1 is obsolete|

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are recei

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #20 from Michal Denar --- Created attachment 89571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89571&action=edit Bug 22812: Add tests for checkrouting Signed-off-by: Liz Rea Signed-off-by: Marcel

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #21 from Michal Denar --- Created attachment 89572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89572&action=edit Bug 22812: Fix GROUP BY in checkrouting On the way, let fix this error DBD::mysql::st

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #22 from Michal Denar --- Created attachment 89573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89573&action=edit Bug 22812: Use Koha::Subscription in NewSubscription Starting to write tests I realiz

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch St

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Katrin Fischer changed: What|Removed |Added Attachment #89573|0 |1 is obsolete|

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Katrin Fischer changed: What|Removed |Added Attachment #89571|0 |1 is obsolete|

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Katrin Fischer changed: What|Removed |Added Attachment #89570|0 |1 is obsolete|

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Katrin Fischer changed: What|Removed |Added Attachment #89572|0 |1 is obsolete|

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 --- Comment #27 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #16) > MariaDB [koha_kohadev]> SET sql_mode = > 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE, > ERROR_FOR_DIVISION_BY_ZERO,NO_A

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Martin Renvoize changed: What|Removed |Added Version(s)||19.05.00, 18.11.06

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-communit