[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Katrin Fischer changed: What|Removed |Added CC||andre...@dubcolib.org ---

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #28 from Jonathan Druart --- * Does that need to block staff users as well? At first I understood that is was for OPAC only, but C4::Reserves::SuspendAll is blocking it. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #26 from Magnus Enger --- Thanks, Stina! :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Stina Hallin changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ByWater Sandboxes changed: What|Removed |Added Attachment #98947|0 |1 is obsolete|

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ByWater Sandboxes changed: What|Removed |Added Attachment #98671|0 |1 is obsolete|

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ByWater Sandboxes changed: What|Removed |Added Attachment #98670|0 |1 is obsolete|

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 ByWater Sandboxes changed: What|Removed |Added Attachment #98669|0 |1 is obsolete|

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #21 from Magnus Enger --- (In reply to Stina Hallin from comment #19) > That was line 140. We think that you also need to add it to line 186. Ah, gotach! Could you please test again now, with all the patches? -- You

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #20 from Magnus Enger --- Created attachment 98947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98947=edit Bug 22833 - QA followup This patch incorporates the suggestions made by Stina Hallin. To

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #19 from Stina Hallin --- (In reply to Magnus Enger from comment #18) > (In reply to Stina Hallin from comment #17) > > And replace: > > [% IF ( HOLD.is_cancelable_from_opac ) %] > > > > with: > > [% IF (

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #18 from Magnus Enger --- (In reply to Stina Hallin from comment #17) > And replace: > [% IF ( HOLD.is_cancelable_from_opac ) %] > > with: > [% IF ( HOLD.is_cancelable_from_opac && ItemTypes.CanCancelHold( >

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #17 from Stina Hallin --- Here's the description of itemtypes: +-+---+--+-+-+---+ | Field | Type | Null | Key | Default | Extra |

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #16 from Magnus Enger --- (In reply to Stina Hallin from comment #15) > Tried the patsch again and got this plack error message when I unchecked the > box: > > DBD::mysql::st execute failed: Column 'can_cancel_hold'

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Stina Hallin changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize changed: What|Removed |Added Attachment #96196|0 |1 is obsolete|

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize changed: What|Removed |Added Attachment #98650|0 |1 is obsolete|

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize changed: What|Removed |Added Attachment #96197|0 |1 is obsolete|

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #13 from Martin Renvoize --- Created attachment 98671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98671=edit Bug 22833: Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #12 from Martin Renvoize --- Created attachment 98670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98670=edit Bug 22833: Flag booleans in Itemtype.pm Signed-off-by: Martin Renvoize -- You are

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #11 from Martin Renvoize --- Created attachment 98669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98669=edit Bug 22833: Schema update, DO NOT PUSH Signed-off-by: Martin Renvoize -- You are

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #10 from Martin Renvoize --- This is more of a general enhancement than purely an ILL feature.. as such I've set the status's accordingly to try and expose it to a few more interested parties and get it moving. Looks

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize changed: What|Removed |Added Component|ILL |Hold requests

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Martin Renvoize changed: What|Removed |Added Severity|normal |enhancement

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #9 from Magnus Enger --- (In reply to Stina Hallin from comment #6) > Hello Magnus, I tried the patch, but when testing, Koha gave an error > message when I unchecked the Cancel and Suspend hold check boxes on the Item >

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger changed: What|Removed |Added Attachment #98649|0 |1 is obsolete|

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger changed: What|Removed |Added Attachment #96207|0 |1 is obsolete|

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Stina Hallin changed: What|Removed |Added CC||stina.hal...@ub.lu.se ---

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger changed: What|Removed |Added Attachment #96198|0 |1 is obsolete|

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #4 from Magnus Enger --- Created attachment 96198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96198=edit Bug 22833 - Block suspend and cancel on holds Swedish ILL uses a hold as part of the ILL

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger changed: What|Removed |Added Patch complexity|--- |Small patch

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #3 from Magnus Enger --- Created attachment 96197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96197=edit Bug 22833 - Flag booleans in Itemtype.pm -- You are receiving this mail because: You are

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 --- Comment #2 from Magnus Enger --- Created attachment 96196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96196=edit Bug 22833 - Schema update, DO NOT PUSH -- You are receiving this mail because: You are

[Koha-bugs] [Bug 22833] Block suspend and cancel on holds

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833 Magnus Enger changed: What|Removed |Added Summary|Don't let users cancel |Block suspend and cancel on