https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to master|RESOLVED
Resoluti
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Jonathan Druart changed:
What|Removed |Added
Keywords|additional_work_needed |
--
You are receiving th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Joy Nelson changed:
What|Removed |Added
CC||j...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #45 from Jonathan Druart
---
Yes, pushed to master for 20.05
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Jonathan Druart changed:
What|Removed |Added
Blocks||25423
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #44 from Tomás Cohen Arazi ---
(In reply to Tomás Cohen Arazi from comment #41)
> I leave the last patch for you to review, Martin and Jonathan. I took the
> liberty to push the others as they were breaking Jenkins.
Do w
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #43 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #42)
> Tomas, I feel like we should explode if Koha::Objects->update is called:
> test ref($self) at the beginning. What do you think?
I agree.
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #42 from Jonathan Druart
---
Tomas, I feel like we should explode if Koha::Objects->update is called: test
ref($self) at the beginning. What do you think?
--
You are receiving this mail because:
You are on the CC list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #41 from Tomás Cohen Arazi ---
I leave the last patch for you to review, Martin and Jonathan. I took the
liberty to push the others as they were breaking Jenkins.
--
You are receiving this mail because:
You are on the C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords||additional_work_needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #40 from Tomás Cohen Arazi ---
Created attachment 104541
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104541&action=edit
Bug 23185: (follow-up) K:C:Register->make_default should use no_triggers
Signe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #39 from Tomás Cohen Arazi ---
Created attachment 104538
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104538&action=edit
Bug 23185: Realistic POD for Koha::Objects->search
Signed-off-by: Tomas Cohen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #38 from Tomás Cohen Arazi ---
Created attachment 104537
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104537&action=edit
Bug 23185: ->update can only be called on instantiated classes
Since our use o
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_20_05_candidate,|
|RM_pr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #37 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #36 from Tomás Cohen Arazi ---
Created attachment 104276
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104276&action=edit
Bug 23185: (QA follow-up) Add POD for Koha::Objects->update
Signed-off-by: Tom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #35 from Tomás Cohen Arazi ---
Created attachment 104273
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104273&action=edit
Bug 23185: (QA follow-up) Semantics, split fields and options
This patch impro
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #34 from Tomás Cohen Arazi ---
Created attachment 104272
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104272&action=edit
Bug 23185: Make Koha::Objects->update loop on the object set if needed
Signed-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #33 from Tomás Cohen Arazi ---
Created attachment 104271
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104271&action=edit
Bug 23185: Add tests
Signed-off-by: Bernardo Gonzalez Kriegel
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #104234|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #104233|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #104232|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #31 from Victor Grousset/tuxayo ---
(In reply to Jonathan Druart from comment #30)
> When it's a "structural change", and especially if there is no test plan or
> test plan is simply "run the tests", then it means it's al
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #30 from Jonathan Druart
---
(In reply to Victor Grousset/tuxayo from comment #29)
> Works! Signed off. Assuming the test plan was only to run the tests.
Thanks Victor.
When it's a "structural change", and especially i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #29 from Victor Grousset/tuxayo ---
Works! Signed off. Assuming the test plan was only to run the tests.
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #104088|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #104089|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #104087|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What|Removed |Added
Depends on|25303 |
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What|Removed |Added
Depends on|23187 |
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What|Removed |Added
Attachment #103947|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #25 from Martin Renvoize ---
Created attachment 104089
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104089&action=edit
Bug 23185: (QA follow-up) Semantics, split fields and options
This patch improve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What|Removed |Added
Attachment #103946|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #22 from Martin Renvoize ---
Generally.. I really like this however :)
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #21 from Martin Renvoize ---
Comment on attachment 103947
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103947
Bug 23185: Make Koha::Objects->update loop on the object set if needed
Review of attachme
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #103868|0 |1
is obs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #103867|0 |1
is obs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |ASSIGNED
--- Comment #17
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
CC||bgkrie...@gmail.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #15 from Jonathan Druart
---
It passes for me, in ~30sec
--
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
___
Koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #12 from Jonathan Druart
---
Does this make sense?
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #11 from Jonathan Druart
---
Created attachment 103868
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103868&action=edit
Bug 23185: Make Koha::Objects->update loop on the object set if needed
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #10 from Jonathan Druart
---
Created attachment 103867
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103867&action=edit
Bug 23185: Add tests
--
You are receiving this mail because:
You are on the CC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #9 from Martin Renvoize ---
(In reply to Marcel de Rooy from comment #8)
> Is adding direct_update not adding the sidestep that you wanted to catch ?
It's making the side step very explicit.. there are certainly times wh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #8 from Marcel de Rooy ---
Is adding direct_update not adding the side step that you wanted to catch ?
--
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Jonathan Druart changed:
What|Removed |Added
Blocks||23070
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #7 from Martin Renvoize ---
Agreed with Jonathan that we should default Koha::Objects->update to loop
through the resultset and call Koha::Object->store.. However, we should also
allow for a direct_update option either b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Jonathan Druart changed:
What|Removed |Added
Depends on||25303
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Jonathan Druart changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #6 from Martin Renvoize ---
More and more I feel like this needs to be caught at the QA level.. whenever we
see the 'store' method being changed/created in a Koha::Thing class we should
warn the QA person via the qa scrip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Bug 23185 depends on bug 21761, which changed state.
Bug 21761 Summary: Koha::Object supports passing through 'update' which means
we can side step 'set' + 'store'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What|Removed |Added
Keywords||rel_20_05_target,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #5 from Marcel de Rooy ---
I almost added similar comments on 21761 until I spotted this one.
Obviously, implementing update on a larger resultset by looping and storing
individually will be a performance thing.
Wouldnt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What|Removed |Added
Severity|critical|major
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #4 from Martin Renvoize ---
I also think it wouldn't be a bad idea to have an 'update_with_triggers' or
something along those lines method which in effect did a dbic update_all
call(https://metacpan.org/pod/DBIx::Class::R
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #3 from Martin Renvoize ---
My personal feeling is that perhaps we should allow this one through but add a
QA script warning to check that 'store' for the object in question doesn't have
any triggers in place for the fiel
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #2 from Martin Renvoize ---
See further discussion in bug 23070
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
--- Comment #1 from Martin Renvoize ---
Note the 's' in the bug title.. this is not the same as 'Koha::Object'
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
You are on t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185
Martin Renvoize changed:
What|Removed |Added
Depends on||23187
Referenced Bugs:
70 matches
Mail list logo