[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #14 from Martin Renvoize --- Pretty sure the last patch resolves the issue reported here.. but I've not added tests to cover that fix yet so that'll have to come in a followup. (CanBookBeIssued seems to be entirely

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #13 from Martin Renvoize --- Created attachment 92276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92276=edit Bug 23382: Fix logic in C4::Circulation::CanBookBeIssued It looks like over progressive

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #92238|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #92237|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #92236|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #9 from Martin Renvoize --- OK, it's not that either... :( I have however found some annoying flaws in our DateTime maths which are highlighted by the hourly tests.. I have no idea how to resolve them.. In short..

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #8 from Martin Renvoize --- oooh.. RentalFeesCheckoutConfirmation plays into it.. I missed that.. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #7 from Martin Renvoize --- Hmm.. Well, I've greatly increased the test coverage.. but I've not yet managed to replicate the issue :( -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #92221|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #6 from Martin Renvoize --- Created attachment 92238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92238=edit Bug 23382: Add hourly tests for Circulation -- You are receiving this mail because: You

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Attachment #9|0 |1 is obsolete|

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #2 from Martin Renvoize --- Created attachment 92221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92221=edit Bug 23382: Improve test coverage -- You are receiving this mail because: You are

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #3 from Martin Renvoize --- Created attachment 9 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9=edit Bug 23382: Add tests for hourly calculations -- You are receiving this mail because: You

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Martin Renvoize changed: What|Removed |Added Depends on||20912

[Koha-bugs] [Bug 23382] Hourly rental fees are not charged

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 --- Comment #1 from Nick Clemens --- I believe the issue is two calls to accumulate_rentalcharge() that do not pass current date and due date - so there is no time difference to calculate -- You are receiving this mail because: