[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #32 from Jon

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Bug 23493 depends on bug 23013, which changed state. Bug 23013 Summary: Upgrade DataTables in the staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 What|Removed |Added ---

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #31 from Martin Renvoize --- Created attachment 98132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98132&action=edit Bug 23493: (RM follow-up) Let datatables calculate colspan for us Prior to this we

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #30 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing li

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #29 from Jonathan Druart --- Created attachment 98118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98118&action=edit Bug 23493: Fix selenium/regressions.t One test wants to make sure thead, tfood an

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #28 from Martin Renvoize --- Corrected by reverting the errantly pushed patches and applying the followup here instead. -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Blocks||24533 Referenced Bugs:

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed --

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #26 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing li

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #25 from Jonathan Druart --- Ok so I confused Martin with my previous comments. I wanted to highlight the fact that there was a behavior's change, but did not consider it a regression or blocker. I am happy with how it

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #24 from Jonathan Druart --- Created attachment 98056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98056&action=edit Bug 23493: Remove commented lines Signed-off-by: Jonathan Druart -- You are re

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Jonathan Druart changed: What|Removed |Added Attachment #98041|0 |1 is obsolete|

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rec

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #22 from Jonathan Druart --- I do not think it's correct, now we cannot really sort by due date: https://snipboard.io/TRx43j.jpg -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #21 from Martin Renvoize --- OK, I see what you mean now.. good catch. See followup which I believe addresses the issue. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Attachment #97704|0 |1 is obsolete|

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #20 from Martin Renvoize --- Created attachment 98042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98042&action=edit Bug 23493: (follow-up) Switch to aDataSort for multi-column sorting This patch add

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #18 from Jonathan Druart --- I bet you did not sort the column by "due date". Take a look at the "checked out on" and "due date" column on my screenshots. -- You are receiving this mail because: You are watching all bu

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #17 from Martin Renvoize --- Hmm, Removing the commented lines seems sensible.. I'll do that now.. As for the display discrepancy you mention.. I can't seem to replicate that. https://snipboard.io/1DOacC.jpg (before)

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #16 from Jonathan Druart --- One change I noticed: when the column are sorted the "grouped tr" are displayed with this new version: https://snipboard.io/HzXJ4l.jpg (before) https://snipboard.io/zRb4sk.jpg (after) -- Yo

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #15 from Jonathan Druart --- 609 "fnInitComplete": function(oSettings, json) { 610 // Disable rowGroup plugin after first use 611 // so any sorting on the table doesn't use

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #14 from Martin Renvoize --- Dependency re-ordered as requested and suitable re-base undertaken. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Depends on|23355 | Blocks|

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Attachment #97694|0 |1 is obsolete|

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #12 from Jonathan Druart --- I am expecting this bug report to add the rowGroup plugin, not bug 23355. It seems easy to make the dependency the other way around. -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #11 from Martin Renvoize --- Simple rebase performed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added CC||oleon...@myacpl.org

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Assignee|oleon...@myacpl.org |martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Attachment #97344|0 |1 is obsolete|

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #8 from Kyle M Hall --- Looks great to me! I also find the styling to be a bit improved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bug

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Kyle M Hall changed: What|Removed |Added Attachment #97324|0 |1 is obsolete|

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Attachment #92444|0 |1 is obsolete|

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Depends on||23355 Referenced Bugs:

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #5 from Martin Renvoize --- Oops, forgot to squash before uploading to BZ... should be better now. -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Attachment #92443|0 |1 is obsolete|

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #3 from Kyle M Hall --- Is this patch complete? I'm not seeing the CDN import line among other things :) (In reply to Martin Renvoize from comment #2) > This is a somewhat rough and ready attempt at replacement to get so

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #2 from Martin Renvoize --- This is a somewhat rough and ready attempt at replacement to get someone started. I've directly included the new plugin via a CDN link, this would clearly need to be bundled in our datatables

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 --- Comment #1 from Martin Renvoize --- Created attachment 92443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92443&action=edit Bug 23493: Replace rowGrouping with rowGroup This is an initial attempt to get some

[Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there is an official DataTables version we could switch to

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493 Martin Renvoize changed: What|Removed |Added Depends on||23013 Referenced Bugs: