https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
--- Comment #11 from Katrin Fischer ---
(In reply to Martin Renvoize from comment #10)
> This bug also applies at master to so I'm correcting the version to 'master'
> and will bring it to the attention of RMaints that it's required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
Martin Renvoize changed:
What|Removed |Added
Version|19.05 |master
--- Comment #10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
--- Comment #9 from Katrin Fischer ---
(In reply to Andreas Jonsson from comment #7)
> Since the problem is likely caused by the confusion caused by the fact that
> the variable name $branch is sometimes used for branchnumbers and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
--- Comment #8 from Katrin Fischer ---
Thx Andreas :)
Usually I'd expect something like:
- Do this in Koha
- Go there... click that
- Verify it is broken
- Apply patch
- Repeat steps above
- Verify it's working now!
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
--- Comment #7 from Andreas Jonsson ---
Since the problem is likely caused by the confusion caused by the fact that the
variable name $branch is sometimes used for branchnumbers and sometimes for
library objects I think that it is a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
Andreas Jonsson changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
--- Comment #5 from Katrin Fischer ---
I am not sure about the second patch - If this is fixing a bug in 19.05 (not
being pushed to master) - does the renaming of variables not cause some
problem?
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
--- Comment #3 from Martin Renvoize ---
It's a little scary that this wasn't caught by any tests :(.
What sort of circ rule did you have set that triggered you to find this? It may
help me come up with a new test.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
--- Comment #2 from Martin Renvoize ---
Created attachment 92967
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92967=edit
Bug 23586: (follow-up) Clarify variable names
This patch updates the variable name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
Martin Renvoize changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
Martin Renvoize changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
--- Comment #1 from Martin Renvoize ---
Created attachment 92966
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92966=edit
Bug 23586: Correct call to CalcDateDue
This patch corrects the call to CalcDateDue in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
Martin Renvoize changed:
What|Removed |Added
CC|
15 matches
Mail list logo
