https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #43 from David Cook ---
(In reply to Victor Grousset/tuxayo from comment #42)
> The schema hosting at swagger.io is back
> https://github.com/swagger-api/swagger.io/issues/282
This is great!
Although I hope this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #42 from Victor Grousset/tuxayo ---
The schema hosting at swagger.io is back
https://github.com/swagger-api/swagger.io/issues/282
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Fridolin SOMERS changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #40 from David Cook ---
Here's a condensed version of the above:
Good (don't worry):
- Debian Jessie 8
- Debian Stretch 9
- Ubuntu Xenial 16.04
Bad (do worry):
- Debian Buster 10 (and above)
- Ubuntu Bionic 18.04 (and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #39 from David Cook ---
Ok that 3.23 is still in the staging repo.
If you're running a Debian/Ubuntu package, you'll be vulnerable, but not if
you're running a Koha Community package.
So you should be fine on Debian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #38 from David Cook ---
I think Mason found that newer versions of Ubuntu weren't installing 3.06 as
they were using newer versions, but it looks like he's now released a
3.23+dfsg-1+koha1 version.
I've installed that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
David Cook changed:
What|Removed |Added
Assignee|tomasco...@gmail.com|dc...@prosentient.com.au
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #37 from David Cook ---
I'd recommend to people starting their day to look at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653#c11 for a quick
fix to get through the worst of things right now.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #36 from David Cook ---
I've tested the new package in koha-testing-docker and it looks good.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #35 from David Cook ---
Mason announced 30 minutes ago on koha-devel that he's updated the
libjson-validator-perl package.
As per his email:
hi Folks
i've updated the 'libjson-validator-perl' package to include the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #34 from David Cook ---
(In reply to Victor Grousset/tuxayo from comment #33)
> Should we actually expect a significant number of instances to have more
> difficulty applying such a simple patch (just this patch, not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #106444|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #31 from David Cook ---
Created attachment 106444
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106444=edit
Bug 23653: use local copy of swagger v2 schema
By default, JSON::Validator::OpenAPI tries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
David Cook changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #30 from Victor Grousset/tuxayo ---
(In reply to Tomás Cohen Arazi from comment #23)
> We should just package the library with the correct cache
Indeed, that way, deployers only have to update the perl-deps, no patch to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #29 from David Cook ---
Actually, it looks like Koha::REST::Plugin::PluginRoutes doesn't receive the
validator.
It looks like the OpenAPI plugin must be calling a validator and that's where
it's failing...
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #27 from David Cook ---
From what I can see, we're not actually validating the schema in
./Koha/REST/V1.pm when we use bundle().
We only validate it in ./Koha/REST/V1.pm when we do the catch{} block.
And we always
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #28 from David Cook ---
(In reply to David Cook from comment #27)
> I'm going to post a code-level patch anyway (partially just because I'm
> already this far anyway)
Plus, if I do that, then we wouldn't have to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #26 from David Cook ---
Oh wait I'm misunderstanding...
$validator->bundle is just loading the schema... and it doesn't validate it.
Whereas $validator->load_and_validate_schema loads the schema, but then
validates it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #25 from David Cook ---
(In reply to Tomás Cohen Arazi from comment #23)
> (In reply to David Cook from comment #22)
> > I'm about to start on a patch for this. Hopefully will have something very
> > soon.
>
> We should
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #24 from David Cook ---
Note that this should only affect plugin-enabled instances
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #23 from Tomás Cohen Arazi ---
(In reply to David Cook from comment #22)
> I'm about to start on a patch for this. Hopefully will have something very
> soon.
We should just package the library with the correct cache
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #22 from David Cook ---
I'm about to start on a patch for this. Hopefully will have something very
soon.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #21 from David Cook ---
(In reply to Federico Paiz from comment #20)
> The same thing happened to me, I solved it by doing
>
> >cpan
> > install Mojolicious::Plugin::OpenAPI
Yeah, the CPAN version of that module comes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Federico Paiz changed:
What|Removed |Added
CC||federicoantoniopaiz@gmail.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Hayley Mapley changed:
What|Removed |Added
Severity|major |blocker
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #18 from Victor Grousset/tuxayo ---
Issue reported to upstream's upstream:
https://github.com/swagger-api/swagger.io/issues/281
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
ian.gor...@strath.ac.uk changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #16 from Victor Grousset/tuxayo ---
== Test plan ==
1. In /etc/hosts , add «127.0.0.1swagger.io»
2. try to load a page
3. it works
4. koha-plack --restart kohadev
5. try to load a page
6. endless or timeout loading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Victor Grousset/tuxayo changed:
What|Removed |Added
Version|19.05 |master
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #14 from Tomás Cohen Arazi ---
(In reply to Mason James from comment #13)
> (In reply to Mason James from comment #11)
> > (In reply to Mason James from comment #10)
> > > hmm, this does look like a legitimate bug,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #13 from Mason James ---
(In reply to Mason James from comment #11)
> (In reply to Mason James from comment #10)
> > hmm, this does look like a legitimate bug, caused by 22522
>
> ^ oops, ignore that - i was testing on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #12 from c...@pennmanor.net ---
I followed the steps Jason provided to restore the cache folder on debian
buster.
Plack was able to start even when access to swagger.io was blocked.
Thanks!
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Mason James changed:
What|Removed |Added
Status|NEW |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Mason James changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #10 from Mason James ---
hmm, this does look like a legitimate bug, caused by 22522
the 'try' block always fails with...
Can't locate object method "bundle" via package
"JSON::Validator::OpenAPI::Mojolicious" at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #9 from c...@pennmanor.net ---
Here is the output from my fresh buster server with koha-common 20.05.00-1
$ pmvers JSON::Validator
3.06
$ pmvers Mojolicious
8.12
$ pmvers Mojolicious::Plugin::OpenAPI
2.12
From
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #8 from Tomás Cohen Arazi ---
This looks really bad if Koha is trying to contact an external site on start-up
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #7 from Mason James ---
(In reply to Rick Conrad from comment #6)
> I don't have it on-hand, but I believe it was Ubuntu 18.04.
for 18.04, try running these commands
$ sudo echo 'deb
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #6 from Rick Conrad ---
I don't have it on-hand, but I believe it was Ubuntu 18.04.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #5 from Mason James ---
(In reply to Rick Conrad from comment #3)
>
> rick@koha:~$ pmvers JSON::Validator
> 1.08
> rick@koha:~$ pmvers Mojolicious
> 7.59
> rick@koha:~$ pmvers Mojolicious::Plugin::OpenAPI
> 1.15
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Mason James changed:
What|Removed |Added
CC||m...@kohaaloha.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
c...@pennmanor.net changed:
What|Removed |Added
CC||c...@pennmanor.net
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #3 from Rick Conrad ---
rick@koha:~$ pmvers JSON::Validator
1.08
rick@koha:~$ pmvers Mojolicious
7.59
rick@koha:~$ pmvers Mojolicious::Plugin::OpenAPI
1.15
Also
rick@koha:~$ cd /
rick@koha:/$ sudo find
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Tomás Cohen Arazi changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #2 from Tomás Cohen Arazi ---
Can you give us more information on your setup? The 'swagger file' is bundled
in Koha and there shouldn't be any external system reached out.
It would help if you additionally:
$ sudo apt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Katrin Fischer changed:
What|Removed |Added
Component|Architecture, internals,|REST api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #1 from Rick Conrad ---
I observed later that I was able to reach swagger.io from the server, so I
tried reenabling plack and now it's working.
So, this may properly be a plack issue and not a koha issue, but it seems
51 matches
Mail list logo
