[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com ---

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #24 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing li

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #23 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #22) > >This could have been done with a AJAX query but seems more convenient > >this way. > > Or just lazy programming? :) Not only, I thin

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #22 from Marcel de Rooy --- >This could have been done with a AJAX query but seems more convenient >this way. Or just lazy programming? :) -- You are receiving this mail because: You are watching all bug change

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Marcel de Rooy changed: What|Removed |Added Attachment #98963|0 |1 is obsolete|

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are rece

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Marcel de Rooy changed: What|Removed |Added Attachment #101826|0 |1 is obsolete|

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #19 from Marcel de Rooy --- Fridolin, you forgot signoff lines. No big deal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing lis

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #18 from Marcel de Rooy --- (In reply to Joonas Kylmälä from comment #8) > The meeting notes in > https://wiki.koha-community.org/wiki/ > Development_IRC_meeting_27_September_2017 state that "follow-up patches must > be s

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED CC

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #16 from Fridolin SOMERS --- New translation sysptem in JS files is great ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing lis

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #15 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #13) > There are 2 patches : > Bug 23888: Do not allow invalid vendor id on creating a subscription Ok fixed thanks ;) -- You are receiving this ma

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Fridolin SOMERS changed: What|Removed |Added Attachment #98964|0 |1 is obsolete|

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Fridolin SOMERS changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are re

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Owen Leonard changed: What|Removed |Added Attachment #95253|0 |1 is obsolete|

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Owen Leonard changed: What|Removed |Added Attachment #95297|0 |1 is obsolete|

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #12 from Owen Leonard --- Notes: - I squashed the original 2 patches according to guidelines - The QA tool will give a false positive on untranslatable strings because it hasn't been updated along with the new JS-trans

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #11 from Owen Leonard --- Created attachment 98964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98964&action=edit Bug 23888: (follow-up) Wrap English string in translation function This patch makes a

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #10 from Owen Leonard --- Created attachment 98963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98963&action=edit Bug 23888: Do not allow invalid vendor id on creating a subscription It will avoid cr

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are rece

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #9 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #8) > The meeting notes in > https://wiki.koha-community.org/wiki/ > Development_IRC_meeting_27_September_2017 state that "follow-up patches must > be

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #8 from Joonas Kylmälä --- The meeting notes in https://wiki.koha-community.org/wiki/Development_IRC_meeting_27_September_2017 state that "follow-up patches must be squashed if not signed-off yet, and the history is not n

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 f

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #5 from Jonathan Druart --- Created attachment 95297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95297&action=edit Bug 23888: Fix JS error if no vendor defined > ReferenceError: BOOKSELLER_IDS is n

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 f

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #3 from Jonathan Druart --- Created attachment 95253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95253&action=edit Bug 23888: Do not allow invalid vendor id on creating a subscription It will avoid

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #2 from Joonas Kylmälä --- (In reply to Katrin Fischer from comment #1) > I can't replicate the error on master - now it just saves and doesn't show a > vendor name in the details. We should validate if the vendor id is v

[Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -