[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Patch doesn't ap

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Andreas Roussos changed: What|Removed |Added CC||arouss1...@gmail.com --

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 paxed changed: What|Removed |Added Attachment #94861|0 |1 is obsolete|

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 paxed changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Devinim changed: What|Removed |Added Attachment #99977|0 |1 is obsolete|

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Devinim changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Andreas Roussos changed: What|Removed |Added Attachment #100267|0 |1 is obsolete|

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 --- Comment #6 from Andreas Roussos --- Created attachment 100299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100299&action=edit incorrect display of input field when the ISBN is wrong -- You are receiving thi

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 --- Comment #7 from Andreas Roussos --- Created attachment 100300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100300&action=edit correct display of input field when the ISBN is wrong -- You are receiving this

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Andreas Roussos changed: What|Removed |Added CC||a.rous...@dataly.gr --- C

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 --- Comment #9 from Andreas Roussos --- Created attachment 100301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100301&action=edit Bug 23925: (follow-up) Add missing CSS classes The highlighted input field for an

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Andreas Roussos changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com -- You ar

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are recei

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Michal Denar changed: What|Removed |Added Attachment #100296|0 |1 is obsolete|

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 --- Comment #11 from Michal Denar --- Created attachment 100319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100319&action=edit Bug 23925: (follow-up) Add missing CSS classes The highlighted input field for an i

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Michal Denar changed: What|Removed |Added CC||josef.mora...@gmail.com --

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 --- Comment #13 from Andreas Roussos --- (In reply to Jonathan Druart from comment #12) > "Illegal ISBN" will not be translatable. Hello, Jonathan. Can you elaborate, please? From what I can see Pasi has followed the coding guideline

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 --- Comment #14 from Jonathan Druart --- Hi Andreas, This is not an "embedded javascript" (in .tt). With bug 21156 it is now possible to have translated string in .js, but the function is different. The correct guideline is JS5 (bu

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 --- Comment #15 from Andreas Roussos --- Thanks for your prompt reply, Jonathan. I tried to write a follow-up and replaced the _() with __() However, when I run: cd misc/translator && ./translate update fr-FR Then, none of the file

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 --- Comment #16 from Jonathan Druart --- Ha! Yes! I was wondering why I did not follow-up myself for such simple fix. Actually what needs to be done is: pass an error code to the template, then test it and make the string translata

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 paxed changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|ko

[Koha-bugs] [Bug 23925] Value builder plugin to check ISBN validity

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23925 paxed changed: What|Removed |Added See Also||https://bugs.koha-community