[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Attachment #115203|0 |1 is obsolete|

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #9 from Jonathan Druart --- This is ready for testing :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Attachment #116639|0 |1 is obsolete|

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #11 from Jonathan Druart --- Conflicts with bug 26406 fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@li

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff Attachment

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #14 from Jonathan Druart --- Thanks Séverine, indeed there were a couple of mistakes in the patch. It should work correctly now. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Bug 23991 depends on bug 23590, which changed state. Bug 23590 Summary: Add the ability to change the manager of a suggestion and notify the new manager https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 What

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Attachment #95172|0 |1 is obsolete|

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #5 from Nick Clemens --- Updating suggestions, applying filters all seem to work as expected - the only thing I note is that if I have selected a library on the dropdown above the table and then clear filters on the left

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #6 from Nick Clemens --- Two more things, not necessarily caused by this: 1 - If I add a new suggestion I am returned to the suggestions for that library, but I will be on the first tab (accepted for example), not the pen

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #7 from Jonathan Druart --- (In reply to Nick Clemens from comment #5) > Updating suggestions, applying filters all seem to work as expected - the > only thing I note is that if I have selected a library on the dropdown

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Keywords||rel_22_05_candidate --- C

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Attachment #119256|0 |1 is obsolete|

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #17 from Jonathan Druart --- Patch rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #18 fr

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Attachment #127058|0 |1 is obsolete|

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |BLOCKED --- Comment #20

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Status|BLOCKED |Signed Off Patch comp

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Attachment #127100|0 |1 is obsolete|

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 128072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128072&action=edit Bug 23991: (follow-up) Fix wrong import Signed-off-by: Tomas Cohen Arazi --

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 128073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128073&action=edit Bug 23991: Remove SearchSuggestion tests Signed-off-by: Tomas Cohen Arazi --

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 128074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128074&action=edit Bug 23991: Add Koha::Suggestions->search_limited POD Signed-off-by: Tomas Cohe

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 128075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128075&action=edit Bug 23991: (QA follow-up) Save some DB queries This patch makes the suggestion

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added CC||martin.renvoize@ptfs-eur

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #26 fr

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Depends on||29886 Referenced Bugs:

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Attachment #128072|0 |1 is obsolete|

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Attachment #128073|0 |1 is obsolete|

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Attachment #128074|0 |1 is obsolete|

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Attachment #128075|0 |1 is obsolete|

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Attachment #128071|0 |1 is obsolete|

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 129511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129511&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions The C4::Suggestions::Sea

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 129512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129512&action=edit Bug 23991: Remove SearchSuggestion tests Signed-off-by: Tomas Cohen Arazi --

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 129513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129513&action=edit Bug 23991: (QA follow-up) Save some DB queries This patch makes the suggestion

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #30 from Tomás Cohen Arazi --- Nick, I stripped the Koha::Suggestions->search_limited and moved to 29886. I found issues when writing unit tests for it, and they might be responsible for the problems you found. I have at

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #31 from Jonathan Druart --- Created attachment 129523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129523&action=edit Bug 23991: Fix branchcode and budgetid filtering -- You are receiving this mail

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #34 from Jonathan Druart --- About patch "Bug 23991: (QA follow-up) Save some DB queries". I am not sure about it, I always privileged iterator over retrieving the whole set. If this is what we really want it needs to be

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #35 from Jonathan Druart --- Created attachment 130049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130049&action=edit Bug 23991: Fix conflict with bug 28941 Well, this patchset fixed the security bu

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #36 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #34) > About patch "Bug 23991: (QA follow-up) Save some DB queries". I am not sure > about it, I always privileged iterator over retrieving the whol

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Blocks||23990 Referenced Bugs:

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Depends on||23590 Referenced Bugs:

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #1 from Jonathan Druart --- Created attachment 95172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95172&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions -- You are receiving this m

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #2 from Jonathan Druart --- The hardest part is missing, suggestion/suggestion.pl I will come back to this one later. -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Martin Renvoize changed: What|Removed |Added Attachment #134922|0 |1 is obsolete|

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #57 from Martin Renvoize --- Created attachment 136442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136442&action=edit Bug 23991: (QA follow-up) Fix tabbing It looks like during one of the many rebas

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #58

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Martin Renvoize changed: What|Removed |Added QA Contact|tomasco...@gmail.com|martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Martin Renvoize changed: What|Removed |Added Blocks||31024 Referenced Bugs:

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 release

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #59 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #60 from Jonathan Druart --- Created attachment 137201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137201&action=edit Bug 23991: Don't display empty div if no suggestions exist If no suggestions exi

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed --

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolu

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Katrin Fischer changed: What|Removed |Added Blocks||31158 Referenced Bugs: h

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com ---

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #63 from Katrin Fischer --- Please don't backport until the depending bug 31158 has been resolved. -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #64 from Jonathan Druart --- This change shouldn't be backported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bug

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Victor Grousset/tuxayo changed: What|Removed |Added Blocks||31347 Referenced

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Caroline Cyr La Rose changed: What|Removed |Added Blocks||35911 Referenced Bu

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Caroline Cyr La Rose changed: What|Removed |Added Blocks||35916 Referenced Bu

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Blocks||34963 Referenced Bugs:

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Katrin Fischer changed: What|Removed |Added Blocks||32531 Referenced Bugs: h

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Katrin Fischer changed: What|Removed |Added Blocks||33002 Referenced Bugs: h

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Blocks||33066 Referenced Bugs:

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Agustín Moyano changed: What|Removed |Added Blocks|33066 | Referenced Bugs: https:

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #37 from Jonathan Druart --- Can we get this moving please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@list

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #38 from Nick Clemens --- Created attachment 131896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131896&action=edit Bug 23991: (follow-up) Missing semicolon -- You are receiving this mail because: Y

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #39 fr

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Bug 23991 depends on bug 29886, which changed state. Bug 29886 Summary: Add Koha::Suggestions->search_limited https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29886 What|Removed |Added

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #40 from Jonathan Druart --- Created attachment 132026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132026&action=edit Bug 23991: Fix 'all' libraries -- You are receiving this mail because: You are

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #41 from Jonathan Druart --- (In reply to Nick Clemens from comment #39) > Everything works well, one issue I found: > If I add a new suggestion with acquisition library 'Any' I am returned to > view for logged in branch,

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are recei

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens changed: What|Removed |Added Attachment #129511|0 |1 is obsolete|

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #43 from Nick Clemens --- Created attachment 132170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132170&action=edit Bug 23991: Remove SearchSuggestion tests Signed-off-by: Tomas Cohen Arazi Signed-

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #44 from Nick Clemens --- Created attachment 132171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132171&action=edit Bug 23991: (QA follow-up) Save some DB queries This patch makes the suggestion-rela

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #45 from Nick Clemens --- Created attachment 132172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132172&action=edit Bug 23991: Fix branchcode and budgetid filtering Signed-off-by: Nick Clemens --

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #46 from Nick Clemens --- Created attachment 132173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132173&action=edit Bug 23991: Fix conflict with bug 28941 Well, this patchset fixed the security bug..

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #47 from Nick Clemens --- Created attachment 132174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132174&action=edit Bug 23991: (follow-up) Missing semicolon Signed-off-by: Nick Clemens -- You are

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #48 from Nick Clemens --- Created attachment 132175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132175&action=edit Bug 23991: Fix 'all' libraries Signed-off-by: Nick Clemens -- You are receiving

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #49 from Nick Clemens --- (In reply to Jonathan Druart from comment #41) > I found another weirdness but it's in master as well. > If you have 2 suggestions, branchcodes are 'CPL' and NULL, organize by > "library". > You

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #50 from Tomás Cohen Arazi --- I already tested this one. Will do a second round to check the rebase fixes and Nick's follow-up -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #51 from Katrin Fischer --- (In reply to Nick Clemens from comment #49) > (In reply to Jonathan Druart from comment #41) > > I found another weirdness but it's in master as well. > > If you have 2 suggestions, branchcodes

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #52

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are recei

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #53 from Nick Clemens --- Created attachment 133874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133874&action=edit Bug 23991: (follow-up) Add value to filter_archived -- You are receiving this mail

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are re

  1   2   >