https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Katrin Fischer changed:
What|Removed |Added
Summary|Add system preference to|Add system preference to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Alex Arnaud changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #13 from Alex Arnaud ---
I don't see any unit test that covers changes in the subs RevertWaitingStatus
andset_waiting.
I think t/db_dependent/Reserves.t and t/db_dependent/Hold.t should be updated
to take into account the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #47 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #113284|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #113285|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #27 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #28 from Aleisha Amohia ---
Created attachment 117016
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117016&action=edit
Bug 24194: (follow-up) Renaming syspref to ReserveExpiration
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #29 from Owen Leonard ---
Created attachment 117085
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117085&action=edit
Bug 24194: (follow-up) Correct some missing instances
This patch fixes some instanc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #30 from Owen Leonard ---
Created attachment 117089
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117089&action=edit
Bug 24194: (follow-up) Link references to new preference
As was done in Bug 27263,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
David Nind changed:
What|Removed |Added
Attachment #116626|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
David Nind changed:
What|Removed |Added
Attachment #116627|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
David Nind changed:
What|Removed |Added
Attachment #117016|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
David Nind changed:
What|Removed |Added
Attachment #117085|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
David Nind changed:
What|Removed |Added
Attachment #117089|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
David Nind changed:
What|Removed |Added
Version(s)|This enhancement adds a new |
released in|system pre
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Joonas Kylmälä changed:
What|Removed |Added
Status|Signed Off |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #37 from Joonas Kylmälä ---
(In reply to Joonas Kylmälä from comment #36)
> Also if I'm not mistaken the reason you added ReserveExpiration
> to set_waiting() is because of ReservesMaxPickUpDelay not working really
> well
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #38 from Joonas Kylmälä ---
And for added robustness, you might wanna throw exception if somebody tries to
set the expirationdate field for Koha::Hold.
--
You are receiving this mail because:
You are watching all bug ch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #39 from Aleisha Amohia ---
(In reply to Joonas Kylmälä from comment #36)
> ReserveExpiration should be moved out of set_waiting() method because it
> makes using set_waiting method really confusing because you are really
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #117097|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #117098|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #117099|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #117100|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #117101|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #45 from Aleisha Amohia ---
Created attachment 118263
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118263&action=edit
Bug 24194: (follow-up) Use ReservesExpiration in other places
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #46 from Joonas Kylmälä ---
(In reply to Aleisha Amohia from comment #39)
> (In reply to Joonas Kylmälä from comment #36)
> > ReserveExpiration should be moved out of set_waiting() method because it
> > makes using set_wa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #100927|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Version(s)||This enhancement adds a new
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
David Nind changed:
What|Removed |Added
Attachment #110082|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #16 from David Nind ---
Hi Aleisha.
Everything worked for me a per the test plan, and the tests passed, so I have
signed off.
Just a couple of things I noted, which are probably more for the QA team than
me 8-) :
- Eve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #17 from Katrin Fischer ---
Comment on attachment 110127
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110127
Bug 24194: Add DisableReserveExpiration system preference to hide expiration
date options f
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Katrin Fischer changed:
What|Removed |Added
Attachment #110127|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Katrin Fischer changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #111443|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #20 from Aleisha Amohia ---
Created attachment 113285
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113285&action=edit
Bug 24914: (follow-up) Clarifying sysprefs, hiding columns, and more
- change sys
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolin.som...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #22 from Aleisha Amohia ---
(In reply to Fridolin Somers from comment #21)
> Regarding to terminology https://wiki.koha-community.org/wiki/Terminology
> We prefer hold instead of reserve.
>
> New preference should be nam
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #23 from Fridolin Somers ---
Ok super ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.or
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
David Nind changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #118258|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #118259|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #118260|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #118261|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #118262|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #118263|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #54 from Aleisha Amohia ---
Created attachment 128307
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128307&action=edit
Bug 24194: (follow-up) Use ExpireReservesMaxPickUpDelay when setting hold
waiting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #55 from Aleisha Amohia ---
Created attachment 128308
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128308&action=edit
Bug 24194: (follow-up) Throw an error if expiration date used
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #150799|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #150800|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Owen Leonard changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Owen Leonard changed:
What|Removed |Added
Attachment #159060|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #70 from Owen Leonard ---
Created attachment 167797
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167797&action=edit
Bug 24194: (follow-up) Throw an error if expiration date used
Signed-off-by: Nicola
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Owen Leonard changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #71 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Kyle M Hall changed:
What|Removed |Added
QA Contact|k...@bywatersolutions.com |testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Kyle M Hall changed:
What|Removed |Added
Attachment #144076|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Kyle M Hall changed:
What|Removed |Added
Attachment #140646|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Kyle M Hall changed:
What|Removed |Added
Attachment #140647|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
--
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #140646|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #140647|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #128301|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #128308|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #128302|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #128303|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #128304|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #128305|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #128306|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Aleisha Amohia changed:
What|Removed |Added
Attachment #128307|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Laura changed:
What|Removed |Added
CC||Laura.escamilla@bywatersolu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Laura changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Laura changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #58 from Lau
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Kyle M Hall changed:
What|Removed |Added
Attachment #140646|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Marjorie Barry-Vila changed:
What|Removed |Added
CC||marjorie.barry-vila@co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Nicolas Giraud changed:
What|Removed |Added
Attachment #147527|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Nicolas Giraud changed:
What|Removed |Added
Attachment #147528|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #64 from David Nind ---
Hi Nicolas.
Since you have signed off, you should change the status to Signed Off.
That way you will get credit on the dashboard
(https://dashboard.koha-community.org/).
David
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Nicolas Giraud changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #65 from Nicolas Giraud ---
Hi David,
I've just modified it, sorry !
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #66 from David Nind ---
No problem! We all do this every now and again.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
--- Comment #72 from Chris Cormack ---
Created attachment 169174
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169174&action=edit
Bug 24194: Making the qa script happy
Tidied up a bunch there are still a couple o
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Chris Cormack changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194
Koha collecto changed:
What|Removed |Added
CC||k...@collecto.ca
--
You ar
99 matches
Mail list logo