https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Status|Pushed to master|RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Bug 24300 depends on bug 27967, which changed state.
Bug 27967 Summary: Modals on the borrower account page don't validate minimum
values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27967
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Bug 24300 depends on bug 27927, which changed state.
Bug 27927 Summary: longoverdue cronjob renews items before marking lost when
both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #50 from Jonathan Druart
---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #119200|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #119199|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #119197|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #119198|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #119196|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #119195|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Status|BLOCKED |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |BLOCKED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #42 from Martin Renvoize ---
Tree re-arranged slightly to put bugs that need backporting before these
enhancements that don't.
Rebased to accommodate the above.
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #118612|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #118605|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #118604|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #118603|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #118602|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #118601|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Depends on||27927
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #118606|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #34 from Tomás Cohen Arazi ---
Created attachment 118606
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118606=edit
Bug 24300: (QA follow-up) Enhance test and catch failures
The tests did not include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #33 from Tomás Cohen Arazi ---
Created attachment 118605
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118605=edit
Bug 24300: (QA follow-up) Update payout_amount to use internal methods
Tomas pointed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #32 from Tomás Cohen Arazi ---
Created attachment 118604
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118604=edit
Bug 24300: (follow-up) Set minimum for amount input
Add a 'min' attribute for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #31 from Tomás Cohen Arazi ---
Created attachment 118603
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118603=edit
Bug 24300: (QA follow-up) Add Unit Tests
Doh! I forgot the unit tests first time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #30 from Tomás Cohen Arazi ---
Created attachment 118602
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118602=edit
Bug 24300: Add payout amount to boraccount page
Test plan
1/ Add some debts and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #29 from Tomás Cohen Arazi ---
Created attachment 118601
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118601=edit
Bug 24300: Add payout_amount method to Koha::Account
This patch adds a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #118396|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #118395|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #118394|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #118393|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #118392|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #118503|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #118464|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Blocks|27636 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Blocks||27971
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Blocks|22435 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Blocks||27636
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Blocks||22435
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Blocks|27967 |
Depends on|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #27 from Martin Renvoize ---
Created attachment 118464
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118464=edit
Bug 24300: (QA follow-up) Enhance test and catch failures
The tests did not include
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #26 from Martin Renvoize ---
(In reply to Martin Renvoize from comment #25)
> Oop, just found a bug in that final QA followup
And.. I realised I'd missed tests for offset creations too..
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |ASSIGNED
--- Comment #25
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #24 from Tomás Cohen Arazi ---
(In reply to Martin Renvoize from comment #22)
> I took the liberty of attaching the patches with Tomas's SO lines ;)
Thanks! You saved me some time!
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #23 from Tomás Cohen Arazi ---
(In reply to Owen Leonard from comment #16)
> Tomás I think you forgot to add the signed-off patches
You are right!
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #22 from Martin Renvoize ---
I took the liberty of attaching the patches with Tomas's SO lines ;)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #21 from Martin Renvoize ---
Created attachment 118396
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118396=edit
Bug 24300: (QA follow-up) Update payout_amount to use internal methods
Tomas pointed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #20 from Martin Renvoize ---
Created attachment 118395
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118395=edit
Bug 24300: (follow-up) Set minimum for amount input
Add a 'min' attribute for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #19 from Martin Renvoize ---
Created attachment 118394
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118394=edit
Bug 24300: (QA follow-up) Add Unit Tests
Doh! I forgot the unit tests first time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #18 from Martin Renvoize ---
Created attachment 118393
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118393=edit
Bug 24300: Add payout amount to boraccount page
Test plan
1/ Add some debts and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #17 from Martin Renvoize ---
Created attachment 118392
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118392=edit
Bug 24300: Add payout_amount method to Koha::Account
This patch adds a 'payout_amount'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #16 from Owen Leonard ---
Tomás I think you forgot to add the signed-off patches
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #15 from Tomás Cohen Arazi ---
Works as expected. Tests pass. My QA concerns were promptly addressed by the
follow-up. QA script happy.
Good job
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #117919|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #117918|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #117917|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #118335|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Blocks|22435 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Blocks||27967
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #14 from Martin Renvoize ---
Created attachment 118335
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118335=edit
Bug 24300: (follow-up) Set minimum for amount input
Add a 'min' attribute for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Keywords|release-notes-needed|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Text to go in the||This enhancement adds a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #13 from Martin Renvoize ---
Created attachment 117919
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117919=edit
Bug 24300: (QA follow-up) Add Unit Tests
Doh! I forgot the unit tests first time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #116838|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #116837|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #10 from Martin Renvoize ---
(In reply to Katrin Fischer from comment #9)
> Hi Martin, please add unit tests!
Dang, how did I forget that!..
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Katrin Fischer changed:
What|Removed |Added
Keywords||release-notes-needed
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #9
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Sally changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #8 from Sally ---
Patch works as described.
An account being more in debt is ok - there are sometimes circumstances where a
patron might owe money, but they also need a refund for an unrelated
transaction.
With that in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
ByWater Sandboxes changed:
What|Removed |Added
Attachment #116413|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
ByWater Sandboxes changed:
What|Removed |Added
Attachment #116412|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #5 from Martin Renvoize ---
This will need some unit tests adding for QA, but it's ready for an initial
testing phase.
I'm not entirely sure I like how it works.. at the moment you can payout prior
to paying off debts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #4 from Martin Renvoize ---
Created attachment 116413
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116413=edit
Bug 24300: Add payout amount to boraccount page
Test plan
1/ Add some debts and credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Attachment #116395|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #2 from Martin Renvoize ---
Created attachment 116395
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116395=edit
Bug 24300: Add payout_amount method to Koha::Account
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Blocks|17596 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
--- Comment #1 from Martin Renvoize ---
I'm thinking of adding a payout_amount method within Koha::Account that does
similar to the offset_amount method I'm looking to add in bug 27636 but in the
reverse direction.. i.e. it adds a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Blocks||22435
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Bug 24300 depends on bug 24080, which changed state.
Bug 24080 Summary: Add a 'payout' process to accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080
What|Removed |Added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Blocks|14825 |17596
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Blocks||14825
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Martin Renvoize changed:
What|Removed |Added
Depends on||24080
Referenced Bugs:
96 matches
Mail list logo