https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to master|RESOLVED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Fridolin Somers changed:
What|Removed |Added
Blocks||35064
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Fridolin Somers changed:
What|Removed |Added
Blocks||34332
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Bug 24381 depends on bug 26689, which changed state.
Bug 26689 Summary: Monetary accounts notices should be definable at the
credit_type/debit_type level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26689
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
mathieu saby changed:
What|Removed |Added
CC||mathsaby...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #80 from Lucas Gass ---
Patchset won't apply cleanly to 22.05.x, no backport
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #79 from Tomás Cohen Arazi ---
Pushed to master for 22.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #78 from Kyle M Hall ---
Created attachment 142390
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142390=edit
Bug 24381: (follow-up) Add USE statements
Signed-off-by: Lucas Gass
Signed-off-by: Kyle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #77 from Kyle M Hall ---
Created attachment 142389
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142389=edit
Bug 24381: (follow-up) Notice improvements
Signed-off-by: Lucas Gass
Signed-off-by: Kyle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #76 from Kyle M Hall ---
Created attachment 142388
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142388=edit
Bug 24381: Update notice params
If the update to catch defaults fails, we need to attempt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #75 from Kyle M Hall ---
Created attachment 142387
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142387=edit
Bug 24381: Update notices if defaults used
Signed-off-by: Kyle M Hall
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Kyle M Hall changed:
What|Removed |Added
Attachment #141619|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #73 from Lucas Gass ---
Thanks for this one Martin. It will make a lot of librarians happy. :)
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Lucas Gass changed:
What|Removed |Added
Attachment #140873|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Lucas Gass changed:
What|Removed |Added
Attachment #140871|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Lucas Gass changed:
What|Removed |Added
Attachment #140870|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Lucas Gass changed:
What|Removed |Added
Attachment #140869|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Lucas Gass changed:
What|Removed |Added
Attachment #140868|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Lucas Gass changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #66 from Martin Renvoize ---
I've obsoleted another of the patches that Nick rebased as it's already done in
bug 26734...
This is another case of a bug loosing momentum due to a distinct lack of
testing at the time and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #140872|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Lucas Gass changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #65
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #64 from Nick Clemens ---
I dropped the first patch, it seemed to have been done already, updated the
others slightly, worked in brief testing
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #63 from Nick Clemens ---
Created attachment 140873
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140873=edit
Bug 24381: (follow-up) Add USE statements
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #62 from Nick Clemens ---
Created attachment 140872
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140872=edit
Bug 24381: Convert printfeercpt to use GetPreparedLetter
This patch updates C4::Letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #61 from Nick Clemens ---
Created attachment 140871
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140871=edit
Bug 24381: (follow-up) Notice improvements
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #60 from Nick Clemens ---
Created attachment 140870
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140870=edit
Bug 24381: Update notice params
If the update to catch defaults fails, we need to attempt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #59 from Nick Clemens ---
Created attachment 140869
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140869=edit
Bug 24381: Update notices if defaults used
Signed-off-by: Kyle M Hall
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Nick Clemens changed:
What|Removed |Added
Attachment #111590|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Lucas Gass changed:
What|Removed |Added
Status|BLOCKED |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Depends on|22761 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Depends on|26398 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #116394|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #56 from Martin Renvoize ---
Created attachment 116394
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116394=edit
Bug 24381: Add payout_amount method to Koha::Account
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #55 from Martin Renvoize ---
People seemed to generally lose interest in this.. :(.. the work moved to bug
26734 to split it into sensible parts as the code here ended up very customised
for each case instead of using a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |BLOCKED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Depends on|26734 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Depends on||26734
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Blocks|26689 |
Depends on|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Blocks||26689
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #54 from Martin Renvoize ---
OK, back to NSO.. that final followup is a proof of concept for converting the
first slip to use GetPreparedLetter as aposed to calling getletter directly and
then parting the evaluating the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #111534|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #111533|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #53 from Martin Renvoize ---
Created attachment 111595
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111595=edit
Bug 24381: Convert printfeercpt to use GetPreparedLetter
This patch updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #111532|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #111531|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #111530|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #47 from Martin Renvoize ---
As an additional note, whilst working on the templates I noticed that the [%
today %] substitution doesn't work in this notice as it does elsewhere..
After a discussion with Jonathan, we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Joonas Kylmälä changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Blocks||14825
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #45 from Martin Renvoize ---
To Test
The updated templates are used for a plethora of different cases and I'd like
some feedback as to whether they're an improvement for each.
ACCOUNT_DEBIT
* This one is used for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #44 from Martin Renvoize ---
Created attachment 111534
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111534=edit
Bug 24381: (follow-up) Notice improvements
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #110462|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #110464|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #110463|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #110461|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #39 from Martin Renvoize ---
(In reply to Joonas Kylmälä from comment #38)
> Before this patch on koha-testing-docker if I add two manual fees and click
> on the print button on either one of the fees then it shows that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Depends on||26398
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Depends on|26418 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Depends on||26418
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Joonas Kylmälä changed:
What|Removed |Added
CC||joonas.kylm...@helsinki.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Kyle M Hall changed:
What|Removed |Added
Attachment #110210|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #37 from Kyle M Hall ---
Created attachment 110464
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110464=edit
Bug 24381: Update notice params
If the update to catch defaults fails, we need to attempt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #36 from Kyle M Hall ---
Created attachment 110463
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110463=edit
Bug 24381: Update notices if defaults used
Signed-off-by: Kyle M Hall
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #35 from Kyle M Hall ---
Created attachment 110462
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110462=edit
Bug 24381: Update sample notices
This patch update the sample notices for new installs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #106976|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #106977|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #106975|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #106974|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
--- Comment #28 from Martin Renvoize ---
Test plan
Fresh Install
1/ Install a koha fresh and allow the sample notices to be installed
2/ Create some debits on a patrons account
3/ 'Print' the debit and verify the print works and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #106959|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #106960|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #106958|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Attachment #106957|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
Martin Renvoize changed:
What|Removed |Added
Summary|ACCOUNT_CREDIT slip not |ACCOUNT_CREDIT and
88 matches
Mail list logo