https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Nick Clemens changed:
What|Removed |Added
Blocks||29792
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Kyle M Hall changed:
What|Removed |Added
Version(s)|21.11.00|21.11.00,21.05.01
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #69 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Jonathan Druart changed:
What|Removed |Added
Version(s)||21.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Jonathan Druart changed:
What|Removed |Added
Attachment #121804|Bug 24434: (QA follow-up) |Bug 24434: (QA follow-up)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #68 from Jonathan Druart ---
(In reply to Kyle M Hall from comment #65)
> Created attachment 121804 [details] [review]
> Bug 24434: (QA follow-up) Remove tab character
>
> Signed-off-by: Kyle M Hall
Patch will be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #67 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #66)
> This patchset conflicts with bug 28520, I cannot apply both of them.
> Can you add a dependency and fix the conflict please?
> (adding the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Joonas Kylmälä changed:
What|Removed |Added
Blocks||28520
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #66 from Jonathan Druart ---
This patchset conflicts with bug 28520, I cannot apply both of them.
Can you add a dependency and fix the conflict please?
(adding the same comment there)
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Jonathan Druart changed:
What|Removed |Added
Patch complexity|Small patch |Medium patch
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #65 from Kyle M Hall ---
Created attachment 121804
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121804=edit
Bug 24434: (QA follow-up) Remove tab character
Signed-off-by: Kyle M Hall
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #64 from Kyle M Hall ---
Created attachment 121803
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121803=edit
Bug 24434: DBIC Update
Signed-off-by: Kyle M Hall
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #63 from Kyle M Hall ---
Created attachment 121802
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121802=edit
Bug 24434: Add 'WrongTransfer' to cancellation_reasons
Signed-off-by: Victor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #62 from Kyle M Hall ---
Created attachment 121801
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121801=edit
Bug 24434: Submit on print slip
This patch ensures that the print slip option on the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #61 from Kyle M Hall ---
Created attachment 121800
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121800=edit
Bug 24434: Unit tests for updateWrongTransfer
Add unit tests to cover updateWrongTransfer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #60 from Kyle M Hall ---
Created attachment 121799
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121799=edit
Bug 24434: Add Unit Tests for relations
This patch adds unit tests for the newly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Kyle M Hall changed:
What|Removed |Added
Attachment #121702|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #58 from Martin Renvoize ---
Minor rebase, and added the DBIC update patch in case that's what Kyle was
missing ;)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #57 from Martin Renvoize ---
Created attachment 121707
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121707=edit
Bug 24434: DBIC Update
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #121515|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #121075|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #121074|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #121073|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #121071|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Severity|major |critical
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #50 from Victor Grousset/tuxayo ---
(In reply to Kyle M Hall from comment #47)
> 5) Get the error "The reason parameter is mandatory at
> /usr/share/perl5/Exception/Class/Base.pm line 88"
I can't reproduce the error. I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #49 from Victor Grousset/tuxayo ---
Rebased a patch that had a small conflict.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #121072|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #47
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Kyle M Hall changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Severity|normal |major
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_21_05_candidate |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #46 from Victor Grousset/tuxayo ---
Test notes: run the tests
- apply only the test patches
- prove t/db_dependent/Koha/Item/Transfer.t t/db_dependent/Circulation.t
- it should fail
- apply the other patches
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #121061|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #121060|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #121059|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #121058|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #121057|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Blocks|22160 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #121034|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #121032|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #121031|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #121030|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #121029|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #121033|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #32 from Martin Renvoize ---
Created attachment 121033
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121033=edit
Bug 24434: Submit on print slip
This patch ensures that the print slip option on the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #120758|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #120757|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #120684|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #120683|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #27
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #26 from Martin Renvoize ---
Created attachment 120758
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120758=edit
Bug 24434: Unit tests for updateWrongTransfer
Add unit tests to cover
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #25 from Martin Renvoize ---
Created attachment 120757
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120757=edit
Bug 24434: Add Unit Tests for relations
This patch adds unit tests for the newly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Jonathan Druart changed:
What|Removed |Added
Keywords||rel_21_05_candidate
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #120658|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #120657|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #20 from Martin Renvoize ---
Hold off on testing.. I think I've found a bug in the process linked to the
'Cancel' option now... working on a followup
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #19 from Martin Renvoize ---
(In reply to Sally from comment #16)
> Hi Martin,
>
> This works if I use the 'OK' button, but it fails if I use the 'Print
> transfer slip' button.
>
> As the item is moving between
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #120632|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #120631|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Sally changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #16 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Severity|minor |normal
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #15 from Martin Renvoize ---
Created attachment 120632
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120632=edit
Bug 24434: Add 'WrongTransfer' to cancellation_reasons
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #120625|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Patch complexity|Trivial patch |Small patch
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Status|BLOCKED |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Attachment #99829|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Summary|C4::Circulation::updateWron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #13 from Martin Renvoize ---
Created attachment 120625
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120625=edit
Bug 24434: Reinstate updateWrongTransfer
This patch re-instates the call to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Blocks||28294
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Severity|enhancement |minor
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #12 from Martin Renvoize ---
OK, I've now discovered the issue here.. or rather a customer whose recently
upgraded has.
Test plan
1/ Check an item out from it's home library
2/ Check the item in at another library (with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #11 from Martin Renvoize ---
Having now delved through transfers.. I'm still confused by this one. :S
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #10 from Martin Renvoize ---
I'm in agreement with Jonathan here.. I think we need a deeper investigation
into how/where these variable were removed in the first place.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |BLOCKED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #8 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #7)
> Created attachment 99829 [details] [review]
> Bug 24434: Remove updateWrongTransfer
>
> This patch simply removes the unused
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Katrin Fischer changed:
What|Removed |Added
Attachment #97550|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Blocks||22160
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Blocks|24298 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #6 from Jonathan Druart
---
The template passed the variable (WT-itemNumber) to the script:
-
-
-
commit 5ed171a45c46f63b18266ad3a3d0a978719ca285
Bug 21346: Convert dialogs to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #5 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > WT-itemNumber, WT-waitingAt and WT-From have been removed from returns.tt
> > by:
> >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
--- Comment #4 from Jonathan Druart
---
(In reply to Jonathan Druart from comment #3)
> WT-itemNumber, WT-waitingAt and WT-From have been removed from returns.tt by:
> commit 5ed171a45c46f63b18266ad3a3d0a978719ca285
> Bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Jonathan Druart changed:
What|Removed |Added
Depends on||21346
--- Comment #3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Kyle M Hall changed:
What|Removed |Added
Attachment #97449|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Kyle M Hall changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
Patch complexity|--- |Trivial patch
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
Martin Renvoize changed:
What|Removed |Added
CC|
1 - 100 of 104 matches
Mail list logo