[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2020-02-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org --

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2020-04-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Jessie Zairo changed: What|Removed |Added CC||jza...@bywatersolutions.com

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2023-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|Needs documenting

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2023-09-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Jonathan Druart changed: What|Removed |Added Blocks||34844 Referenced Bugs:

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-12-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Caroline Cyr La Rose changed: What|Removed |Added Documentation||https://gitlab.com/ko

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are rec

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #1 from Kyle M Hall --- Created attachment 141613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141613&action=edit Bug 24606: Update database, add new schema file -- You are receiving this mail becau

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #2 from Kyle M Hall --- Created attachment 141614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141614&action=edit Bug 24606: Add Koha Object(s) with unit tests -- You are receiving this mail because

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #3 from Kyle M Hall --- Created attachment 141615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141615&action=edit Bug 24606: Update existing schema files [DO NOT PUSH] -- You are receiving this mail

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #4 from Kyle M Hall --- Created attachment 141616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141616&action=edit Bug 24606: Implement item templates This patch set implements item editor templates f

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #5 from Kyle M Hall --- Created attachment 141617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141617&action=edit Bug 24606: Add item template editor permission -- You are receiving this mail becaus

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are rec

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Kyle M Hall changed: What|Removed |Added Attachment #141613|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #8 from Kyle M Hall --- Created attachment 141718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141718&action=edit Bug 24606: Add Koha Object(s) with unit tests -- You are receiving this mail because

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #9 from Kyle M Hall --- Created attachment 141719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141719&action=edit Bug 24606: Implement item templates This patch set implements item editor templates f

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #10 from Kyle M Hall --- Created attachment 141720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141720&action=edit Bug 24606: Add item template editor permission -- You are receiving this mail becau

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #11 from Kyle M Hall --- Created attachment 141721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141721&action=edit Bug 24606: Update existing schema files [DO NOT PUSH] -- You are receiving this mai

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #12 from David Nind --- The only thing I noticed is around editing and updating an already shared template. If you are not the creator, and you can have manage_item_editor_templates permissions, if you don't select 'Shar

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #13 from Kyle M Hall --- Good catch! I'll get that fixed asap! Kyle (In reply to David Nind from comment #12) > The only thing I noticed is around editing and updating an already shared > template. > > If you are not t

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #14 from Kyle M Hall --- Created attachment 141972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141972&action=edit Bug 24606: (QA follow-up) Set existing sharing setting when updating existing templat

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivi

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What|Removed |Added Attachment #141717|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What|Removed |Added Attachment #141718|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What|Removed |Added Attachment #141719|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What|Removed |Added Attachment #141720|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What|Removed |Added Attachment #141721|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 David Nind changed: What|Removed |Added Attachment #141972|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #21

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiv

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #22 from Kyle M Hall --- Created attachment 142833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142833&action=edit Bug 24606: (QA follow-up) Fix QA script issues -- You are receiving this mail becau

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #23 from Kyle M Hall --- Created attachment 142834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142834&action=edit Bug 24606: (QA follow-up) Update js message translation style -- You are receiving

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #24 from Kyle M Hall --- Created attachment 142835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142835&action=edit Bug 24606: (QA follow-up) Fix up interface -- You are receiving this mail because:

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #25 from Kyle M Hall --- Created attachment 142836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142836&action=edit Bug 24606: (QA follow-up) Hide button when using multi-add -- You are receiving thi

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #26 from Kyle M Hall --- Created attachment 142837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142837&action=edit Bug 24606: (QA follow-up) Disable 'Apply template' button if no template is selected

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #27 from Kyle M Hall --- (In reply to Katrin Fischer from comment #21) > 1) QA test tools: Fixed with followup! > 2) Why the sub in cataloguing/additem.pl instead of a module? To remain consistent with how this script

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #28 from Katrin Fischer --- Back here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Medium patch S

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Attachment #142003|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Attachment #142004|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Attachment #142005|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Attachment #142006|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Attachment #142007|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Attachment #142008|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Attachment #142833|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Attachment #142834|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Attachment #142835|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Attachment #142836|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Attachment #142837|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #40 from Katrin Fischer --- Created attachment 142888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142888&action=edit Bug 24606: (QA follow-up) Remove string variable This string is no longer needed

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #41 from Katrin Fischer --- I think this a nice addition and have passed QA on this. BUT: The GUI still needs a little bit more work, so this can shine on release: https://snipboard.io/IaM4VW.jpg I noticed that it rel

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #42 from Kyle M Hall --- Created attachment 143020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143020&action=edit Bug 24606: (QA follow-up) Fix up save form a bit -- You are receiving this mail bec

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Patch doesn't apply

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receivi

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Kyle M Hall changed: What|Removed |Added Attachment #142877|0 |1 is obsolete|

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #44 from Kyle M Hall --- Created attachment 143570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143570&action=edit Bug 24606: Add Koha Object(s) with unit tests Signed-off-by: David Nind Signed-off

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #45 from Kyle M Hall --- Created attachment 143571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143571&action=edit Bug 24606: Implement item templates This patch set implements item editor templates

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #46 from Kyle M Hall --- Created attachment 143572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143572&action=edit Bug 24606: Add item template editor permission Signed-off-by: David Nind Signed-of

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #47 from Kyle M Hall --- Created attachment 143573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143573&action=edit Bug 24606: (QA follow-up) Set existing sharing setting when updating existing templat

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #48 from Kyle M Hall --- Created attachment 143574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143574&action=edit Bug 24606: (QA follow-up) Fix QA script issues Signed-off-by: Katrin Fischer -- Y

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #49 from Kyle M Hall --- Created attachment 143575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143575&action=edit Bug 24606: (QA follow-up) Update js message translation style Signed-off-by: Katrin

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #50 from Kyle M Hall --- Created attachment 143576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143576&action=edit Bug 24606: (QA follow-up) Fix up interface Signed-off-by: Katrin Fischer -- You a

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #51 from Kyle M Hall --- Created attachment 143577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143577&action=edit Bug 24606: (QA follow-up) Hide button when using multi-add Signed-off-by: Katrin Fis

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #52 from Kyle M Hall --- Created attachment 143578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143578&action=edit Bug 24606: (QA follow-up) Disable 'Apply template' button if no template is selected

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #53 from Kyle M Hall --- Created attachment 143579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143579&action=edit Bug 24606: (QA follow-up) Remove string variable This string is no longer needed as

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #54 from Kyle M Hall --- Created attachment 143580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143580&action=edit Bug 24606: (QA follow-up) Fix up save form a bit -- You are receiving this mail bec

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #55 from Kyle M Hall --- Created attachment 143581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143581&action=edit Bug 24606: Update existing schema files [DO NOT PUSH] -- You are receiving this mai

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #56 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #58 from Jonathan Druart --- Use statements appear twice +use URI::Escape qw( uri_escape_utf8 ); +use URI::Escape qw( uri_escape_utf8 ); -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #59 from Jonathan Druart --- There is an encoding issue when you are applying a template that has ♥ in one of its subfield Wide character in subroutine entry at /kohadevbox/koha/Koha/Item/Template.pm line 58 in Koha

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #60 from Tomás Cohen Arazi --- Created attachment 143794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143794&action=edit Bug 24606: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are rec

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #61 from Tomás Cohen Arazi --- Created attachment 143795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143795&action=edit Bug 24606: Fix encoding issues on decoded content This patch makes the `decode

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #62 from Tomás Cohen Arazi --- Created attachment 143796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143796&action=edit Bug 24606: (QA follow-up) Remove duplicate include -- You are receiving this

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #63 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #58) > Use statements appear twice > +use URI::Escape qw( uri_escape_utf8 ); > +use URI::Escape qw( uri_escape_utf8 ); Done. (In reply to Jonathan

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #64 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #57) > https://snipboard.io/0uEloj.jpg - shouldn't we hide if there is no template > defined? Kyle, this is not strictly a blocker, but we really n

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Blocks||32188 Referenced Bugs: h

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #65 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #64) > (In reply to Jonathan Druart from comment #57) > > https://snipboard.io/0uEloj.jpg - shouldn't we hide if there is no template > > defined? >

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed -- Y

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #66 from Marcel de Rooy --- The following follow-up looks highly arguable to me: Bug 24606: Fix encoding issues on decoded content -return decode_json( $self->contents ) if $self->contents; +return decode_json(

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #67 from Marcel de Rooy --- And we should encode/decode in the middle of the process. And we should NOT -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #68 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #66) > What does practically mean? > You should switch from using decode_json and encode_json TO from_json and > to_json. Leave the strings in Perl i

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #69 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #66) > encode_json Converts the given Perl data structure to a UTF-8 encoded, > binary string. > to_json Converts the given Perl data structure to a

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #70 from Jonathan Druart --- We are using a cookie when localStorage should be used, see bug 12410. -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #71 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #69) > (In reply to Marcel de Rooy from comment #66) > > encode_json Converts the given Perl data structure to a UTF-8 encoded, > > binary string. >

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed --

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #72 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #68) > The docs and you say the same: decode_json expects to be passed a string > with Perl's internal format representing UTF-8 characters. And that

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #73 from Marcel de Rooy --- The correct pattern is in BackgroundJob: sub decoded_data { my ($self) = @_; return $self->data ? $self->json->decode( $self->data ) : undef; } sub set_encoded_data { my ( $self,

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #74 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #69) > This module also exports to_json and from_json for backward compatibility. > These are slower Thats true. We should switch to OO interface.

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #75 from Marcel de Rooy --- From Backgrount too sub json { my ( $self ) = @_; $self->{_json} //= JSON->new->utf8(0); # TODO Should we allow_nonref ? return $self->{_json}; } I remember that you were objectin

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #76 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #71) > [2022/11/17 06:44:05] [WARN] The job has not been sent to the message > broker: (Wide character in syswrite at > /usr/lib/x86_64-linux-gnu/perl-

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #77 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #76) > (In reply to Jonathan Druart from comment #71) > > [2022/11/17 06:44:05] [WARN] The job has not been sent to the message > > broker: (Wide chara

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #78 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #77) > (In reply to Marcel de Rooy from comment #76) > > (In reply to Jonathan Druart from comment #71) > > > [2022/11/17 06:44:05] [WARN] The job has

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #79 from Jonathan Druart --- For the record, my comments didn't make sense. I hadn't noticed that Tomas was not modifying Koha::BackgroundJob. -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #80 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #78) > (In reply to Jonathan Druart from comment #77) > > (In reply to Marcel de Rooy from comment #76) > > > (In reply to Jonathan Druart from comment

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #81 from Marcel de Rooy --- Opened bug 32242 for the Background issue now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 24606] Allow storing item values as a template for creating new items

2022-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24606 --- Comment #82 from Marcel de Rooy --- Tomás: I will add a patch here for your consideration now. (By way of exception :) -- You are receiving this mail because: You are watching all bug changes. __

  1   2   >