https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #32 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Marcel de Rooy changed:
What|Removed |Added
Blocks||29412
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #31 from Marcel de Rooy ---
(In reply to Katrin Fischer from comment #30)
> I've been bitten by Koha assuming years are after 1000 for the date range
> search in the past - might be nice to tackle separately. When
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #30 from Katrin Fischer ---
I've been bitten by Koha assuming years are after 1000 for the date range
search in the past - might be nice to tackle separately. When dealing with rare
items and manuscripts < 1000 is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #29 from Marcel de Rooy ---
Try this:
use Modern::Perl;
use Data::Dumper qw/Dumper/;
use C4::Biblio;
print C4::Biblio::_adjust_pubyear('2xx');
19.11 => 2000
master (without this patch) => Use of uninitialized value in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #28 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #27)
> (In reply to Jonathan Druart from comment #26)
> > Is that correct to assume that nothing has been published before year 1000?
>
> Certainly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #27 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #26)
> Is that correct to assume that nothing has been published before year 1000?
Certainly not :) But thats really an negligible edge case here.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #26 from Jonathan Druart ---
Is that correct to assume that nothing has been published before year 1000?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Marcel de Rooy changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Katrin Fischer changed:
What|Removed |Added
Attachment #125110|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Katrin Fischer changed:
What|Removed |Added
Attachment #125109|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Katrin Fischer changed:
What|Removed |Added
Attachment #125108|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #22 from Marcel de Rooy ---
You might be surprised what you find if you look for copyrightdate>0 and
copyrightdate<1000 in your local catalogue..
You could use this in a where statement with touch_all_biblios
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #21 from Marcel de Rooy ---
Created attachment 125110
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125110=edit
Bug 24674: (follow-up) Simpler regex
The 'Polish notation' actually simplifies things.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Marcel de Rooy changed:
What|Removed |Added
Attachment #99186|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Marcel de Rooy changed:
What|Removed |Added
Attachment #99173|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #18 from Marcel de Rooy ---
(In reply to Janusz Kaczmarek from comment #2)
> In addition, in Poland a form with only one dash is quite common, like YY-
> (== YY--).
With reference to former comment, this form is not in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #17 from Marcel de Rooy ---
(In reply to Katrin Fischer from comment #8)
> 1999- = 1999
> 1999-2009 = 1999
> 19xx (very common here) = NULL
This observation seems to be incorrect. The code does this:
19xx = 1900
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff |BLOCKED
--- Comment #16
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #15 from Marcel de Rooy ---
From bug 11046:
This part of the regex made me wonder:
(?\d)[-]?[.Xx?]{3}
What does the minus do here after the first digit? Do we allow 1-234 or so?
Looking at the above, this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Séverine Queune changed:
What|Removed |Added
CC||severine.que...@bulac.fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Fridolin SOMERS changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Katrin Fischer changed:
What|Removed |Added
CC||ke...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #12 from Katrin Fischer ---
(In reply to Janusz Kaczmarek from comment #11)
> But guess what will be displayed in this real life example:
>
> Warszawa : Universitas, [19]89-.
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #11 from Janusz Kaczmarek ---
But guess what will be displayed in this real life example:
Warszawa : Universitas, [19]89-.
http://katalog.nukat.edu.pl/lib/item?id=chamo:22190=false=nukat
BTW, I'm wondering why, in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #10 from Janusz Kaczmarek ---
(In reply to Katrin Fischer from comment #8)
> I am wondering if this could be confusing to users as we display the
> information from publicationyear/copyrightdate in quite a lot of places.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #9 from Janusz Kaczmarek ---
(In reply to Jonathan Druart from comment #7)
> I adjusted the failing tests and add some more. I do not know if we need to
> adjust the year only if surrounded by square brackets.
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #8 from Katrin Fischer ---
I am wondering if this could be confusing to users as we display the
information from publicationyear/copyrightdate in quite a lot of places. We
just recently looked into the logic here too:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #7 from Jonathan Druart
---
I adjusted the failing tests and add some more. I do not know if we need to
adjust the year only if surrounded by square brackets.
Letting someone else to signoff in order to get another
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Jonathan Druart changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #6 from Jonathan Druart
---
Created attachment 99186
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99186=edit
Bug 24674: Adjust tests and add new ones to cover changes
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Jonathan Druart changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Janusz Kaczmarek changed:
What|Removed |Added
Status|Failed QA |In Discussion
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Jonathan Druart changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
--- Comment #3 from Janusz Kaczmarek ---
Test plan:
o put a date like [198-] or [18--] or [17-] in 260 $c and save the record
o check the error log -- you should see something like:
Argument "[198-]." isn't numeric in int at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Janusz Kaczmarek changed:
What|Removed |Added
Attachment #99088|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674
Janusz Kaczmarek changed:
What|Removed |Added
CC||janus...@gmail.com
---
43 matches
Mail list logo
