https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Blocks||32248
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Blocks||27880
See
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Fridolin Somers changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Martin Renvoize changed:
What|Removed |Added
Keywords|release-notes-needed|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Martin Renvoize changed:
What|Removed |Added
Text to go in the||This enhancement improves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #118 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #117)
> Created attachment 124269 [details] [review]
> Bug 25078: Fix indentation and style for additional descriptions
Pushed to master.
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #117 from Jonathan Druart ---
Created attachment 124269
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124269=edit
Bug 25078: Fix indentation and style for additional descriptions
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_21_11_candidate,|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #116 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #115)
> Created attachment 123937 [details] [review]
> Bug 25078: Explicitely return from DB revs to avoid warnings
>
> % perl -wc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #115 from Jonathan Druart ---
Created attachment 123937
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123937=edit
Bug 25078: Explicitely return from DB revs to avoid warnings
% perl -wc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #114 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #113)
> Created attachment 123853 [details] [review]
> Bug 25078: Add exec flags
Pushed to master.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #113 from Jonathan Druart ---
Created attachment 123853
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123853=edit
Bug 25078: Add exec flags
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #112 from Jonathan Druart ---
Pushed to master for 21.11, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #111 from Jonathan Druart ---
Created attachment 123851
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123851=edit
Bug 25078: Don't process db revs if updatedatabase.pl failed
The updatedatebase stops
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #110 from Jonathan Druart ---
Created attachment 123850
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123850=edit
Bug 25078: Move skeleton file
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Keywords||release-notes-needed
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #109 from Martin Renvoize ---
Awesome!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #108
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #107 from Jonathan Druart ---
Patches (and remote branch) rebased on top of master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #123357|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #122875|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #122680|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #122679|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #102 from Jonathan Druart ---
Created attachment 123363
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123363=edit
Bug 25078: Move DB revs up to 21.06.00.011
Updated on 2021-08-02 for 21.06.00.011
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #122669|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #122668|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #122667|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #122666|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #122665|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #96 from Jonathan Druart ---
https://snipboard.io/W7skMG.jpg
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #123356|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #94 from Jonathan Druart ---
Created attachment 123356
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123356=edit
Bug 25078: Keep atomic updates in "atomicupdate" dir
The atomicupdate directory will
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #93 from Jonathan Druart ---
As it, we are moving the atomic updates to the db_rev directory. Is it the
behaviour we want?
Should we 1. support both syntaxes (.perl and .pl) in
installer/data/mysql/atomicupdate or 2.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #92 from Jonathan Druart ---
Created attachment 122875
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122875=edit
Bug 25078: Fix 'Wide character' from CLI
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #91 from Jonathan Druart ---
(In reply to Victor Grousset/tuxayo from comment #90)
> Testing note: always restart services after changing the version syspref.
>
>
>
> A bit confused about the test plan:
>
> > -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #90 from Victor Grousset/tuxayo ---
Testing note: always restart services after changing the version syspref.
A bit confused about the test plan:
> - Apply "Bug 25078: [DO NOT PUSH] DB revs for testing"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #89 from Victor Grousset/tuxayo ---
(In reply to Jonathan Druart from comment #84)
> [qw(Multi lines description)] is similar to ["Multi", "lines", "
> description"], if it it what disturb you.
That was it, thanks for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #88 from Julian Maurice ---
I tested this patch with the CLI and the Web installer. Both display the
Unicode characters correctly.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #87 from Julian Maurice ---
Created attachment 122680
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122680=edit
Bug 25078: Fix encoding issue with db_revs output
From `perldoc -f open`:
The scalars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #86 from Julian Maurice ---
Created attachment 122679
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122679=edit
Bug 25078: Close open filehandle
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #85 from Jonathan Druart ---
Note that there is an encoding issue (on 21060.pl), I didn't manage to fix
so far. I will ask Julian or have a look at it later.
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #84 from Jonathan Druart ---
(In reply to Victor Grousset/tuxayo from comment #75)
> description => [qw(Multi lines description)],
>
> It's multiline and it doesn't matter that we actually use it, just having
> this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #83 from Jonathan Druart ---
Created attachment 122671
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122671=edit
Bug 25078: Move DB revs up to 21.06.00.005
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #82 from Jonathan Druart ---
Created attachment 122670
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122670=edit
Bug 25078: [DO NOT PUSH] Another Test for the backward shim
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #122326|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #122325|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #122324|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #122323|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #122322|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #76 from Victor Grousset/tuxayo ---
I get the following conflict when applying the rest of patches after «- Make
sure the different use cases are covered»
<<< HEAD this is the code after applying «DB revs for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #75 from Victor Grousset/tuxayo ---
description => [qw(Multi lines description)],
It's multiline and it doesn't matter that we actually use it, just having this
syntax work is enough right?
description =>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #74 from Martin Renvoize ---
Just added a follow-up atomicupdate (do not push it) to show how I tested that
backwards compatibility stuff.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #73 from Martin Renvoize ---
Created attachment 122329
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122329=edit
Bug 25078: Another Test for the backward shim
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #71 from Martin Renvoize ---
Created attachment 122326
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122326=edit
Bug 25078: (follow-up) Update 'NewVersion' for output_version changes
This patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Martin Renvoize changed:
What|Removed |Added
Attachment #122208|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Martin Renvoize changed:
What|Removed |Added
Attachment #121984|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Martin Renvoize changed:
What|Removed |Added
Attachment #121983|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Martin Renvoize changed:
What|Removed |Added
Attachment #121982|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #66 from Julian Maurice ---
Comment on attachment 122208
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122208
Bug 25078: Separate update "report" from its description
Review of attachment 122208:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #65 from Julian Maurice ---
Created attachment 122208
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122208=edit
Bug 25078: Separate update "report" from its description
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #64 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #63)
> This has moved a bit.. looking good.
>
> I wonder about the --force option we've introduced a little.. might be good
> to have a 'force_once'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #63 from Martin Renvoize ---
This has moved a bit.. looking good.
I wonder about the --force option we've introduced a little.. might be good to
have a 'force_once' or something so allow the user to pick to ignore the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #62 from Jonathan Druart ---
Created attachment 121984
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121984=edit
Bug 25078: Re-introduce NewVersion
This is ugly, we re-add the code we removed in the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #121911|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #121909|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #59 from Julian Maurice ---
(In reply to Jonathan Druart from comment #57)
> (In reply to Julian Maurice from comment #56)
> > https://gitlab.com/jajm/Koha/-/commit/
> > 864372e553d312d1a533a75f389d9a7aa143c62e
>
> Yes,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #58 from Jonathan Druart ---
Note to myself, the first patch should:
-my $report = update( $files, { force => 1 } );
+my $report = update( $files, { force => $force } );
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #57 from Jonathan Druart ---
(In reply to Julian Maurice from comment #56)
> (In reply to Julian Maurice from comment #54)
> > I'll submit a patch later to show what I have in mind (maybe on a remote git
> > repository
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #56 from Julian Maurice ---
(In reply to Julian Maurice from comment #54)
> I'll submit a patch later to show what I have in mind (maybe on a remote git
> repository to not pollute this bug)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #55 from Jonathan Druart ---
(In reply to Julian Maurice from comment #54)
> (In reply to Jonathan Druart from comment #51)
> > It's not what is done (and has never been done). We display display the
> > output when the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #54 from Julian Maurice ---
(In reply to Jonathan Druart from comment #51)
> It's not what is done (and has never been done). We display display the
> output when the DBrev has been executed.
You're right, the output
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #53 from Jonathan Druart ---
TODO: Fix NewVersion()!
But it does not prevent testing and feedback.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #52 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #51)
> Are you suggesting you should change this behaviour?
s/you should/we should :D
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #51 from Jonathan Druart ---
(In reply to Julian Maurice from comment #50)
> Comment on attachment 121909 [details] [review]
> Bug 25078: Put db revs into different files to handle them better
>
> Review of attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #50 from Julian Maurice ---
Comment on attachment 121909
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121909
Bug 25078: Put db revs into different files to handle them better
Review of attachment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #121910|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #117084|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #116209|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Attachment #116208|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #48 from Jonathan Druart ---
Created attachment 121910
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121910=edit
Bug 25078: [DO NOT PUSH] DB revs for testing
Use with the --force flag:
%
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
--- Comment #47 from Jonathan Druart ---
Created attachment 121909
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121909=edit
Bug 25078: Put db revs into different files to handle them better
This patch suggests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Keywords|rel_21_05_candidate |rel_21_11_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078
Jonathan Druart changed:
What|Removed |Added
Summary|Gracefully stop |Update DB process - wrap
89 matches
Mail list logo
