[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Jonathan Druart changed: What|Removed |Added Severity|new feature |enhancement -- You are r

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #75 from Fridolin Somers --- (In reply to Jonathan Druart from comment #74) > (In reply to Martin Renvoize from comment #73) > > Did you mean bug 27820 > > Yes! Thx bug 27820 is pushed to master and 20.11.x ouf ;) --

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #74 from Jonathan Druart --- (In reply to Martin Renvoize from comment #73) > Did you mean bug 27820 Yes! Thx -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #73 from Martin Renvoize --- Did you mean bug 27820 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-c

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #72 from Jonathan Druart --- This will be reverted if bug 27750 is not pushed ASAP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs ma

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Katrin Fischer changed: What|Removed |Added Blocks||27820 Referenced Bugs: h

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #71 from David Cook --- (In reply to Fridolin Somers from comment #68) > Pushed to 20.11.x for 20.11.03 Woo! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #70 from Andrew Fuerste-Henry --- New feature, so not backporting to 20.05. Please request if needed. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #69 from Fridolin Somers --- I updated https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks -- You are receiving this mail because: You are watching all bug changes. ___ Koh

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Fridolin Somers changed: What|Removed |Added Version(s)|21.05.00|21.05.00,20.11.03

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #67 from Katrin Fischer --- I'd really like to see it backported. Kinda the point of the plugin system is not to make it necessary to change core code :) And 20.11 is still pretty young, I think it would be a nice additio

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #66 from Martin Renvoize --- Hmm, I think it's probably simple enough for people to self-port if they need it. -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #65 from Fridolin Somers --- Should this be backported in 20.11.x ? Its quite standalone so risk is minimum right ? -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #64 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Nick Clemens changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Nick Clemens changed: What|Removed |Added Text to go in the||This patchset adds a new

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #63 from Jonathan Druart --- Cannot push, release notes needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #62 from Martin Renvoize --- Done, thanks for the reminder :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@li

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed --

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Passed QA -- You are rec

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #60 from David Cook --- (In reply to Tomás Cohen Arazi from comment #58) > It is like requiring we rewrite C4::Search to allow plugins to perform > searches. While it would be awesome, it is way too much. I like the way

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #59 from Kyle M Hall --- (In reply to Tomás Cohen Arazi from comment #58) > We shouldn't make this tiny but useful enhancement depend on something as > big as having the task queue code adapted to handle scheduled tasks,

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #58 from Tomás Cohen Arazi --- We shouldn't make this tiny but useful enhancement depend on something as big as having the task queue code adapted to handle scheduled tasks, defined by plugins (the background jobs stuff i

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutio

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #57 from David Cook --- Regarding my above comments, while I have ambitions for a bespoke task scheduler, Martin is correct that it is unlikely that I am going to write such a task scheduler any time soon. (I'm really val

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #56 from David Cook --- Oh, another point about not using cron-based schedulers. Cron is a royal pain when you're working with containers. It would nice not to be continually wedded to a 1970s technology... -- You are r

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #55 from David Cook --- (In reply to Martin Renvoize from comment #54) > Yes, a task scheduler would be > great, but I really didn't want to wait another 10 years whilst people made > up their mind on how to implement one

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #54 from Martin Renvoize --- Firstly, this bug was all about adding the ability to just run a task added by a plugin at regular intervals.. it was added to resolve the need to set up all sorts of additional cron jobs for

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #53 from David Cook --- (In reply to Jonathan Druart from comment #52) > An easy (but lazy) implementation could be: > - Have a Koha::BackgroundJob::Plugin > - Your plugin class inherit it and has a > job_type="plugin|You

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #52 from Jonathan Druart --- An easy (but lazy) implementation could be: - Have a Koha::BackgroundJob::Plugin - Your plugin class inherit it and has a job_type="plugin|Your::Plugin::Class" - Your plugin implement ->proce

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #51 from David Cook --- (In reply to Martin Renvoize from comment #50) > Could you possibly write an example of how you'd expect a plugin to use the > new task queue stuff as an alternative to this? I'm happy for this bu

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #50 from Martin Renvoize --- Could you possibly write an example of how you'd expect a plugin to use the new task queue stuff as an alternative to this? I'm happy for this bug to be replaced with such an example.. right

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion -- You are

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #49 from Jonathan Druart --- (In reply to Jonathan Druart from comment #21) > I have the feeling that this should have been implemented on top of bug > 22417 (with bug 1993 in mind). Now that we have bug 22417 into mast

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #48 from Martin Renvoize --- *** Bug 20897 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-b

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Attachment #105402|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Attachment #105401|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #47

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Attachment #105400|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #4

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_05_candidate | -- You are receiving th

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #42 from David Cook --- (In reply to Tomás Cohen Arazi from comment #41) > I think this implementation is simple and covers the use case it is intended > to. If we happen to have a task scheduler in a future, we could rep

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|tomasco...@gmail.com --

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #39 from Tomás Cohen Arazi --- Created attachment 105401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105401&action=edit Bug 25245: (follow-up) Use Koha::Logger Update script to use Koha::Logger to c

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #40 from Tomás Cohen Arazi --- Created attachment 105402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105402&action=edit Bug 25245: Add plugins_nightly.pl to the default cron Signed-off-by: Tomas Coh

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #38 from Tomás Cohen Arazi --- Created attachment 105400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105400&action=edit Bug 25245: Add plugins_nightly.pl cronjob script This script simply iterates t

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103775|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are r

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103778|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103774|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #37 from David Cook --- (In reply to Martin Renvoize from comment #35) > I agree with Katrin here I think.. I would say it's clearer to have the > default in the .daily file as it's intended to be run daily and for an adm

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #36 from David Cook --- (In reply to Katrin Fischer from comment #34) > A nightly job in the daily file makes sense to me - that's where I would be > looking for it. And I'd rather schedule it at a standard time tha a new

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #35 from Martin Renvoize --- I agree with Katrin here I think.. I would say it's clearer to have the default in the .daily file as it's intended to be run daily and for an admin to move it to .d if they are keen to specif

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #34 from Katrin Fischer --- > What do you think about putting the cronjob in /etc/cron.d/koha-common > instead of /etc/cron.daily/koha-common? > > The former could run at very configurable time whereas the latter runs a

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #33 from David Cook --- (In reply to Martin Renvoize from comment #32) > You can happily gain a little more control over the scheduling within your > plugin code by doing a date comparison as the first part of the job in

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #32 from Martin Renvoize --- I didn't want to get stuck in the queue waiting for any of the schedulers rewrite bugs so it was a deliberate choice not to base this code upon them. Cron is a simple system and this is reall

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Katrin Fischer changed: What|Removed |Added Attachment #104345|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #30 from Katrin Fischer --- Created attachment 104345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104345&action=edit Bug 25188: Make circulation notes more prominent on the patron details tab This p

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #29 from Katrin Fischer --- I feel like this could already help a lot of plugin authors and libraries as it will allow to streamline installing plugins that need to process data overnight. An even more flexible solution w

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #28 from David Cook --- Actually, in Jonathan's defence again, on Ubuntu 18.04 it wouldn't be a "nightly" method so much as a daily/every morning method when run in cron.daily, as it's set up to run at 6:25am out of the b

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #27 from David Cook --- (In reply to David Cook from comment #26) > I'd argue Bug 22417 tries to be too comprehensive, and that we'd be better > off just adding RabbitMQ and Net::Stomp as dependencies, and then doing a >

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #26 from David Cook --- (In reply to Tomás Cohen Arazi from comment #23) > (In reply to Kyle M Hall from comment #22) > > (In reply to Jonathan Druart from comment #21) > > > I have the feeling that this should have been

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #25 from David Cook --- (In reply to Jonathan Druart from comment #24) > The main inconvenient of this implementation is that the time the job will > start is not configurable. That's true although that's a criticism I h

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #24 from Jonathan Druart --- The main inconvenient of this implementation is that the time the job will start is not configurable. -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #23 from Tomás Cohen Arazi --- (In reply to Kyle M Hall from comment #22) > (In reply to Jonathan Druart from comment #21) > > I have the feeling that this should have been implemented on top of bug > > 22417 (with bug 19

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #22 from Kyle M Hall --- (In reply to Jonathan Druart from comment #21) > I have the feeling that this should have been implemented on top of bug > 22417 (with bug 1993 in mind). Is there any reason this cannot be update

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #20 from Martin Renvoize --- Ah.. sorry.. I hadn't spotted you were worried about the$_ as apposed to $@.. I thought it was the introduction of a 'warn' at all you were commenting on. Yes, as Tomas explains, Try::Tiny ca

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #19 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #18) > (In reply to Marcel de Rooy from comment #17) > > (In reply to Martin Renvoize from comment #15) > > > > Why do you warn $_ ? > > > > > > Fol

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #17) > (In reply to Martin Renvoize from comment #15) > > > Why do you warn $_ ? > > > > Following prior art. It makes sense to warn like this for s

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #17 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #15) > > Why do you warn $_ ? > > Following prior art. It makes sense to warn like this for such errors. I > have however added a Koha::Logger based

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- C

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #15 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #7) > Some QA comments: > use Modern::Perl Corrected > Where do you need FindBin for here? We don't, I've removed it.. I coded it in a hurry whilst

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are re

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Attachment #103776|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Attachment #103767|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Attachment #103768|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Attachment #103769|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Attachment #103497|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Attachment #103498|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #9 from Martin Renvoize --- Created attachment 103768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103768&action=edit Bug 25245: (follow-up) Use Koha::Logger Update script to use Koha::Logger to capt

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #6 from Kyle M Hall --- Created attachment 103498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103498&action=edit Bug 25245: Add plugins_nightly.pl to the default cron Signed-off-by: Kyle M Hall --

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Kyle M Hall changed: What|Removed |Added Attachment #103460|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiv

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added CC||k...@bywatersolutions.com,

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #4 from Martin Renvoize --- Test plan 1/ Apply patch 2/ Ensure your cron setup calls the new plugins_nightly.pl 3/ Install the recalls plugin and skip the 'setup cron_nightly.pl' step 4/ The recalls plugin should functio

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate -- Y

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #3 from Martin Renvoize --- Created attachment 103461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103461&action=edit Bug 25245: Add plugins_nightly.pl to the default cron -- You are receiving this

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Attachment #103454|0 |1 is obsolete|

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Severity|enhancement |new feature -- You are r

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #1 from Martin Renvoize --- Created attachment 103454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103454&action=edit Bug 25245: Add plugins_nightly.pl cronjob script This script simply iterates thro

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europ

  1   2   >