https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Kyle M Hall changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #1 from Kyle M Hall ---
Created attachment 104849
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104849&action=edit
Bug 25485: TinyMCE broken in Debian package installs
When installing the Debian packa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #2 from Katrin Fischer ---
Hi Kyle, I am seeing a 'partial' breakage in 18.11, could this be related?
TinyMCE loads, but when I click on 'link' for example, the pop-up is not
formatted nicely and the dev tools report at l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #4 from Tomás Cohen Arazi ---
This is amazing.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-commun
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #6 from David Cook ---
(In reply to Kyle M Hall from comment #1)
> Test Plan:
> 1) Install Koha 19.11 from package
> 2) Browse to the news editor
> 4) Note the WYSIWYG editor is missing
> 5) Build a new Koha package with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #7 from David Cook ---
Comment on attachment 104849
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104849
Bug 25485: TinyMCE broken in Debian package installs
Review of attachment 104849:
-->
(https:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #8 from David Cook ---
(In reply to David Cook from comment #7)
> Comment on attachment 104849 [details] [review]
> Bug 25485: TinyMCE broken in Debian package installs
>
> Review of attachment 104849 [details] [review]:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
David Cook changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #9 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
David Cook changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #11 from Victor Grousset/tuxayo ---
(In reply to David Cook from comment #5)
> And we're requiring Debian's libjs-jquery package too, although I don't
> think that actually gets used anywhere?
git grep "/usr/share/" | gr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #12 from David Cook ---
I think this one needs more testing, but on my initial tests it doesn't work
when upgrading Koha. I imagine it would work for installing Koha initially
though.
--
You are receiving this mail beca
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #13 from David Cook ---
Ok when I removed everything tiny_mce related from debian/rules, it installed
the bundled tinymce overtop of /usr/share/tinymce/www through the existing
symlink for my already existing Koha install
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #14 from Katrin Fischer ---
Hm, we tested an 18.11.16 package with Kyle's patch but the Editor is now gone:
ReferenceError: tinyMCE is not defined
tinyMCE.baseURL = "/intranet-tmpl/lib/tiny_mce";
Not the result I was ho
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #15 from Tomás Cohen Arazi ---
(In reply to Katrin Fischer from comment #14)
> Hm, we tested an 18.11.16 package with Kyle's patch but the Editor is now
> gone:
>
> ReferenceError: tinyMCE is not defined
> tinyMCE.baseUR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #16 from Katrin Fischer ---
(In reply to Tomás Cohen Arazi from comment #15)
> (In reply to Katrin Fischer from comment #14)
> > Hm, we tested an 18.11.16 package with Kyle's patch but the Editor is now
> > gone:
> >
> >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #17 from Owen Leonard ---
(In reply to Kyle M Hall from comment #1)
> When installing the Debian package of Koha, we install the Debian tinymce
> package and symlink over our own tinymce libs that are in the Koha codebas
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #18 from Katrin Fischer ---
I came to the conclusion that the TinyMCE problem on 18.11.16 is a different
problem - I found a workaround I will attach to bug 25519.
Sorry for adding to the confusion here.
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #19 from Victor Grousset/tuxayo ---
> 1) Install Koha 19.11 from package
> 5) Build a new Koha package with this patch applied, install it
IIUC from various IRC discussions the cleanest way[1] to test this while being
si
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #20 from Victor Grousset/tuxayo ---
*enough to be less likely to mess things up
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Mason James changed:
What|Removed |Added
CC||m...@kohaaloha.com
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Mason James changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #21 from David Cook ---
Hoping to work on this more today.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #22 from David Cook ---
Getting the following on master:
cp: cannot stat 'debian/tmp/debian/tmp/etc/koha/searchengine': No such file or
directory
dh_install: cp -a debian/tmp/debian/tmp/etc/koha/searchengine
debian/koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #23 from David Cook ---
(In reply to David Cook from comment #22)
> Getting the following on master:
>
> cp: cannot stat 'debian/tmp/debian/tmp/etc/koha/searchengine': No such file
> or directory
> dh_install: cp -a debi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #24 from David Cook ---
(In reply to David Cook from comment #23)
> Looks like Bug 24735 got rid of etc/searchengine/queryparser.yml, but
> Bugzilla says that bug was pushed to master at the start of March...
>
> I guess
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
David Cook changed:
What|Removed |Added
Depends on||25068
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #25 from David Cook ---
Ok with Bug 25068's patch and this one (plus a manual update to
debian/control), I was able to create a package.
Next, I inspected the files in the package:
dpkg-deb -c koha-common_19.12.00-test+2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #26 from David Cook ---
Created attachment 104995
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104995&action=edit
Bug 25485: Remove all mention of tiny_mce in debian/rules
This patch removes the remo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #27 from David Cook ---
The package now includes the tiny_mce files, but it's not removing the symlink,
which is a problem. See Bug 14055 for the YUI related issue.
--
You are receiving this mail because:
You are watchi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #28 from David Cook ---
Created attachment 104997
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104997&action=edit
Bug 25485: Remove tiny_mce symlink during pre install of deb package
This patch remov
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
David Cook changed:
What|Removed |Added
Attachment #104849|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
David Cook changed:
What|Removed |Added
Attachment #104999|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
David Cook changed:
What|Removed |Added
Attachment #104997|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
David Cook changed:
What|Removed |Added
Attachment #104995|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #33 from David Cook ---
Created attachment 105004
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105004&action=edit
Bug 25485: [Do not push] remove tiny_mce from debian/control for testing
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #34 from David Cook ---
Ok, using all these patches, you can get the correct behaviour.
I've signed off Kyle's original patch, and I'm leaving "Needs Signoff" so that
someone (maybe Kyle?) can sign off my patches.
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
David Cook changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #35 from David Cook ---
Note that this also affects 19.11 and not just master...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Jonathan Druart changed:
What|Removed |Added
Keywords||rel_20_05_candidate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #36 from Victor Grousset/tuxayo ---
(In reply to David Cook from comment #23)
> I guess I probably haven't been building master packages since then but
> https://dashboard.koha-community.org/ says the master build is stil
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Jonathan Druart changed:
What|Removed |Added
Blocks||25529
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Lisette Scheer changed:
What|Removed |Added
CC||lisettesla...@gmail.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Chris Cormack changed:
What|Removed |Added
Attachment #105001|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Chris Cormack changed:
What|Removed |Added
Attachment #105002|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Chris Cormack changed:
What|Removed |Added
Attachment #105004|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Chris Cormack changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europ
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #105048|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #105000|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #40 from Tomás Cohen Arazi ---
Created attachment 105127
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105127&action=edit
Bug 25485: TinyMCE broken in Debian package installs
When installing the Debia
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #105050|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #105049|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #42 from Tomás Cohen Arazi ---
Created attachment 105130
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105130&action=edit
Bug 25485: Remove tiny_mce symlink during pre install of deb package
This patc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #41 from Tomás Cohen Arazi ---
Created attachment 105128
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105128&action=edit
Bug 25485: Remove all mention of tiny_mce in debian/rules
This patch removes t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #43 from Tomás Cohen Arazi ---
Good job. I tested an upgrade to verify the symlink is removed and doesn't
break the upgrade. All good. Thanks and sorry for the delay! Will be trying to
test all the packages bugs together
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Martin Renvoize changed:
What|Removed |Added
Version(s)||20.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #44 from Martin Renvoize ---
Nice work everyone!
Pushed to master for 20.05
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing li
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Martin Renvoize changed:
What|Removed |Added
Keywords|rel_20_05_candidate |
--
You are receiving th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Joy Nelson changed:
What|Removed |Added
CC||j...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
--- Comment #46 from David Cook ---
(In reply to Joy Nelson from comment #45)
> Not sure the dependency affect this in 19.11.x - it wasn't pushed. This fix
> for TinyMCE was pushed to 19.11.x for 19.11.06
That's exactly right. Depe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25485
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
---
68 matches
Mail list logo
