https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Martin Renvoize changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Caroline Cyr La Rose changed:
What|Removed |Added
Status|Needs documenting |RESOLVED
Res
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Bug 25498 depends on bug 30578, which changed state.
Bug 30578 Summary: We should drop circ/ysearch.pl in preference to using the
REST API's
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30578
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Caroline Cyr La Rose changed:
What|Removed |Added
Documentation||https://gitlab.com/ko
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Lucas Gass changed:
What|Removed |Added
Resolution|FIXED |---
Status|RESOLVE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Lucas Gass changed:
What|Removed |Added
Status|Pushed to master|RESOLVED
Resolution|--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Bug 25498 depends on bug 11889, which changed state.
Bug 11889 Summary: Option to keep public or shared lists when deleting patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #63 from Tomás Cohen Arazi ---
Pushed to master for 22.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #62 from Marcel de Rooy ---
Created attachment 137908
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137908&action=edit
Bug 25498: (follow-up) Show error message when no sharee has email
Test plan:
Sha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #61 from Jonathan Druart ---
Just wanted to test the last patch. All good.
A quick remark when testing: I think we need the "transfer" action available
from the show list view (/virtualshelves/shelves.pl?op=view&shelfnum
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Jonathan Druart changed:
What|Removed |Added
Attachment #137867|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #59 from Marcel de Rooy ---
Created attachment 137867
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137867&action=edit
Bug 25498: (follow-up) Change for autocomplete change of 30578
Test plan:
Check i
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Attachment #136221|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Attachment #136169|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Attachment #136168|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Attachment #136167|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Attachment #136166|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Depends on||30578
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Attachment #136220|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #52 from Marcel de Rooy ---
Created attachment 136220
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136220&action=edit
Bug 25498: (QA follow-up) Rename virtualshelf->patron
This patron is a 'sharee' (
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #51 from Marcel de Rooy ---
Altough I must admit that $share->sharee is a bit funky indeed :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #50 from Marcel de Rooy ---
(In reply to Katrin Fischer from comment #49)
> >
> > or 'Sharer' and 'Sharee'.. those feel funky but might actually be the
> > clearest two quasi-terms.?
>
> I like those best from the sugge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #49 from Katrin Fischer ---
>
> or 'Sharer' and 'Sharee'.. those feel funky but might actually be the
> clearest two quasi-terms.?
I like those best from the suggested. user I guess is too general in context
here?
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #48 from Martin Renvoize ---
Do they contribute or just get access to view?
'Recipient' or 'Beneficiary'
or 'Sharer' and 'Sharee'.. those feel funky but might actually be the clearest
two quasi-terms.?
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #47 from Jonathan Druart ---
(In reply to Marcel de Rooy from comment #45)
> (In reply to Jonathan Druart from comment #43)
> > Isn't Koha::Virtualshelfshare->patron confusing?
>
> Hmm Good question. Do you have a sugges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #46 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #42)
> Minor wonderment, should the permissions check be moved up in the the module
> level rather than being in the controllers.. so we can have it un
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #45 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #43)
> Isn't Koha::Virtualshelfshare->patron confusing?
Hmm Good question. Do you have a suggestion already?
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #44 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #42)
> This works well, tests pass and QA script is happy.
>
> Minor wonderment, should the permissions check be moved up in the the module
> level ra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #43 from Jonathan Druart ---
Isn't Koha::Virtualshelfshare->patron confusing?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing l
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #42
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Martin Renvoize changed:
What|Removed |Added
Attachment #136036|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Martin Renvoize changed:
What|Removed |Added
Attachment #136035|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Martin Renvoize changed:
What|Removed |Added
Attachment #136034|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Martin Renvoize changed:
What|Removed |Added
Attachment #136033|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #36 from Owen Leonard ---
This is working well, but I think we ought to wait and rework the autocomplete
parts of it after Bug 30578 makes progress.
--
You are receiving this mail because:
You are watching all bug chang
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #35 from Owen Leonard ---
Created attachment 136036
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136036&action=edit
Bug 25498: Transfer ownership shared list on OPAC
Test plan:
Pick or create a share
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #34 from Owen Leonard ---
Created attachment 136035
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136035&action=edit
Bug 25498: Show transfer button for shared lists on OPAC
Test plan:
Pick or create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #33 from Owen Leonard ---
Created attachment 136034
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136034&action=edit
Bug 25498: Add a transfer form for public lists
Test plan:
[1] Valid transfer:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Owen Leonard changed:
What|Removed |Added
Attachment #136008|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #31 from Marcel de Rooy ---
Also opened bug 30955 for an additional notice for a new owner of a shared
list.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #30 from Marcel de Rooy ---
Why does this report not make it possible to change the owner of a shared list
on staff?
In short, share a list is an OPAC feature.
Note that I opened bug 30953 to add an intranet counterpart.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #29 from Marcel de Rooy ---
QA team:
FAIL Koha/Virtualshelfshare.pm
FAIL valid
Constant subroutine
Koha::Virtualshelfshare::SHARE_INVITATION_EXPIRY_DAYS redefined
This is a false negative. Nothin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #28 from Marcel de Rooy ---
Current stand:
[1] Allow transfer ownership of public list on staff interface. Staff member
with permission can transfer to any user.
[2] Allow the owner of a shared list to transfer ownership
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Text to go in the|This enhancement allows |This enhancement allows
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Text to go in the||This enhancement allows
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #26 from Marcel de Rooy ---
Created attachment 136011
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136011&action=edit
Bug 25498: Transfer ownership shared list on OPAC
Test plan:
Pick or create a sha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #25 from Marcel de Rooy ---
Created attachment 136010
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136010&action=edit
Bug 25498: Show transfer button for shared lists on OPAC
Test plan:
Pick or creat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Attachment #135921|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Attachment #135889|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Patch complexity|--- |Small patch
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #21 from Marcel de Rooy ---
Created attachment 135921
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135921&action=edit
Bug 25498: Add a transfer form for public lists
Test plan:
[1] Valid transfer:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
--- Comment #20 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #19)
> I've never really investigated this area of Koha much.. I was surprised to
> see the 'share' options only work from the OPAC.. I thought you'd b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25498
Marcel de Rooy changed:
What|Removed |Added
Summary|Cannot change owner of list |Allow to change owner of
60 matches
Mail list logo