[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2024-01-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-06-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 Andrew Nugged changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment

[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-06-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 --- Comment #6 from Jonathan Druart --- What about the following? $scopes => [ { scope => [ qw( branchcode ) ], rules => [ qw( refund ) ], }, { scope => [ qw( branchcode categorycode ) ], rules => [ qw(

[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 --- Comment #5 from Andrew Nugged --- Here we need to have more filtering criteria for smart-rules. For Finnish libraries, we added "ccode" and "sleving_location", two extra smart rule filters (but by the way also later we propose

[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 --- Comment #4 from Katrin Fischer --- Hi Peter, can you explain about your future needs? At the moment I am with Jonathan, I think readability is to be preferred, even if resulting in more code. -- You are receiving this mail

[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-06-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 --- Comment #3 from Peter Vashchuk --- Yeah I thought about naming them similarly to what you proposed but it would undermine some decisions that were taken into consideration during refactor. The thing is, we need to add another

[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-06-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 Peter Vashchuk changed: What|Removed |Added CC||nug...@gmail.com -- You

[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 Peter Vashchuk changed: What|Removed |Added CC||slavashish...@gmail.com

[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 --- Comment #1 from Peter Vashchuk --- Created attachment 105154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105154=edit Bug 25554: Refactor rule kinds assignments in CirculationRules.pm CirculationRules.pm

[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

2020-05-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 Peter Vashchuk changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are