[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added CC||tomasco...@gmail.com --

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #42 from Martin Renvoize --- All works in testing for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #154453|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff ---

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #154427|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #38 from David Cook --- Comment on attachment 154427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154427 Bug 25672: Convert to restricting to listed repositories only Review of attachment 154427:

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #153925|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #37 from Martin Renvoize --- Created attachment 154427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154427=edit Bug 25672: Convert to restricting to listed repositories only I think instead of a

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #153827|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #153826|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #153825|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #153824|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #32 from Martin Renvoize --- Some work towards what I was suggesting.. let me know what you think.. it's all a bit crude, but until we get some more of the Plugins foundations solid I think it may be the middle ground we

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #31 from Martin Renvoize --- Created attachment 153925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153925=edit Bug 25672: WIP - Convert to restricting to repo only I think instead of a plain on/off

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #30 from Martin Renvoize --- Mind if I amend this from 'enable_plugin_browser_upload' to 'restrict_to_plugin_repos'. My thinking is, instead of a simple on/off switch for uploads we set it to only allow uploads from

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #29

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #28 from David Cook --- Created attachment 153827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153827=edit Bug 25672: Prevent uninstall when plugin browser upload disabled When plugin browser upload

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Attachment #107174|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Attachment #107173|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Attachment #107172|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #24 from David Cook --- (In reply to Martin Renvoize from comment #16) > Ah, if that was your intentention, I don't believe it worked. I'm sure I > tested it during QA and as expected, it failed at the plugin upload

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #23 from David Cook --- This one has been in the back of my mind for a long time, and I thought it was about time it was revisited. (In reply to Martin Renvoize from comment #17) > (In reply to Jonathan Druart from

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Assignee|dc...@prosentient.com.au|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #20 from David Cook --- (In reply to Martin Renvoize from comment #16) > Ah, if that was your intentention, I don't believe it worked. I'm sure I > tested it during QA and as expected, it failed at the plugin upload

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #19 from David Cook --- (In reply to Jonathan Druart from comment #15) > We cannot upload but uninstall, is that ok? That's a good question. I was thinking that it was OK for them to uninstall them, but I suppose that

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Jonathan Druart changed: What|Removed |Added Status|Passed QA |ASSIGNED --- Comment #18

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #17 from Martin Renvoize --- (In reply to Jonathan Druart from comment #15) > We cannot upload but uninstall, is that ok? Good catch, we should probably disallow that too here. -- You are receiving this mail because:

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #16 from Martin Renvoize --- (In reply to David Cook from comment #14) > (In reply to Martin Renvoize from comment #13) > > Oops. forgot to attach my QA follow-up first time around.. it just hides the > > install button

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #14 from David Cook --- (In reply to Martin Renvoize from comment #13) > Oops. forgot to attach my QA follow-up first time around.. it just hides the > install button if you happen to have your system configured for no

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #8 from David Cook --- (In reply to Fridolin SOMERS from comment #7) > I like this. > > We at biblibre have our CLI script one can find there : > https://git.biblibre.com/biblibre/tools/src/branch/master/koha/plugin.sh

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #12 from Martin Renvoize --- Created attachment 107174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107174=edit Bug 25672: (QA follow-up) Hide install after search button If plugin upload is

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #13 from Martin Renvoize --- Oops. forgot to attach my QA follow-up first time around.. it just hides the install button if you happen to have your system configured for no uploads but still allow searching for plugins

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #106673|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Attachment #106674|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #7 from Fridolin SOMERS --- I like this. We at biblibre have our CLI script one can find there : https://git.biblibre.com/biblibre/tools/src/branch/master/koha/plugin.sh Note that you must flush memcached then reload

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Fridolin SOMERS changed: What|Removed |Added CC|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Nicolas Legrand changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Nicolas Legrand changed: What|Removed |Added Attachment #106651|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Nicolas Legrand changed: What|Removed |Added Attachment #106671|0 |1 is obsolete|

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #4 from David Cook --- Created attachment 106671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106671=edit Bug 25672: Enable enable_plugin_browser_upload by default This patch enables

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #3 from David Cook --- (In reply to Kyle M Hall from comment #2) > Looks good, but the default should be to allow plugin uploads to keep in > line with current behavior. Agreed. I was thinking about that late last night

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added CC||martin.renvoize@ptfs-europe

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 --- Comment #1 from David Cook --- Created attachment 106651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106651=edit Bug 25672: use enable_plugin_browser_upload flag to control plugin upload This patch adds a

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff Patch

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 25672] Administrators should be able to disable client-side plugin upload

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What|Removed |Added Summary|Administrators should be|Administrators should be