[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 --- Comment #19 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #17) > (In reply to Jonathan Druart from comment #16) > > > > Sorry I missed you comment before pushing it. Do you mean there is an > > encoding

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 --- Comment #17 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #16) > > Sorry I missed you comment before pushing it. Do you mean there is an > encoding issue in the current version? Yep when using tmp session

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 --- Comment #16 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #14) > (In reply to Martin Renvoize from comment #8) > > Also.. this introduces an additional DB hit.. you could fetch the branchname > > from

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 --- Comment #15 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 --- Comment #14 from Fridolin SOMERS --- (In reply to Martin Renvoize from comment #8) > Also.. this introduces an additional DB hit.. you could fetch the branchname > from context instead. > > I feel caching of the logged in

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 --- Comment #12 from Martin Renvoize --- Created attachment 107157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107157=edit Bug 25765: (QA follow-up) Use method directly in cleanborrowers Signed-off-by: Martin

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Martin Renvoize changed: What|Removed |Added Attachment #106357|0 |1 is obsolete|

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Martin Renvoize changed: What|Removed |Added Attachment #106358|0 |1 is obsolete|

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 --- Comment #11 from Martin Renvoize --- Created attachment 107156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107156=edit Bug 25765: (QA follow-up) Save a DB hit Signed-off-by: Martin Renvoize -- You are

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 --- Comment #8 from Martin Renvoize --- Also.. this introduces an additional DB hit.. you could fetch the branchname from context instead. I feel caching of the logged in library object is ripe for performance. -- You are

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #105910|0 |1 is

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #105909|0 |1 is

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Jonathan Druart changed: What|Removed |Added Depends on||21746

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Fridolin SOMERS changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 --- Comment #2 from Fridolin SOMERS --- Created attachment 105909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105909=edit Bug 25765: Add GetLoggedInBranchname method Add GetLoggedInBranchname method to

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 --- Comment #3 from Fridolin SOMERS --- Created attachment 105910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105910=edit Bug 25765: Replace LoginBranchname and LoginBranchcode with use of Branches template

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Fridolin SOMERS changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch

[Koha-bugs] [Bug 25765] Replace LoginBranchname and LoginBranchcode with use of Branches template plugin

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25765 Fridolin SOMERS changed: What|Removed |Added Summary|Replace LoginBranchname |Replace LoginBranchname