https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #41 from Katrin Fischer ---
(In reply to Blou from comment #40)
> This is a rabbit hole.
>
> We are now in the time of the year where we prepare our next release AND
> it's coincidently relevant to what's on master. Bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #40 from Blou ---
This is a rabbit hole.
We are now in the time of the year where we prepare our next release AND it's
coincidently relevant to what's on master. Bug 27113 is stuck behind this,
which is big, complicated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #38 from Katrin Fischer ---
As this is blocking the much desired 27113 - what can we do to help move this
along?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #37 from David Cook ---
(In reply to Jonathan Druart from comment #35)
> (In reply to Hammat wele from comment #34)
> > I still need help with Koha::Biblios->search thing. how to use it to search
> > biblio hidden_in_opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #36 from Tomás Cohen Arazi ---
You really need to perform the search against the search engine, with any
implicit filtering like OpacHiddenItems added to the CCL query. Otherwise you
would kill the interesting bit of sear
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.druart+koha@gmail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Paul Derscheid changed:
What|Removed |Added
Assignee|paul.dersch...@lmscloud.de |hammat.w...@inlibro.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Bug 25870 depends on bug 32734, which changed state.
Bug 32734 Summary: REST API: Add a list endpoint for Biblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32734
What|Removed |Added
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #34 from Hammat wele ---
I still need help with Koha::Biblios->search thing. how to use it to search
biblio hidden_in_opac. With the Koha::Biblios->search adding the pagination
would be more easier.
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Hammat wele changed:
What|Removed |Added
Attachment #148247|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #32 from Tomás Cohen Arazi ---
(In reply to Hammat wele from comment #31)
> Created attachment 148247 [details] [review]
> Bug 25870: (follow-up) Adding pagination information on the headers, returns
> an empty result whe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #31 from Hammat wele ---
Created attachment 148247
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148247&action=edit
Bug 25870: (follow-up) Adding pagination information on the headers, returns an
empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #30 from Tomás Cohen Arazi ---
A few comments on the preliminary code:
* An empty query should return an empty resultset, not a 404
* Koha::SearchEngine::Search->extract_biblionumber should be used instead of
reinventing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #29 from Hammat wele ---
Redoing this bug on top of the bug 32734
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Hammat wele changed:
What|Removed |Added
Attachment #138123|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #27 from Paul Derscheid ---
Tomas, I'll continue working on this next week if that's alright with you. I'd
love to do it immediately but I'm really swamped this week.
--
You are receiving this mail because:
You are watc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #26 from Paul Derscheid ---
I'll estimate the workload and get back to you, Tomas.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Tomás Cohen Arazi changed:
What|Removed |Added
Depends on||32734
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Tomás Cohen Arazi changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #139469|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #139452|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #138123|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Caroline Cyr La Rose changed:
What|Removed |Added
CC||caroline.cyr-la-rose@
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Caroline Cyr La Rose changed:
What|Removed |Added
Blocks||27113
Referenced Bu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Paul Derscheid changed:
What|Removed |Added
Attachment #139469|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Paul Derscheid changed:
What|Removed |Added
Attachment #139452|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Paul Derscheid changed:
What|Removed |Added
Attachment #138123|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #19 from David Cook ---
(In reply to Tomás Cohen Arazi from comment #14)
> (In reply to Paul Derscheid from comment #7)
> > That's right but at LMSCloud we need this as a public route and tcohen also
> > wants this to be
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #20 from David Cook ---
(In reply to Paul Derscheid from comment #7)
> That's right but at LMSCloud we need this as a public route and tcohen also
> wants this to be public, so the simple approach doesn't fly.
>
> Thank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #21 from David Cook ---
(In reply to David Cook from comment #20)
> (In reply to Paul Derscheid from comment #7)
> > That's right but at LMSCloud we need this as a public route and tcohen also
> > wants this to be public,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #13 from Kyle M Hall ---
(In reply to Tomás Cohen Arazi from comment #11)
> (In reply to Paul Derscheid from comment #5)
> > The other issue is that this route can be abused for DOS-attacks which must
> > be handled someh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #16 from Kyle M Hall ---
I'd really like to see us get away from Apache based solutions, but at the same
time it's a very practical way to handle it that works for 99.9% of Koha users.
If there exists middleware that woul
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #14 from Tomás Cohen Arazi ---
(In reply to Paul Derscheid from comment #7)
> That's right but at LMSCloud we need this as a public route and tcohen also
> wants this to be public, so the simple approach doesn't fly.
We
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #9 from Paul Derscheid ---
Another question is what a sane 'number of requests/interval' would look like.
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #15 from Tomás Cohen Arazi ---
(In reply to Kyle M Hall from comment #13)
> That is a good point. Now, we just need to add throttling to this api, then
> use that api in opac-search ;)
>
> Tomas, at this time I think
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #11 from Tomás Cohen Arazi ---
(In reply to Paul Derscheid from comment #5)
> The other issue is that this route can be abused for DOS-attacks which must
> be handled somehow.
Isn't that already the case for bots hitting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #12 from Tomás Cohen Arazi ---
(In reply to Tomás Cohen Arazi from comment #11)
> (In reply to Paul Derscheid from comment #5)
> > The other issue is that this route can be abused for DOS-attacks which must
> > be handled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #10 from Kyle M Hall ---
(In reply to Paul Derscheid from comment #9)
> Another question is what a sane 'number of requests/interval' would look
> like.
I think that depends on the power of the server, and your use case.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #17 from Tomás Cohen Arazi ---
Comment on attachment 138123
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138123
Bug 25870 - Add a q_ccl query parameter to /biblios
Review of attachment 138123:
-->
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #6 from Kyle M Hall ---
(In reply to Paul Derscheid from comment #5)
> The other issue is that this route can be abused for DOS-attacks which must
> be handled somehow.
Wouldn't the simplest solution be to make it *not*
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #8 from Kyle M Hall ---
Also https://metacpan.org/pod/Plack::Middleware::Cerberus
We need something that throttles by the minute or even second if possible.
--
You are receiving this mail because:
You are watching all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #7 from Paul Derscheid ---
That's right but at LMSCloud we need this as a public route and tcohen also
wants this to be public, so the simple approach doesn't fly.
Thanks for the pointers, I'll have a look in a bit.
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #4 from Paul Derscheid ---
Created attachment 138123
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138123&action=edit
Bug 25870 - Add a q_ccl query parameter to /biblios
This patch adds new functional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #5 from Paul Derscheid ---
The other issue is that this route can be abused for DOS-attacks which must be
handled somehow.
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Tomás Cohen Arazi changed:
What|Removed |Added
Assignee|n...@bywatersolutions.com |paul.dersch...@lmscloud.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #3 from Tomás Cohen Arazi ---
(In reply to Paul Derscheid from comment #2)
> There's another thing: I think that the only Content-Type that makes sense
> for the return value is 'application/marc-in-json' because we retur
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
--- Comment #2 from Paul Derscheid ---
There's another thing: I think that the only Content-Type that makes sense for
the return value is 'application/marc-in-json' because we return 1..n records
instead of a single one.
Additional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Paul Derscheid changed:
What|Removed |Added
CC||paul.dersch...@lmscloud.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25870
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
52 matches
Mail list logo