[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #36 from Kyle M Hall --- Created attachment 113575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113575=edit Bug 26351: (QA follow-up) Rename barcode_transform to item_barcode_transform

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Attachment #111916|0 |1 is obsolete|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #33 from Kyle M Hall --- Created attachment 113572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113572=edit Bug 26351: (QA follow-up) Fix QA script issue * Fixes issue with barcode generate stub so

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Passed QA -- You are

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #30 from Kyle M Hall --- RM Note: I will need to update the plugins I've written take account for the changes in this bug series. I will do that once this bug has been pushed and bug 26342 has passed qa! -- You are

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #111863|0 |1 is obsolete|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #111894|0 |1 is obsolete|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #111862|0 |1 is obsolete|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #28 from Martin Renvoize --- Created attachment 111922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111922=edit Bug 26351: (QA follow-up) Catch one last case of itemBarcodeInputFilter Signed-off-by:

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #111579|0 |1 is obsolete|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #111577|0 |1 is obsolete|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added Attachment #111578|0 |1 is obsolete|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #21 from Kyle M Hall --- Created attachment 111894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111894=edit Bug 26351: (QA follow-up) Barcodes inputted into Koha should always pass though

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #20 from Kyle M Hall --- Created attachment 111863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111863=edit Bug 26351: (QA follow-up) Rename barcode_transform to item_barcode_transform -- You are

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #19 from Kyle M Hall --- Created attachment 111862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111862=edit Bug 26351: (QA follow-up) Remove unused method barcode_transform -- You are receiving

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #18 from Kyle M Hall --- > * I see a test for barcode_generate, but don't see any code related to this > in the rest of the patchset.. does this belong in a different bug? Yes, it is only used in Bug 26352. > * You're

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #17 from Katrin Fischer --- If you were to change that one, maybe patron_cardnumber_transfer? With chip cards and the likes that might be more accurate and stay close to our db name. -- You are receiving this mail

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #16 from Martin Renvoize --- Sorry Kyle * I see a test for barcode_generate, but don't see any code related to this in the rest of the patchset.. does this belong in a different bug? * You're a tad inconsistent with

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #15 from Kyle M Hall --- Created attachment 111579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111579=edit Bug 26351: Add unit tests -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #14 from Kyle M Hall --- Created attachment 111578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111578=edit Bug 26351: (QA follow-up) Fix QA script issue * Fixes issue with barcode generate stub so

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Attachment #111575|0 |1 is obsolete|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Attachment #109548|0 |1 is obsolete|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply ---

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Attachment #110844|0 |1 is obsolete|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #9 from Kyle M Hall --- Created attachment 110844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110844=edit Bug 26351: Add unit tests -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #7 from Julian Maurice --- (In reply to Kyle M Hall from comment #6) > In it's current state, the last plugin 'wins'. A couple solutions would be > to: > A) Modify call() to feed the result of the last plugin call into

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #6 from Kyle M Hall --- (In reply to Julian Maurice from comment #5) > I would like to make a suggestion about the hook name: IMO hooks should be > named after an event (what just happened in Koha) rather than what the >

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Julian Maurice changed: What|Removed |Added CC|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #4 from Kyle M Hall --- Created attachment 109671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109671=edit Bug 26351: (QA follow-up) Fix QA script issue * Fixes issue with barcode generate stub so

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #3 from Katrin Fischer --- Lacking the time to test deeply here tonight, but there is a small fail on the QA tools: FAIL t/lib/Koha/Plugin/Test.pm FAIL critic #

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Attachment #109532|0 |1 is obsolete|

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Blocks||26352 Referenced Bugs:

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com

[Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 --- Comment #1 from Kyle M Hall --- Created attachment 109532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109532=edit Bug 26351: Add plugin hooks to transform item barcodes Some of our partners have unusual

<    1   2