[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Andrew Isherwood changed: What|Removed |Added CC|bugzi...@warmlight.co.uk| -- You are receiving

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #35 from Emmi Takkinen --- (In reply to Marcel de Rooy from comment #34) > Is there any reason why the hold end date on the opac-reserve form is not > filled with the default date? > Note that this field is available via

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #32 from Emmi Takkinen --- (In reply to Jonathan Druart from comment #31) > Any good reasons to not have '! $self->expiration' instead of the not > defined, eq '' checks? > > +if (

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #31 from Jonathan Druart --- Any good reasons to not have '! $self->expiration' instead of the not defined, eq '' checks? +if ( C4::Context->preference('DefaultHoldExpirationdate') +and ( not defined

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Nick Clemens changed: What|Removed |Added Blocks||29192 Referenced Bugs:

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||29074 Referenced

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||29073 Referenced

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #30 from Tadas --- Comment on attachment 114663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114663 Bug 26498: Set default expiration date for holds >From 9fcb4bc1baf12a5471bec6997af4ac41da9a3db7

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Katrin Fischer changed: What|Removed |Added Component|Circulation |Hold requests -- You are

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Fridolin Somers changed: What|Removed |Added CC|

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #28 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #27 from Jonathan Druart --- Don't we actually want this to be a circulation rule to have more granularity? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #26 from Jonathan Druart --- Created attachment 119278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119278=edit Bug 26498: Add default values Just in case -- You are receiving this mail because:

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement adds the |This enhancement adds the

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Passed QA -- You are

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #25 from Martin Renvoize --- Created attachment 118678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118678=edit Bug 26498: (QA follow-up) Add handling for update This follow-up adds handling for

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What|Removed |Added Attachment #117543|0 |1 is obsolete|

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What|Removed |Added Attachment #117542|0 |1 is obsolete|

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #22 from Emmi Takkinen --- (In reply to Martin Renvoize from comment #21) > Good catch Jonathan.. do you need some help here Emmi.. or are you already > on the case? I've been a little busy lately so I haven't had time

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #21 from Martin Renvoize --- Good catch Jonathan.. do you need some help here Emmi.. or are you already on the case? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #20 from Emmi Takkinen --- (In reply to Jonathan Druart from comment #19) > (In reply to Emmi Takkinen from comment #18) > > (In reply to Jonathan Druart from comment #17) > > > The store method should be improved to set

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #19 from Jonathan Druart --- (In reply to Emmi Takkinen from comment #18) > (In reply to Jonathan Druart from comment #17) > > The store method should be improved to set expirationdate only if > > reservedate has been

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #18 from Emmi Takkinen --- (In reply to Jonathan Druart from comment #17) > The store method should be improved to set expirationdate only if > reservedate has been modified, to avoid unnecessary processing. Could you

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What|Removed |Added Attachment #117472|0 |1 is obsolete|

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What|Removed |Added Attachment #117127|0 |1 is obsolete|

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #13 from Emmi Takkinen --- Created attachment 117472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117472=edit Bug 26498: Add POD for "store" -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Failed QA -- You

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement adds the

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #12 from Victor Grousset/tuxayo --- > POD is missing for 'store' Something like that would do: -Overloaded I method to apply DefaultHoldExpirationdate -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #114663|0 |1 is

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Andrew Isherwood changed: What|Removed |Added Attachment #114524|0 |1 is obsolete|

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Andrew Isherwood changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Emmi Takkinen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Emmi Takkinen changed: What|Removed |Added Attachment #114057|0 |1 is obsolete|

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Emmi Takkinen changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #6

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Andrew Isherwood changed: What|Removed |Added CC|

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Emmi Takkinen changed: What|Removed |Added Status|NEW |Needs Signoff

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@outlook.com

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #3 from Katrin Fischer --- Hi Fiona, that makes sense now - thx. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #2 from Fiona Borthwick --- (In reply to Katrin Fischer from comment #1) > Can you explain the use case a bit more? > > The expiration date is how long the hold will be "valid" in the system > before it's filled (then

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 --- Comment #1 from Katrin Fischer --- Can you explain the use case a bit more? The expiration date is how long the hold will be "valid" in the system before it's filled (then it's pickup date...). So we would limit the holds to

[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Martin Renvoize changed: What|Removed |Added CC|