https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Lucas Gass changed:
What|Removed |Added
Blocks||34211
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Blocks||22440
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||33161
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #113 from Tomás Cohen Arazi ---
Pushed to master for 22.11.
Nice work everyone, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Version(s)||22.11.00
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #112 from Martin Renvoize ---
As discussed.. I updated the embed call to also refer to 'strings' as aposed to
'av_expand'.
Passed QA now :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143133|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #111 from Martin Renvoize ---
Created attachment 143362
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143362=edit
Bug 26635: (follow-up) Rename av_expand to strings
This patch updates the `av_expand`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143276|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143134|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143132|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143131|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143130|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143129|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143128|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143127|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Blocks||32118
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #102 from Kyle M Hall ---
> Yes, the idea, but I was expecting someone to tell me that "str" is ugly
> (especially when appearing twice :D)
> The second one can be 'str', not the first one.
Fix in the latest followup!
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #101 from Kyle M Hall ---
Created attachment 143276
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143276=edit
Bug 26635: (QA follow-up) Rename key _str to _strings
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #100 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #99)
> (In reply to Jonathan Druart from comment #98)
> > 1. "Add optional support for `:` as the modifier"
> > We should document that. Why do we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #99 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #98)
> 1. "Add optional support for `:` as the modifier"
> We should document that. Why do we have it here actually? Shouldn't it be on
> its own
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #98 from Jonathan Druart ---
1. "Add optional support for `:` as the modifier"
We should document that. Why do we have it here actually? Shouldn't it be on
its own bug?
2. Cannot we come with something better than
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #97 from Kyle M Hall ---
Created attachment 143134
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143134=edit
Bug 26635: (QA follow-up) Remove test for x-koha-av-expand header
This patch updates the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #96 from Kyle M Hall ---
Created attachment 143133
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143133=edit
Bug 26635: (follow-up) Add optional support for `:` as the modifier
This patch adds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #95 from Kyle M Hall ---
Created attachment 143132
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143132=edit
Bug 26635: Move expand syntax to x-koha-embed
Instead of a global av-expand flag (through
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #94 from Kyle M Hall ---
Created attachment 143131
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143131=edit
Bug 26635: Refined data structure and methods
This patch makes the returned data structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #93 from Kyle M Hall ---
Created attachment 143130
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143130=edit
Bug 26635: AV expansion should ackowledge $params->{public}
This patch simplifies the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #92 from Kyle M Hall ---
Created attachment 143129
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143129=edit
Bug 26635: Add tests for av-expand => 0
Signed-off-by: Martin Renvoize
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #91 from Kyle M Hall ---
Created attachment 143128
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143128=edit
Bug 26635: Expand authorised values in to_api method
This patch adds the posibility to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Kyle M Hall changed:
What|Removed |Added
Attachment #143073|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #89 from Tomás Cohen Arazi ---
(In reply to Martin Renvoize from comment #88)
> I'm loving this… signing off.
>
> The one very, very minor niggle… I'm wondering if `+av_expand` is right;
> With us switching to _str to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #87 from Martin Renvoize ---
Created attachment 143080
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143080=edit
Bug 26635: (QA follow-up) Remove test for x-koha-av-expand header
This patch updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #86 from Martin Renvoize ---
Created attachment 143079
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143079=edit
Bug 26635: (follow-up) Add optional support for `:` as the modifier
This patch adds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143044|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143043|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143042|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143041|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143040|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #143039|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #79 from Tomás Cohen Arazi ---
I haven't fully recovered, but... I get bored so...
I have submitted a revisited patch for revisiting the data structure and
methods, and then another interesting follow-up for getting rid
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #78 from Tomás Cohen Arazi ---
Created attachment 143044
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143044=edit
Bug 26635: Move expand syntax to x-koha-embed
Instead of a global av-expand flag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #77 from Tomás Cohen Arazi ---
Created attachment 143043
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143043=edit
Bug 26635: Refined data structure and methods
This patch makes the returned data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #76 from Tomás Cohen Arazi ---
Created attachment 143042
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143042=edit
Bug 26635: AV expansion should ackowledge $params->{public}
This patch simplifies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #75 from Tomás Cohen Arazi ---
Created attachment 143041
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143041=edit
Bug 26635: Add tests for av-expand => 0
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #74 from Tomás Cohen Arazi ---
Created attachment 143040
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143040=edit
Bug 26635: Expand authorised values in to_api method
This patch adds the posibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #73 from Tomás Cohen Arazi ---
Created attachment 143039
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143039=edit
Bug 26635: Add tests
Add tests in t/db_dependent/Koha/Object.t and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #142805|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #142804|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #142803|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #142802|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #142801|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #72 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #70)
> Then we could use the following structure
> {
> _str: {
> location: { str: "General Stacks", type: "authorised_values" },
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #71 from Martin Renvoize ---
OK, with that example I understand better where you were going with it.. makes
sense to me.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #70 from Jonathan Druart ---
Then we could use the following structure
{
_str: {
location: { str: "General Stacks", type: "authorised_values" },
itemtype: { str: "Books", type: "itemtypes" }
},
location:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #69 from Martin Renvoize ---
I though Tomas had answered your comment already Jonathan.
I think the key piece is that he wants both the string and the av category so
that one can produce the correct pick lists when
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #68 from Jonathan Druart ---
As said earlier (comment 29), IMO this should not be specific to AVs. It (the
new hash we are injecting) needs to reflect that it's a stringified version of
a coded field.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #142796|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #142795|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #142794|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #142793|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Martin Renvoize changed:
What|Removed |Added
Attachment #142792|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #61 from Martin Renvoize ---
So.. for my own sanity.. the final structure is this right:
GET /api/v1/items/1
{
"_authorized_values": {
"location": {
"category": "LOC",
"description":
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #60 from Tomás Cohen Arazi ---
Created attachment 142796
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142796=edit
Bug 26635: Refined data structure and methods
This patch makes the returned data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #59 from Tomás Cohen Arazi ---
Created attachment 142795
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142795=edit
Bug 26635: AV expansion should ackowledge $params->{public}
This patch simplifies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #58 from Tomás Cohen Arazi ---
Created attachment 142794
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142794=edit
Bug 26635: Add tests for av-expand => 0
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #57 from Tomás Cohen Arazi ---
Created attachment 142793
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142793=edit
Bug 26635: Expand authorised values in to_api method
This patch adds the posibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #56 from Tomás Cohen Arazi ---
Created attachment 142792
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142792=edit
Bug 26635: Add tests
Add tests in t/db_dependent/Koha/Object.t and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #142763|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #142762|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #142761|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #142776|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #55 from Tomás Cohen Arazi ---
Created attachment 142776
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142776=edit
Bug 26635: AV expansion should ackowledge $params->{public}
This patch simplifies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #54 from Tomás Cohen Arazi ---
Rebased so it works and devs can take a look. I will refactor this into 'coded
values' (not just AV) and will stick to a similar approach to Agustin's.
While I think just adding _str to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #53 from Tomás Cohen Arazi ---
Created attachment 142763
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142763=edit
Bug 26635: Add tests for av-expand => 0
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #52 from Tomás Cohen Arazi ---
Created attachment 142762
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142762=edit
Bug 26635: Expand authorised values in to_api method
This patch adds the posibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
--- Comment #51 from Tomás Cohen Arazi ---
Created attachment 142761
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142761=edit
Bug 26635: Add tests
Add tests in t/db_dependent/Koha/Object.t and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #120700|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #120699|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #124268|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635
Tomás Cohen Arazi changed:
What|Removed |Added
Summary|Expand authorised values in |Expand coded values in
85 matches
Mail list logo
