[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer changed: What|Removed |Added CC||anthony.laque...@ccsr.qc.ca

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21584 Referenced Bugs:

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED CC|

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Bug 2696 depends on bug 18790, which changed state. Bug 18790 Summary: Add ability to void payments https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790 What|Removed |Added ---

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Charles Quain changed: What|Removed |Added CC||c...@interleaf.ie -- You ar

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Jonathan Druart changed: What|Removed |Added Blocks||20841 Referenced Bugs: h

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer changed: What|Removed |Added Blocks||20840 Referenced Bugs: ht

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Jonathan Druart changed: What|Removed |Added Keywords|rel_18_05_candidate | -- You are receiving thi

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comme

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #45 from Kyle M Hall --- Created attachment 74817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74817&action=edit Bug 2696 [QA Followup]: Add more test, move to subtest -- You are receiving this mail

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #44 from Jonathan Druart --- Kyle, please move the tests to a separate subtest and also test the "return undef" parts. -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #43 from Kyle M Hall --- I have fixed everything except: -- @@ +42,5 @@ > + > +sub debit { > +my ( $self ) = @_; > +my $debit_rs = $self->_result->debit; > +return unless $debit_rs; I do not think we should "

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receivin

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #42 from Kyle M Hall --- Created attachment 74765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74765&action=edit Bug 2696 [QA Followup]: Fix POD, results sorting, permissions -- You are receiving thi

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #41 from Kyle M Hall --- (In reply to Jonathan Druart from comment #40) > It would also be great to use the new .inc in other parts of the code where > they are displayed, to avoid duplicated code (on a follow-up bug repor

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Jonathan Druart changed: What|Removed |Added Keywords||rel_18_05_candidate -- Yo

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #40

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #39 from Jonathan Druart --- Comment on attachment 74672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74672 Bug 2696: Fine payments should show what was paid for Review of attachment 74672: --> (ht

[Koha-bugs] [Bug 2696] Fine payments should show what was paid for

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer changed: What|Removed |Added Summary|Fine Payments Should Show |Fine payments should show

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer changed: What|Removed |Added Attachment #72088|0 |1 is obsolete|

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer changed: What|Removed |Added Attachment #72263|0 |1 is obsolete|

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are recei

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #36 from Katrin Fischer --- Created attachment 74672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74672&action=edit Bug 2696: Fine payments should show what was paid for Test Plan: 1) Apply this patch

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #38 from Katrin Fischer --- Created attachment 74674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74674&action=edit Bug 2696: (QA follow-up) Several fixes to template variables - Fix link to patron ac

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #37 from Katrin Fischer --- Created attachment 74673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74673&action=edit Bug 2696: (QA follow-up) - Remove use of GetMember Signed-off-by: Katrin Fischer -

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #35 from Katrin Fischer --- Comment on attachment 72088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72088 Bug 2696 - Fine Payments Should Show What Was Paid For Review of attachment 72088: --> (htt

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #34 from Katrin Fischer --- QA script and tests pass, will continue poking at this for a bit longer :) -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receivi

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #33 fro

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #32 from Kyle M Hall --- Created attachment 72263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72263&action=edit Bug 2696 [QA Followup] - Remove use of GetMember -- You are receiving this mail becaus

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receivi

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #31 from

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Alex Arnaud changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receivi

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Alex Arnaud changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #30 from

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Attachment #72024|0 |1 is obsolete|

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are rece

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #28 from Kyle M Hall --- (In reply to Alex Arnaud from comment #27) > Kyle, > > Haven't you forgotten to add accountline-details.pl, accountline-details.tt > and accounttype.inc in the last patch? Wow, no idea what happe

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receivin

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #27 from Alex Arnaud --- Kyle, Haven't you forgotten to add accountline-details.pl, accountline-details.tt and accounttype.inc in the last patch? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Claudio changed: What|Removed |Added CC||cost...@gmail.com -- You are rece

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #26 from Kyle M Hall --- (In reply to Alex Arnaud from comment #24) > Quick test gave me: > > - Error on accountline-details.pl: > "GetMember" is not exported by the C4::Members module > Can't continue after i

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Attachment #70031|0 |1 is obsolete|

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receivi

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Alex Arnaud changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #24 from

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Alex Arnaud changed: What|Removed |Added Attachment #67479|0 |1 is obsolete|

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Alex Arnaud changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |alex.arn...@biblibre.com

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.c

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Attachment #64350|0 |1 is obsolete|

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Lee Jamison changed: What|Removed |Added Attachment #64346|0 |1 is obsolete|

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Lee Jamison changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivi

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Lee Jamison changed: What|Removed |Added Attachment #64345|0 |1 is obsolete|

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Jonathan Druart changed: What|Removed |Added Severity|critical|major Kyle M Hall changed

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Lee Jamison changed: What|Removed |Added CC||ldjami...@marywood.edu --- Com

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Blocks||18805 Referenced Bugs: https

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Attachment #64287|0 |1 is obsolete|

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Attachment #9583|0 |1 is obsolete|

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Attachment #3069|0 |1 is obsolete|

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Attachment #800 is|0 |1 obsolete|

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #13 from Kyle M Hall --- Created attachment 64287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64287&action=edit Bug 2696 - Fine Payments Should Show What Was Paid For Test Plan: 1) Apply this patch a

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Medium patch Statu

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Depends on|14826 |18790 Referenced Bugs: https

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You ar

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Mike changed: What|Removed |Added CC||blac...@gmail.com,

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #12 from Katrin Fischer --- *** Bug 10167 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #11 from Chetan Panchal --- Thanks Kartin, I understood the problem. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. __

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #10 from Katrin Fischer --- Hi Chetan, this is not easy to solve, as one payment can be for multiple fines and can only include partial payments. This is why Kyle and others have been working on a rewrite of the accounts sy

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Chetan Panchal changed: What|Removed |Added CC||chetanpanchal...@hotmail.co

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added Depends on|6427|14826 CC|

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #8 from Katrin Fischer --- It's still an open bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. __

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Indranil Das Gupta changed: What|Removed |Added CC||indr...@gmail.com --- Co

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer changed: What|Removed |Added Depends on||6427 -- You are receiving t

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- C

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community.

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #4 from Nicole C. Engard --- Created attachment 9583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9583&action=edit staff with payment description It looks like in some cases it is now showing what was p

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #3 from Marc Véron --- Oh, I see that the primary key is already addressed in Bug 7671 - add a real primary key "accountlinesid" in accountlines. -- You are receiving this mail because: You are the QA Contact for the bug

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #2 fr

[Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Nicole C. Engard changed: What|Removed |Added AssignedTo|gmcha...@gmail.com |ian.walls@bywatersolutions.