[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Kyle M Hall changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 --- Comment #18 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-10-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-09-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 --- Comment #17 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #16) > (In reply to Jonathan Druart from comment #15) > Also clarifying the return "no" since you mentioned it: it is to keep intact > the > > > my

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@iki.fi ---

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-09-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 --- Comment #14 from Kyle M Hall --- Created attachment 124782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124782=edit Bug 27032: (follow-up) Pass rather than fetch variables Signed-off-by: Nick Clemens

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 --- Comment #13 from Kyle M Hall --- Created attachment 124781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124781=edit Bug 27032: Move auto renewal code out of CanBookBeRenewed This moves the checks related to

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Kyle M Hall changed: What|Removed |Added Attachment #121492|0 |1 is obsolete|

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-09-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-08-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 --- Comment #11 from Joonas Kylmälä --- Hi Kyle, I attached rebased patches. I simply did git rebase origin/master and git was able to resolve the conflict automatically and tests still passes so I think this is ready for QA. --

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 --- Comment #10 from Joonas Kylmälä --- Created attachment 121494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121494=edit Bug 27032: (follow-up) Pass rather than fetch variables Signed-off-by: Nick Clemens

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 --- Comment #9 from Joonas Kylmälä --- Created attachment 121493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121493=edit Bug 27032: Move auto renewal code out of CanBookBeRenewed This moves the checks related

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Joonas Kylmälä changed: What|Removed |Added Attachment #118593|0 |1 is obsolete|

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Joonas Kylmälä changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-05-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Joonas Kylmälä changed: What|Removed |Added Blocks|26659 | Referenced Bugs:

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Joonas Kylmälä changed: What|Removed |Added Text to go in the||Improvements to

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Nick Clemens changed: What|Removed |Added Attachment #113668|0 |1 is obsolete|

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 --- Comment #7 from Nick Clemens --- Created attachment 118595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118595=edit Bug 27032: (follow-up) Pass rather than fetch variables Signed-off-by: Nick Clemens --

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Nick Clemens changed: What|Removed |Added Attachment #113666|0 |1 is obsolete|

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-03-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-03-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Joonas Kylmälä changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2021-03-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2020-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2020-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Joonas Kylmälä changed: What|Removed |Added Attachment #113667|0 |1 is obsolete|

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2020-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 --- Comment #2 from Joonas Kylmälä --- Created attachment 113667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113667=edit Bug 27032: Move auto renewal code out of CanBookBeRenewed This moves the checks related

[Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring

2020-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 --- Comment #1 from Joonas Kylmälä --- Created attachment 113666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113666=edit Bug 27032: Remove unused variables -- You are receiving this mail because: You are