[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07,

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-12-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-12-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to master|Pushed to stable

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target| -- You are receiving th

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 --- Comment #19 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-27 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Jonathan Druart changed: What|Removed |Added Attachment #114019|0 |1 is obsolete|

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #114001|0 |1 is obsole

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #114000|0 |1 is obsole

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #113999|0 |1 is obsole

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Josef Moravec changed: What|Removed |Added Attachment #113997|0 |1 is obsolete|

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Josef Moravec changed: What|Removed |Added Attachment #113984|0 |1 is obsolete|

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Josef Moravec changed: What|Removed |Added Attachment #113983|0 |1 is obsolete|

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 --- Comment #10 from Martin Renvoize --- Created attachment 113997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113997&action=edit Bug 27079: (QA follow-up) Round both sides for clarity -- You are receiving thi

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 --- Comment #9 from Jonathan Druart --- (In reply to Martin Renvoize from comment #7) > The value coming from the database is in effect already rounded.. al be it > to 6 decimal places instead of 2.. Yes, that's why I added "to be

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Jonathan Druart changed: What|Removed |Added Keywords||rel_20_11_target -- You

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 --- Comment #8 from Martin Renvoize --- My feeling is.. get this one in as is and work on a much nicer solution to catch cases in a more general way in bug 17138 for the 21.05 cycle. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 --- Comment #7 from Martin Renvoize --- The value coming from the database is in effect already rounded.. al be it to 6 decimal places instead of 2.. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 --- Comment #6 from Jonathan Druart --- Should not we compare the 2 rounded values (to be on the safe side)? -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Martin Renvoize changed: What|Removed |Added Attachment #113981|0 |1 is obsolete|

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 --- Comment #4 from Martin Renvoize --- Created attachment 113983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113983&action=edit Bug 27079: Unit tests Add a unit test to check for floating point errors in Updat

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Martin Renvoize changed: What|Removed |Added Blocks||17138 Referenced Bugs:

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 --- Comment #2 from Martin Renvoize --- Created attachment 113981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113981&action=edit Bug 27079: Floating point comparison correction We cannot compare calculated valu

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 --- Comment #1 from Martin Renvoize --- Looking at this at the moment... Our dealing with money and floating point are generally a mess. :( -- You are receiving this mail because: You are watching all bug changes. You are the assig

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Kyle M Hall changed: What|Removed |Added Severity|normal |major -- You are receiving t

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return

2020-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c