https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
jmbroust changed:
What|Removed |Added
CC||jean-manuel.broust@univ-lyo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Pushed to oldstable |Pushed to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Andrew Fuerste-Henry changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Fridolin Somers changed:
What|Removed |Added
Status|Pushed to master|Pushed to stable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Jonathan Druart changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #28 from Jonathan Druart ---
Pushed to master for 21.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #27 from Victor Grousset/tuxayo ---
Thanks for the test and QA :D
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Katrin Fischer changed:
What|Removed |Added
Attachment #120725|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Katrin Fischer changed:
What|Removed |Added
Attachment #120724|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Passed QA
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #24 from Katrin Fischer ---
4 - Display all columns, 'Actual cost tax inc.' are GST columns aren't set.
That is the line that realy confused me. I kept looking at the Actual cost
columns, but you actually need to look
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #23 from Victor Grousset/tuxayo ---
(In reply to Katrin Fischer from comment #21)
> To me the table with the prices (basket summary) looks exactly the same with
> and without patch...so that's why I am confused.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #22 from Nick Clemens ---
Created attachment 120765
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120765=edit
Changes after the patch
Existing orders are not affected - the 'Actual cost/unitprice' is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #21 from Katrin Fischer ---
To me the table with the prices (basket summary) looks exactly the same with
and without patch...so that's why I am confused.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #20 from Victor Grousset/tuxayo ---
> The "Actual cost" (incl. or excl.) look exactly the same to me, both showing
> 0.00.
IIUC it's what the patch does. It's different from the 1st patch which not only
made the GST to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #19 from Katrin Fischer ---
I am sorry, but I fail to understand the problem here :(
I assume that we are looking at the basket summary page. Correct?
I created 2 orders, one pre-patch and one post-patch, actual cost
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #18 from Victor Grousset/tuxayo ---
Still works. Tests work.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #120552|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #120551|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #15 from Victor Grousset/tuxayo ---
> unitprice remains 0.
More like 'Actual cost tax inc.' right?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #14 from Nick Clemens ---
(In reply to Jonathan Druart from comment #11)
> Nick, can you confirm your patch is independent from the first one?
>
> Tests are missing.
They are independent, I obsoleted the first and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #13 from Nick Clemens ---
Created attachment 120552
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120552=edit
Bug 27203: [alternate] Calculate tax based on ecost if unitprice not set
There is code in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Nick Clemens changed:
What|Removed |Added
Attachment #120249|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Katrin Fischer changed:
What|Removed |Added
Summary|Order unitprice is not set |Order unitprice is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #10 from Victor Grousset/tuxayo ---
Both patches do what they advertise. Including the difference on step 7 (I
missed it the first when testing)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #120052|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #120051|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #7 from Victor Grousset/tuxayo ---
Wait, IIUC sandboxes don't allow to apply only one patch. Retest results
coming.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Victor Grousset/tuxayo changed:
What|Removed |Added
CC||vic...@tuxayo.net
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Nick Clemens changed:
What|Removed |Added
Severity|enhancement |major
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Aleisha Amohia changed:
What|Removed |Added
CC|alei...@catalyst.net.nz |
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #5 from Marjorie Barry-Vila ---
Created attachment 120053
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120053=edit
sandbox_ecost
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #114476|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #114342|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Marjorie Barry-Vila changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Nick Clemens changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #2 from Nick Clemens ---
Created attachment 114476
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114476=edit
Bug 27203: [alternate] Calculate tax based on ecost if unitprice not set
There is code in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Aleisha Amohia changed:
What|Removed |Added
CC||alei...@catalyst.net.nz
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
--- Comment #1 from Didier Gautheron ---
Created attachment 114342
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114342=edit
Bug 27203: (Bug 23294 follow up) set unitprice to ecost if it's 0.
Test plan:
1 -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203
Didier Gautheron changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You
41 matches
Mail list logo