[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What|Removed |Added Blocks||27865 Referenced Bugs:

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |RESOLVED R

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Bug 27205 depends on bug 27209, which changed state. Bug 27209 Summary: Add Koha::Hold->set_pickup_location https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 What|Removed |Added --

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutio

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #14 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #12) > Tomas, do you agree it reads better like that? +1 -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #12 from Jonathan Druart --- Tomas, do you agree it reads better like that? -unless ( -!defined $pickup_library_id -or $hold->is_pickup_location_valid( -{ library_id => $p

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #11 from Jonathan Druart --- Created attachment 114512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114512&action=edit Bug 27205: Improve logic readability in conditional -- You are receiving this

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #10 from Kyle M Hall --- Created attachment 114447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114447&action=edit Bug 27205: Check valid pickup location on POST /holds This patch adds a check for va

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Kyle M Hall changed: What|Removed |Added Attachment #114377|0 |1 is obsolete|

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receivi

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #114382|0 |1 is obsole

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 114382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114382&action=edit Bug 27205: Check valid pickup location on POST /holds This patch adds a check f

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #114375|0 |1 is obsole

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 114375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114375&action=edit Bug 27205: Check valid pickup location on PUT /holds/:hold_id This patch adds a

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #3) > Even after restarting the services, the tests don't pass: Sorry for that, it was a missing dependency on the bug. Anyway, I updated the

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What|Removed |Added CC||jonathan.dru...@bugs.koh

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What|Removed |Added Attachment #114358|0 |1 is obsolete|

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What|Removed |Added Depends on||27209 Referenced Bugs:

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comme

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 114358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114358&action=edit Bug 27205: Check valid pickup location on PUT /holds/:hold_id This patch adds a

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What|Removed |Added Depends on|27209 | Referenced Bugs: htt

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What|Removed |Added Depends on||27209 Referenced Bugs:

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are rece

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --

[Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Jonathan Druart changed: What|Removed |Added Blocks||18729 Referenced Bugs: