[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutio

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #17 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Katrin Fischer changed: What|Removed |Added Attachment #116389|0 |1 is obsolete|

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexi

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #15 from Katrin Fischer --- This is so much better, thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.k

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #14 from Martin Renvoize --- This bug now also disables the immediate call to validate the amount collected against the amount owed when items are added to the basket... as requested by Katrin in bug 27289. -- You are r

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are re

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Attachment #114757|0 |1 is obsolete|

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Blocks||26926 Referenced Bugs:

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #12 fr

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Depends on|27282 |27289 Referenced Bugs:

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #11 from Martin Renvoize --- Looks like Owen was working on similar improvements at the same time.. so I've tested and signed off his work on bug 27282 and made this dependant upon it and squashed the final outcome here..

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Attachment #114748|0 |1 is obsolete|

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Attachment #114747|0 |1 is obsolete|

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Attachment #114749|0 |1 is obsolete|

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Depends on||27282 Referenced Bugs:

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Blocks||13985 Referenced Bugs:

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #9 from Martin Renvoize --- OK, reading the followup highlighted some further issues.. I think during a rebase somewhere we ended up with duplication of code blocks causing random issues. I've cleaned up the duplication

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #8 from Martin Renvoize --- Created attachment 114749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114749&action=edit Bug 27290: Clean up validation It seems we had the validator instantiated twice a

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Attachment #114671|0 |1 is obsolete|

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Attachment #114670|0 |1 is obsolete|

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #5 from Nick Clemens --- (In reply to Martin Renvoize from comment #2) > I think there's some browser ambiguity here.. I tested on latest Chrome, > Firefox and Brave browsers and all worked as expected with this patch...

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #4 from Nick Clemens --- Created attachment 114671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114671&action=edit Bug 27290: (follow-up) fix filters - make register required Signed-off-by: Nick Clem

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Nick Clemens changed: What|Removed |Added Attachment #114568|0 |1 is obsolete|

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexit

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #2 from Martin Renvoize --- I think there's some browser ambiguity here.. I tested on latest Chrome, Firefox and Brave browsers and all worked as expected with this patch... but I'm not entirely confident in my fix... it'

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #1 from Martin Renvoize --- Created attachment 114568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114568&action=edit Bug 27290: Update 'type=number' to 'type=text inputmode=numeric' This patch updat

[Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe