[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Victor Grousset/tuxayo changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Andrew Fuerste-Henry changed: What|Removed |Added CC|

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 --- Comment #30 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 --- Comment #29 from Victor Grousset/tuxayo --- > It does remove the tooltip, not only when the copy is not possible, but > always. It adds the tooltip when window.isSecureContext true In my last patch I removed the tooltip in the

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA ---

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 --- Comment #25 from Victor Grousset/tuxayo --- > I don't know how else to test this in an environment that isn't considered by > the browser to be secure for the purposes of copy and paste operations (as > local addresses are).

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 --- Comment #24 from Victor Grousset/tuxayo --- Created attachment 120416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120416=edit Bug 27594: (follow-up) don't display "Copy link[...]" when not possible

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 David Nind changed: What|Removed |Added Attachment #119906|0 |1 is obsolete|

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 David Nind changed: What|Removed |Added Attachment #119305|0 |1 is obsolete|

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 David Nind changed: What|Removed |Added Attachment #119304|0 |1 is obsolete|

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Attachment #119398|0 |1 is obsolete|

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #19

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 --- Comment #17 from Owen Leonard --- Created attachment 119398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119398=edit Bug 27594: (follow-up) Check for secure context -- You are receiving this mail because:

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Victor Grousset/tuxayo changed: What|Removed |Added Status|In Discussion |Failed QA ---

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion -- You

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 --- Comment #14 from Jonathan Druart --- Created attachment 119305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119305=edit Bug 27594: (QA follow-up): Display message only if copy worked And check if writeText

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Jonathan Druart changed: What|Removed |Added Attachment #117289|0 |1 is obsolete|

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 David Nind changed: What|Removed |Added Text to go in the||This patch adds a link to

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Passed QA ---

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 --- Comment #11 from Victor Grousset/tuxayo --- Created attachment 119241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119241=edit Bug 27594: (QA follow-up): Display message only if copy worked And check if

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 --- Comment #9 from David Nind --- Can confirm that with the follow up patch, everything continues to work as per the test plan. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 --- Comment #8 from Owen Leonard --- Created attachment 117310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117310=edit Bug 27594: (QA follow-up): Use clipboard API While the Clipboard API doesn't have 100%

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 --- Comment #7 from David Cook --- Oh I guess I could QA this... I'm not sure what I think of the copToClipboard function. It seems pretty hacky. What are your thoughts on the clipboard API that I was using at

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 --- Comment #6 from David Cook --- *** Bug 25475 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au ---

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 David Nind changed: What|Removed |Added CC||da...@davidnind.com ---

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 David Nind changed: What|Removed |Added Attachment #116219|0 |1 is obsolete|

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Attachment #116218|0 |1 is obsolete|

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 --- Comment #1 from Owen Leonard --- Created attachment 116218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116218=edit Bug 27594: Add access to public download link for publicly-accessible uploads This patch

[Koha-bugs] [Bug 27594] Add access to public download link for publicly-accessible uploads

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27594 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch